[GitHub] [incubator-datasketches-postgresql] leerho commented on a change in pull request #28: add dockerfile

[GitBox <gi...@apache.org>]

leerho commented on a change in pull request #28:
URL: https://github.com/apache/incubator-datasketches-postgresql/pull/28#discussion_r456725744



##########
File path: Dockerfile
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG PG_MAJOR_VERSION=9.6
+ARG PG_MINOR_VERSION=9.6.18
+ARG BASE_IMAGE_VERSION=9.6.18
+
+ARG DATASKETCHES_CPP_VERSION=2.0.0-incubating
+
+FROM postgres:$BASE_IMAGE_VERSION
+
+MAINTAINER dev@datasketches.apache.org
+
+ARG PG_MAJOR_VERSION
+ARG PG_MINOR_VERSION
+ARG DATASKETCHES_CPP_VERSION
+
+ENV PG_MAJOR=$PG_MAJOR_VERSION
+ENV PG_MINOR=$PG_MINOR_VERSION
+ENV DATASKETCHES_CPP=$DATASKETCHES_CPP_VERSION
+
+
+ADD . /datasketches-postgresql
+WORKDIR /datasketches-postgresql
+
+RUN echo "===> Adding prerequisites..."                      && \
+    apt-get update -y                                        && \
+    DEBIAN_FRONTEND=noninteractive                              \
+        apt-get install --no-install-recommends --allow-downgrades -y -q \
+                ca-certificates                                 \
+                build-essential wget                            \
+                postgresql-server-dev-$PG_MAJOR=$PG_MINOR\*     \
+                libpq-dev=$PG_MINOR\* libpq5=$PG_MINOR\* libecpg-dev && \
+    \
+    \                
+    echo "===> Building datasketches..."                     && \
+    wget https://github.com/apache/incubator-datasketches-cpp/archive/$DATASKETCHES_CPP.tar.gz && \

Review comment:
       Downloading apache releases from github is not allowed.   And to do it automatically requires a script to balance between mirrors.  Please read [](https://infra.apache.org/release-download-pages).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org