You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/12/05 19:48:23 UTC
Review Request 28764: Extended error message for module manager when
library loading fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/
-----------------------------------------------------------
Review request for mesos, Kapil Arya and Niklas Nielsen.
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/module/manager.cpp b15b0fc
Diff: https://reviews.apache.org/r/28764/diff/
Testing
-------
make check and functional testing with a broken module library.
Thanks,
Till Toenshoff
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Till Toenshoff <to...@me.com>.
> On Dec. 5, 2014, 6:56 p.m., Niklas Nielsen wrote:
> > src/module/manager.cpp, lines 199-200
> > <https://reviews.apache.org/r/28764/diff/1/?file=783851#file783851line199>
> >
> > I'd prefer not to align around '(' - can you bring both lines down (4 space indent)?
Actually just saw that Kapil did it the way you describe after I upped this RR - my bad :) .
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64057
-----------------------------------------------------------
On Dec. 5, 2014, 6:48 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:48 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64057
-----------------------------------------------------------
src/module/manager.cpp
<https://reviews.apache.org/r/28764/#comment106428>
I'd prefer not to align around '(' - can you bring both lines down (4 space indent)?
- Niklas Nielsen
On Dec. 5, 2014, 10:48 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 10:48 a.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64062
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28764]
All tests passed.
- Mesos ReviewBot
On Dec. 5, 2014, 6:48 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:48 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64408
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On Dec. 5, 2014, 2:46 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:46 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64110
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Dec. 5, 2014, 11:46 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 11:46 a.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/#review64068
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28764]
All tests passed.
- Mesos ReviewBot
On Dec. 5, 2014, 7:46 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28764/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 7:46 p.m.)
>
>
> Review request for mesos, Kapil Arya and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/module/manager.cpp b15b0fc
>
> Diff: https://reviews.apache.org/r/28764/diff/
>
>
> Testing
> -------
>
> make check and functional testing with a broken module library.
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 28764: Extended error message for module manager
when library loading fails.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28764/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 7:46 p.m.)
Review request for mesos, Kapil Arya and Niklas Nielsen.
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
src/module/manager.cpp b15b0fc
Diff: https://reviews.apache.org/r/28764/diff/
Testing
-------
make check and functional testing with a broken module library.
Thanks,
Till Toenshoff