[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching

[GitBox <gi...@apache.org>]

htran1 commented on a change in pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching
URL: https://github.com/apache/incubator-gobblin/pull/2789#discussion_r341686549
 
 

 ##########
 File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java
 ##########
 @@ -295,23 +295,34 @@ protected void executeCancellation() {
         SerializationUtils.serializeState(this.fs, jobStateFilePath, this.jobContext.getJobState());
       }
 
-      LOGGER.debug("GobblinHelixJobLauncher.createJob: jobStateFilePath {}, jobState {} jobProperties {}",
+      // Block on all persistency of workunits finished
+      // It is necessary when underlying storage being and Helix activate task-execution before the workunit being persisted.
 
 Review comment:
   `storage being and`? Seems like something is missing here in this comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services