You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/08 00:51:39 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1233: Fix unstable test TestListenerCallback
kaisun2000 opened a new issue #1233:
URL: https://github.com/apache/helix/issues/1233
TestListenerCallback relies on sleep(500ms). This is the source of unstableness of this test. We should change it to Test.verify( lambda to validate, 'larger converative timeout value');
For example, here is one log:
[ERROR] testScopedConfigChangeListener(org.apache.helix.TestListenerCallback) Time elapsed: 1.149 s <<< FAILURE!
java.lang.AssertionError: Should get clusterConfig callback invoked since we change clusterConfig expected: but was:
at org.apache.helix.TestListenerCallback.testScopedConfigChangeListener(TestListenerCallback.java:231)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #1233: Fix unstable test TestListenerCallback
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1233:
URL: https://github.com/apache/helix/issues/1233#issuecomment-849102225
Close test unstable tickets since we have an automatic tracking mechanism https://github.com/apache/helix/pull/1757 now for tracking the most recent test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1233: Fix unstable test TestListenerCallback
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1233:
URL: https://github.com/apache/helix/issues/1233#issuecomment-675119683
#1227 address this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #1233: Fix unstable test TestListenerCallback
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1233:
URL: https://github.com/apache/helix/issues/1233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org