You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/31 22:59:37 UTC
[GitHub] [airflow] kaxil opened a new pull request #15122: Skip `DatabaseVersionCheckRule` check if invalid version is detected
kaxil opened a new pull request #15122:
URL: https://github.com/apache/airflow/pull/15122
When the version is something like `12.2 (Debian 12.2-2.pgdg100+1)`, the upgrade check errors with the following:
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 130, in __main__
run(args)
File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 118, in run
all_problems = check_upgrade(formatter, rules)
File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 38, in check_upgrade
rule_status = RuleStatus.from_rule(rule)
File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/problem.py", line 44, in from_rule
result = rule.check()
File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/rules/postgres_mysql_sqlite_version_upgrade_check.py", line 52, in check
installed_postgres_version = Version(session.execute('SHOW server_version;').scalar())
File "/usr/local/lib/python3.7/site-packages/packaging/version.py", line 298, in __init__
raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: '12.2 (Debian 12.2-2.pgdg100+1)'
```
This commit will SKIP the check during such occasions.
cc @Dr-Denzy
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15122: Skip `DatabaseVersionCheckRule` check if invalid version is detected
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15122:
URL: https://github.com/apache/airflow/pull/15122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15122: Skip `DatabaseVersionCheckRule` check if invalid version is detected
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15122:
URL: https://github.com/apache/airflow/pull/15122#issuecomment-812743697
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Dr-Denzy commented on pull request #15122: Skip `DatabaseVersionCheckRule` check if invalid version is detected
Posted by GitBox <gi...@apache.org>.
Dr-Denzy commented on pull request #15122:
URL: https://github.com/apache/airflow/pull/15122#issuecomment-811522320
> When the version is something like `12.2 (Debian 12.2-2.pgdg100+1)`, the upgrade check errors with the following:
>
> ```
> Traceback (most recent call last):
> File "<string>", line 1, in <module>
> File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 130, in __main__
> run(args)
> File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 118, in run
> all_problems = check_upgrade(formatter, rules)
> File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/checker.py", line 38, in check_upgrade
> rule_status = RuleStatus.from_rule(rule)
> File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/problem.py", line 44, in from_rule
> result = rule.check()
> File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
> return func(*args, **kwargs)
> File "/usr/local/lib/python3.7/site-packages/airflow/upgrade/rules/postgres_mysql_sqlite_version_upgrade_check.py", line 52, in check
> installed_postgres_version = Version(session.execute('SHOW server_version;').scalar())
> File "/usr/local/lib/python3.7/site-packages/packaging/version.py", line 298, in __init__
> raise InvalidVersion("Invalid version: '{0}'".format(version))
> packaging.version.InvalidVersion: Invalid version: '12.2 (Debian 12.2-2.pgdg100+1)'
> ```
>
> This commit will SKIP the check during such occasions.
>
> cc @Dr-Denzy
>
> **^ Add meaningful description above**
>
> Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
> In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
> In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
> In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org