You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/20 17:43:01 UTC

[GitHub] azai91 commented on a change in pull request #12019: [MXNET-753] Fallback when using non-MKLDNN supported operators

azai91 commented on a change in pull request #12019: [MXNET-753] Fallback when using non-MKLDNN supported operators
URL: https://github.com/apache/incubator-mxnet/pull/12019#discussion_r211348876
 
 

 ##########
 File path: src/executor/attach_op_execs_pass.cc
 ##########
 @@ -40,6 +40,11 @@ const OperatorProperty* OpPropGetOpProperty(const NodeAttrs& attrs);
 
 namespace exec {
 
+class MKLDNNOpExecutor : public OpExecutor {
+ protected:
+  std::vector<NDArray> in_array_fallback;
 
 Review comment:
   there is a race condition if we attempt to reorder the `read_var` in place. other operators may be trying to read from it the same time (since they are expected to be read only consts)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services