You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/02 19:25:07 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #9618: ARROW-11582: [R] write_dataset 'format' argument default and validati…

jonkeane commented on a change in pull request #9618:
URL: https://github.com/apache/arrow/pull/9618#discussion_r585844378



##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -1061,6 +1061,17 @@ test_that("Writing a dataset: Parquet->Parquet (default)", {
   )
 })
 
+test_that("Writing a dataset: Not specified format", {
+  skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-9651
+  dst_dir <- make_temp_dir()
+  write_dataset(mtcars, dst_dir)
+  new_ds <- open_dataset(dst_dir)

Review comment:
       Should we assert that this has produced parquet files / the dataset as opened is parquet files?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org