You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/10/18 17:18:10 UTC
[GitHub] incubator-beam pull request #1127: Restore trigger-related tests missed in #...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1127
Restore trigger-related tests missed in #1083
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @lukecwik
This is a follow-up of #1118, restoring a couple more things missed in #1083.
The commit that merged #1083 is e969f3d. At the time I confirmed that `src/main` and `src/test/sdk/transforms/windowing` were unchanged, but neglected `util`. Here is a transcript demonstrating the genesis of this patch:
```
$ git diff --stat e969f3d^1 e969f3d^2 sdks/java/core/src/main
$ git diff --stat e969f3d^1 e969f3d^2 sdks/java/core/src/test
sdks/java/core/src/test/java/org/apache/beam/sdk/util/ExecutableTriggerTest.java | 127 ------------------------------------------------------------------------------------------------------------------
sdks/java/core/src/test/java/org/apache/beam/sdk/util/FinishedTriggersBitSetTest.java | 55 -------------------------------------------------
sdks/java/core/src/test/java/org/apache/beam/sdk/util/FinishedTriggersProperties.java | 110 --------------------------------------------------------------------------------------------------
sdks/java/core/src/test/java/org/apache/beam/sdk/util/FinishedTriggersSetTest.java | 60 ------------------------------------------------------
sdks/java/core/src/test/java/org/apache/beam/sdk/util/ReshuffleTriggerTest.java | 67 ------------------------------------------------------------
5 files changed, 419 deletions(-)
```
I then checked each of these out at `e969f3d^1`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam trigger-util-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1127
----
commit b8c48171c9593da2652ed40a221cda0fbe30d49a
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-10-18T17:11:37Z
Restore trigger-related tests missed in #1083
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1127: Restore trigger-related tests missed in #...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---