You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/29 21:18:51 UTC
Review Request 71184: Added expected drain end time to webui's agent
screen.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Bugs: MESOS-9907
https://issues.apache.org/jira/browse/MESOS-9907
Repository: mesos
Description
-------
Added expected drain end time to webui's agent screen.
Diffs
-----
src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
Diff: https://reviews.apache.org/r/71184/diff/1/
Testing
-------
* `make check`
* patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
Thanks,
Benjamin Bannier
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 30, 2019, 10:19 a.m., Greg Mann wrote:
> > src/webui/app/agents/agent.html
> > Line 64 (original), 64 (patched)
> > <https://reviews.apache.org/r/71184/diff/1/?file=2158121#file2158121line64>
> >
> > Why "grace time" instead of "grace period"?
>
> Benjamin Bannier wrote:
> I am not a native speaker, but to me "period" would indicate an interval, while "time" denotes a point in time.
>
> Let's either keep this or use something else clearly distinguished from an interval (`max_grace_deadline_seconds`?). WDYT?
OK gotcha - how about something like "Estimated drain end time"?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216956
-----------------------------------------------------------
On July 30, 2019, 12:40 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 12:40 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/2/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Benjamin Bannier <bb...@apache.org>.
> On July 30, 2019, 12:19 p.m., Greg Mann wrote:
> > src/webui/app/agents/agent.html
> > Line 64 (original), 64 (patched)
> > <https://reviews.apache.org/r/71184/diff/1/?file=2158121#file2158121line64>
> >
> > Why "grace time" instead of "grace period"?
I am not a native speaker, but to me "period" would indicate an interval, while "time" denotes a point in time.
Let's either keep this or use something else clearly distinguished from an interval (`max_grace_deadline_seconds`?). WDYT?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216956
-----------------------------------------------------------
On July 30, 2019, 2:40 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 2:40 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/2/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216956
-----------------------------------------------------------
src/webui/app/agents/agent.html
Line 64 (original), 64 (patched)
<https://reviews.apache.org/r/71184/#comment304191>
Why "grace time" instead of "grace period"?
src/webui/app/controllers.js
Lines 725 (patched)
<https://reviews.apache.org/r/71184/#comment304190>
Is this leftover from debugging?
- Greg Mann
On July 29, 2019, 9:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 29, 2019, 9:18 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/1/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216931
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71180, 71181, 71182, 71183, 71184]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 29, 2019, 9:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 29, 2019, 9:18 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/1/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review217018
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71180, 71181, 71182, 71183, 71184]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 30, 2019, 12:40 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 12:40 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/4/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216994
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 30, 2019, 12:40 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 12:40 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/4/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/#review216970
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71180, 71181, 71182, 71183, 71184]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 30, 2019, 5:40 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71184/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 5:40 a.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-9907
> https://issues.apache.org/jira/browse/MESOS-9907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added expected drain end time to webui's agent screen.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
> src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
>
>
> Diff: https://reviews.apache.org/r/71184/diff/2/
>
>
> Testing
> -------
>
> * `make check`
> * patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71184: Added expected drain end time to webui's
agent screen.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71184/
-----------------------------------------------------------
(Updated July 30, 2019, 2:40 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Rebase; remove stray debug logging
Bugs: MESOS-9907
https://issues.apache.org/jira/browse/MESOS-9907
Repository: mesos
Description
-------
Added expected drain end time to webui's agent screen.
Diffs (updated)
-----
src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf
src/webui/app/controllers.js 725230f415b66166543c132a4409d2da303cc1e6
Diff: https://reviews.apache.org/r/71184/diff/2/
Changes: https://reviews.apache.org/r/71184/diff/1-2/
Testing
-------
* `make check`
* patched agent to not discard `drainConfig` and inspected screen for `drained` agent run via `mesos-local`
Thanks,
Benjamin Bannier