[GitHub] spark pull request #13749: [SPARK-16034][SQL] Checks the partition columns w...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13749#discussion_r67596783
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -435,26 +435,25 @@ case class DataSource(
             // If we are appending to a table that already exists, make sure the partitioning matches
             // up.  If we fail to load the table for whatever reason, ignore the check.
             if (mode == SaveMode.Append) {
    -          val existingPartitionColumnSet = try {
    -            Some(
    -              resolveRelation()
    -                .asInstanceOf[HadoopFsRelation]
    -                .location
    -                .partitionSpec()
    -                .partitionColumns
    -                .fieldNames
    -                .toSet)
    -          } catch {
    -            case e: Exception =>
    -              None
    -          }
    -
    -          existingPartitionColumnSet.foreach { ex =>
    -            if (ex.map(_.toLowerCase) != partitionColumns.map(_.toLowerCase()).toSet) {
    -              throw new AnalysisException(
    -                s"Requested partitioning does not equal existing partitioning: " +
    -                s"$ex != ${partitionColumns.toSet}.")
    -            }
    +          val existingColumns = Try {
    +            resolveRelation()
    +              .asInstanceOf[HadoopFsRelation]
    +              .location
    +              .partitionSpec()
    +              .partitionColumns
    +              .fieldNames
    +              .toSeq
    +          }.getOrElse(Seq.empty[String])
    +          val sameColumns =
    +            existingColumns.map(_.toLowerCase) == partitionColumns.map(_.toLowerCase)
    +          if (existingColumns.size > 0 && !sameColumns) {
    +            throw new AnalysisException(
    +              s"""Requested partitioning does not match existing partitioning.
    --- End diff --
    
    can you add "Requested partitioning does not match existing partitioning for table $table" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org