You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/02/03 03:28:11 UTC
Re: Review Request 17004: Create view does not captures inputs


> On Jan. 31, 2014, 9:02 a.m., Thejas Nair wrote:
> > ql/src/test/results/clientnegative/deletejar.q.out, line 1
> > <https://reviews.apache.org/r/17004/diff/2/?file=453656#file453656line1>
> >
> >     Looks like this test change is incorrect.
> >

Sorry.


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17004/#review33305
-----------------------------------------------------------


On Jan. 29, 2014, 7:36 a.m., Navis Ryu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17004/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2014, 7:36 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5859
>     https://issues.apache.org/jira/browse/HIVE-5859
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> For example, 
> CREATE VIEW view_j5jbymsx8e_1 as SELECT * FROM tbl_j5jbymsx8e;
> 
> should capture "default.tbl_j5jbymsx8e" as input entity for authorization process but currently it's not.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 4ee3d6b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 5e8dc41 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1f7aae0 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java e1a3dce 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 228f938 
>   ql/src/test/results/clientnegative/alter_view_as_select_with_partition.q.out 291d7fb 
>   ql/src/test/results/clientnegative/alter_view_failure.q.out 4bda31e 
>   ql/src/test/results/clientnegative/alter_view_failure2.q.out a27094a 
>   ql/src/test/results/clientnegative/alter_view_failure4.q.out 662b431 
>   ql/src/test/results/clientnegative/alter_view_failure5.q.out c06428f 
>   ql/src/test/results/clientnegative/alter_view_failure6.q.out 0274e0b 
>   ql/src/test/results/clientnegative/alter_view_failure7.q.out 5e1eea2 
>   ql/src/test/results/clientnegative/alter_view_failure9.q.out 6003d7d 
>   ql/src/test/results/clientnegative/analyze_view.q.out c321543 
>   ql/src/test/results/clientnegative/create_or_replace_view1.q.out 65b3ef7 
>   ql/src/test/results/clientnegative/create_or_replace_view2.q.out a26c8b3 
>   ql/src/test/results/clientnegative/create_or_replace_view4.q.out a1d158f 
>   ql/src/test/results/clientnegative/create_or_replace_view5.q.out 03576fb 
>   ql/src/test/results/clientnegative/create_or_replace_view6.q.out 447dc2f 
>   ql/src/test/results/clientnegative/create_or_replace_view7.q.out 0abfc3d 
>   ql/src/test/results/clientnegative/create_or_replace_view8.q.out a46ce12 
>   ql/src/test/results/clientnegative/create_view_failure1.q.out 75d83a5 
>   ql/src/test/results/clientnegative/create_view_failure2.q.out e7bde22 
>   ql/src/test/results/clientnegative/create_view_failure4.q.out 9b0fa96 
>   ql/src/test/results/clientnegative/deletejar.q.out b873e34 
>   ql/src/test/results/clientnegative/drop_table_failure2.q.out 7681716 
>   ql/src/test/results/clientnegative/insert_view_failure.q.out 0e43ee9 
>   ql/src/test/results/clientnegative/invalidate_view1.q.out c322777 
>   ql/src/test/results/clientnegative/load_view_failure.q.out 68223f0 
>   ql/src/test/results/clientnegative/recursive_view.q.out 1171fa8 
>   ql/src/test/results/clientnegative/unset_view_property.q.out 1e15b47 
>   ql/src/test/results/clientpositive/alter_view_as_select.q.out 41f95c1 
>   ql/src/test/results/clientpositive/alter_view_rename.q.out d6838f5 
>   ql/src/test/results/clientpositive/authorization_8.q.out b66fabc 
>   ql/src/test/results/clientpositive/create_big_view.q.out 20a4dc1 
>   ql/src/test/results/clientpositive/create_like_tbl_props.q.out 039fbe3 
>   ql/src/test/results/clientpositive/create_like_view.q.out e0bacbc 
>   ql/src/test/results/clientpositive/create_or_replace_view.q.out bb9b669 
>   ql/src/test/results/clientpositive/create_view.q.out 0ef27da 
>   ql/src/test/results/clientpositive/create_view_partitioned.q.out 72adb18 
>   ql/src/test/results/clientpositive/create_view_translate.q.out 3c98794 
>   ql/src/test/results/clientpositive/ctas_char.q.out 3a172b8 
>   ql/src/test/results/clientpositive/ctas_date.q.out c3404fe 
>   ql/src/test/results/clientpositive/ctas_varchar.q.out a4a9c66 
>   ql/src/test/results/clientpositive/database_drop.q.out 38279b8 
>   ql/src/test/results/clientpositive/describe_formatted_view_partitioned.q.out e384a4d 
>   ql/src/test/results/clientpositive/describe_formatted_view_partitioned_json.q.out ba56c0b 
>   ql/src/test/results/clientpositive/explain_dependency.q.out 2f272bb 
>   ql/src/test/results/clientpositive/explain_logical.q.out 437844c 
>   ql/src/test/results/clientpositive/join_view.q.out dac0b02 
>   ql/src/test/results/clientpositive/lateral_view_noalias.q.out 6e6e496 
>   ql/src/test/results/clientpositive/ppd_union_view.q.out 3c86758 
>   ql/src/test/results/clientpositive/ptf.q.out d86b705 
>   ql/src/test/results/clientpositive/quotedid_basic.q.out d33637a 
>   ql/src/test/results/clientpositive/show_create_table_view.q.out 9f5309e 
>   ql/src/test/results/clientpositive/subquery_exists.q.out f55afd8 
>   ql/src/test/results/clientpositive/subquery_exists_having.q.out 7266a6b 
>   ql/src/test/results/clientpositive/subquery_notin.q.out 15d9244 
>   ql/src/test/results/clientpositive/subquery_views.q.out 37d29a7 
>   ql/src/test/results/clientpositive/union_top_level.q.out 1cc2979 
>   ql/src/test/results/clientpositive/unset_table_view_property.q.out 2aa1dae 
>   ql/src/test/results/clientpositive/view.q.out 288ae47 
>   ql/src/test/results/clientpositive/view_cast.q.out ed1e410 
>   ql/src/test/results/clientpositive/view_inputs.q.out 5ea7589 
>   ql/src/test/results/clientpositive/windowing.q.out bbd169f 
> 
> Diff: https://reviews.apache.org/r/17004/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Navis Ryu
> 
>