You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Virajith Jalaparti (JIRA)" <ji...@apache.org> on 2018/07/04 00:28:00 UTC
[jira] [Commented] (HDFS-13310) [PROVIDED Phase 2] The
DatanodeProtocol should be have DNA_BACKUP to backup blocks
[ https://issues.apache.org/jira/browse/HDFS-13310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532088#comment-16532088 ]
Virajith Jalaparti commented on HDFS-13310:
-------------------------------------------
Thanks for posting this [~ehiggs]. I made the following modifications in the patch and posted [^HDFS-13310-HDFS-12090.003.patch].
- Formatted newly added code to fit into the 80 characters.
- reverted unnecessary changes to Datanode.java
- Added javadoc for BulkSyncTaskExecutionFeedback in DatanodeProtocol#sendHeartbeat
- I didn't see a reason to use {{Pair}} in the constructor of SyncTaskExecutionResult. I removed this.
A couple of comments:
- Can we add javadoc to all the new messages introduced in {{DatanodeProtocol.proto}}, and all newly added classes (*SyncTask*).
- Any particular reason for static imports in PBHelper.java? If not, I would prefer not declaring these as static imports.
> [PROVIDED Phase 2] The DatanodeProtocol should be have DNA_BACKUP to backup blocks
> ----------------------------------------------------------------------------------
>
> Key: HDFS-13310
> URL: https://issues.apache.org/jira/browse/HDFS-13310
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ewan Higgs
> Assignee: Ewan Higgs
> Priority: Major
> Attachments: HDFS-13310-HDFS-12090.001.patch, HDFS-13310-HDFS-12090.002.patch, HDFS-13310-HDFS-12090.003.patch
>
>
> As part of HDFS-12090, Datanodes should be able to receive DatanodeCommands in the heartbeat response that instructs it to backup a block.
> This should take the form of two sub commands: PUT_FILE (when the file is <=1 block in size) and MULTIPART_PUT_PART when part of a Multipart Upload (see HDFS-13186).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org