You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cwegener (via GitHub)" <gi...@apache.org> on 2023/05/04 04:45:05 UTC
[GitHub] [superset] cwegener opened a new pull request, #23927: chore: relax Flask version constraint
cwegener opened a new pull request, #23927:
URL: https://github.com/apache/superset/pull/23927
Flask 2.1 no longer seems to be receiving updates.
In order to keep receveiving critical Flask updates, the upper version
constraint for Flask should be raised to a compatible newer version.
I picked Flask 2.2 as the compatible version.
This only required addressing one single old Flask 2.0 deprecation
warning which is now a removed function in Flask 2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23927: chore: relax Flask version constraint
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23927:
URL: https://github.com/apache/superset/pull/23927#issuecomment-1548174316
Closing in favor of https://github.com/apache/superset/pull/23965, but happy to discuss further if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cwegener commented on pull request #23927: chore: relax Flask version constraint
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on PR #23927:
URL: https://github.com/apache/superset/pull/23927#issuecomment-1534594932
I missed a few `send_file` invocations which I've fixed.
Some DB engine integration tests are still failing. Not sure yet why. I'll need to look into it.
Mypy configuration looks broken to me though. I'm not sure if Mypy will even work the way we need it to work inside of pre-commit. Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI).
Currently, the mypy pre-commit hook is set up to install ALL available typeshed stubs, which includes the Flask 1.x stubs, which are the wrong stubs for us ....
I'm trying to figure out if I can just explicitly define all the types-* packages in pre-commit that we need for Superset ... stay tuned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #23927: chore: relax Flask version constraint
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23927: chore: relax Flask version constraint
URL: https://github.com/apache/superset/pull/23927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23927: chore: relax Flask version constraint
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23927:
URL: https://github.com/apache/superset/pull/23927#issuecomment-1534107453
Thanks for this PR! Try to fix the CI tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23927: chore: relax Flask version constraint
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23927:
URL: https://github.com/apache/superset/pull/23927#issuecomment-1538372660
superseded by #23965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org