You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/24 13:47:20 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1009: Add support for preemptive scheduling in the simulator build

patacongo commented on pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#issuecomment-663547025


   > LE: I fixed the issue with the crash & managed to run `sim:ostest` on both OSX & Linux.
   > For the test I enabled : `SIM_PREEMPTIBLE`, `RR_INTERVAL=1` and set `SIM_WALLTIME=n`
   
   Is it then ready to merge?  I would say that we set a low bar for inclusion in the repository:  The changes should not break any of the existing configurations with SIM_PREEMPTIBLE disabled.  Large new features can have bugs that take weeks to resolve and that is fine (as long as we get most of them before the 9.3 release).  So I think that if we maintain backward compatible and test a few key configurations wtih SIM_PREEMPTIBLE, we should be good to merge.
   
   Have you tried testing the simulated SMP enabled?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org