You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/15 16:26:18 UTC

[GitHub] [beam] robertwb commented on a diff in pull request #23242: Fix type inference for set/delete attr.

robertwb commented on code in PR #23242:
URL: https://github.com/apache/beam/pull/23242#discussion_r972200859


##########
sdks/python/apache_beam/typehints/opcodes.py:
##########
@@ -241,8 +241,8 @@ def dup_topx(state, arg):
   state.stack += state[-arg:]
 
 
-store_attr = pop_top
-delete_attr = nop

Review Comment:
   Generally the stack would get messed up and type inference would bail out (returning Any). I was investigating why type inference wasn't working as expected for a cross language transform. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org