You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/13 01:06:18 UTC
[jira] [Commented] (HTTPCLIENT-1718) OSGiCredentialsProvider.java
compares the Authscope by .equals() instead of .match()
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145595#comment-15145595 ]
ASF GitHub Bot commented on HTTPCLIENT-1718:
--------------------------------------------
GitHub user enenum opened a pull request:
https://github.com/apache/httpclient/pull/46
HTTPCLIENT-1718 and HTTPCLIENT-1719 changes to allow proxy authentication
Some changes to OSGiCredentialsProvider to allow user and pass to be read from configuration, also change to allow user value in config to be accessible to the class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enenum/httpclient trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpclient/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit c6857dbaef14fa52514ea0ba089e079c44d81c82
Author: 212427891 <mu...@ge.com>
Date: 2015-12-31T00:13:15Z
HTTPCLIENT-1710 - fixes - examine all exceptions, correct capture groups count
commit 85c5bcc4f66cf286e27312d3e67646badc6343f9
Author: 212427891 <mu...@ge.com>
Date: 2015-12-31T01:19:59Z
HTTPCLIENT-1710 - adding tests for OSGiHttpRoutePlanner
commit 8ac1fe56c4f0e7ff0c5de30e6a2ead55c09ebf45
Author: 212427891 <mu...@ge.com>
Date: 2016-02-12T23:17:51Z
HTTPCLIENT-1718, HTTPCLEINT-1719 credentials fix to allow proxy authetication
commit 967056f4efd68fdd45fa2773f81e2b0bbeddef94
Author: 212427891 <mu...@ge.com>
Date: 2016-02-13T00:00:11Z
Merge remote-tracking branch 'upstream/trunk' into trunk
----
> OSGiCredentialsProvider.java compares the Authscope by .equals() instead of .match()
> --------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1718
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1718
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.4.1, 5.0 Alpha1
> Reporter: munene kiruja
> Fix For: 4.5.2
>
>
> As a result, nothing can pass the comparison. The match function provide a wighted matching based on which fields are matching and is perhaps the best to use to obtain the credentials of the specified proxy from the configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org