You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/12/15 10:17:47 UTC

[GitHub] [pulsar] yjshen opened a new pull request #5862: [pulsar-flink]Remove improper authentication setting

yjshen opened a new pull request #5862: [pulsar-flink]Remove improper authentication setting
URL: https://github.com/apache/pulsar/pull/5862
 
 
   ### Motivation
   
   When Pulsar Client is used in Flink source/sinks, the Source/Sink functions such as `FlinkPulsarProducer`, `PulsarOutputFormat` would be constructed in user code at the driver side, and then serialized and deserialized to be used in Flink source/sink tasks. 
   
   Therefore, when setting `Authentication` field of `ClientConfigurationData`, which is a transient field, the tasks that do the actual read/write cannot get the authentication object when it is constructed in the user code. 
   
   In order to do the authentication in read/write tasks, the only way is to use `ClientConfigurationData`'s `authPluginClassName` and `authParams` fields. They will be used to construct `Authentication` object at the time to create PulsarClient object, this happens inside flink tasks.
   
   ### Modifications
   
   Remove improper authentication object setting/generation in user code. Leave `authPluginClassName` and `authPluginClassName` as they are until get used in actual PulsarClient construction.
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - The public API: (yes)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services