You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/04/06 07:10:38 UTC

[kudu-CR] ranger: remove experimental flags

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15658


Change subject: ranger: remove experimental flags
......................................................................

ranger: remove experimental flags

This patch removes the experimental flags in Ranger, given I did
integration tests on a real cluster.

Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 0 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/15658/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] ranger: remove experimental flags

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15658 )

Change subject: ranger: remove experimental flags
......................................................................

ranger: remove experimental flags

This patch removes the experimental flags in Ranger, given I did
integration tests on a real cluster.

Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Reviewed-on: http://gerrit.cloudera.org:8080/15658
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/ranger/ranger_client.cc
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] ranger: remove experimental flags

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15658 )

Change subject: ranger: remove experimental flags
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 07:50:02 +0000
Gerrit-HasComments: No

[kudu-CR] ranger: remove experimental flags

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15658 )

Change subject: ranger: remove experimental flags
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1: Code-Review+2
> 
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/15658/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15658/1//COMMIT_MSG@10
PS1, Line 10: integration tests on a real cluster
> So, the main driver of this change is to avoid using --unlock_experimental_
Yes, that's right.



-- 
To view, visit http://gerrit.cloudera.org:8080/15658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 17:30:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] ranger: remove experimental flags

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15658 )

Change subject: ranger: remove experimental flags
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15658/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15658/1//COMMIT_MSG@10
PS1, Line 10: integration tests on a real cluster
So, the main driver of this change is to avoid using --unlock_experimental_flags when running the Ranger client?

And we don't expect these flags to be changed or removed in future, right?



-- 
To view, visit http://gerrit.cloudera.org:8080/15658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87e36f973730f54e6e3984e34a8216eeeacc1088
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 16:00:03 +0000
Gerrit-HasComments: Yes