You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/24 17:27:40 UTC

[GitHub] [avro] RyanSkraba commented on a change in pull request #1557: AVRO-3411: Support VSCode devcontainer

RyanSkraba commented on a change in pull request #1557:
URL: https://github.com/apache/avro/pull/1557#discussion_r814106447



##########
File path: .gitattributes
##########
@@ -0,0 +1,62 @@
+# Set default behavior to automatically normalize line endings.

Review comment:
       There was a discussion on this about AVRO-3150 -- some tests were failing due to an overzealous checkstyle check IIRC.
   
   Is there something that fails if this `.gitattributes` isn't present?   I'm not familiar with all the attributes, I admit!  What does `diff` and `astextplain` do? 
   
   I have no objection to enforcing that script files are CRLF/LF no matter where they're checked out!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org