You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by sh...@inmobi.com on 2014/12/05 05:55:31 UTC
Review Request 28740: FALCON-419 Update deprecated HCatalog API to
use Hive Metastore API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-419
https://issues.apache.org/jira/browse/FALCON-419
Repository: falcon-git
Description
-------
changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
Diffs
-----
common/pom.xml 50dd2ea
common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
pom.xml 7a8aacc
prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
Diff: https://reviews.apache.org/r/28740/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by Suhas Vasu <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64523
-----------------------------------------------------------
Ship it!
Ship It!
- Suhas Vasu
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by sh...@inmobi.com.
> On Dec. 9, 2014, 4:11 p.m., Suhas Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> > Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
I wasn't able to get create table working with hive metastore client. So, left the tests as is
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by sh...@inmobi.com.
> On Dec. 9, 2014, 4:11 p.m., Suhas Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> > Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
>
> shwethags wrote:
> I wasn't able to get create table working with hive metastore client. So, left the tests as is
>
> Suhas Vasu wrote:
> if there are differences between the HiveMetastoreClient and Hcat api in the later versions, we might not catch them effectively. Apart from that its a +1 from me
HCatClient is just a wrapper around HiveMetastoreClient and hive metastore is the source of truth. So, it should be ok
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by Suhas Vasu <su...@gmail.com>.
> On Dec. 9, 2014, 4:11 p.m., Suhas Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> > Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
>
> shwethags wrote:
> I wasn't able to get create table working with hive metastore client. So, left the tests as is
if there are differences between the HiveMetastoreClient and Hcat api in the later versions, we might not catch them effectively. Apart from that its a +1 from me
- Suhas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by Suhas Vasu <su...@gmail.com>.
> On Dec. 9, 2014, 4:11 p.m., Suhas Vasu wrote:
> > webapp/src/test/java/org/apache/falcon/resource/TestContext.java, line 140
> > <https://reviews.apache.org/r/28740/diff/2/?file=786711#file786711line140>
> >
> > Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
>
> shwethags wrote:
> I wasn't able to get create table working with hive metastore client. So, left the tests as is
>
> Suhas Vasu wrote:
> if there are differences between the HiveMetastoreClient and Hcat api in the later versions, we might not catch them effectively. Apart from that its a +1 from me
>
> shwethags wrote:
> HCatClient is just a wrapper around HiveMetastoreClient and hive metastore is the source of truth. So, it should be ok
If thats the case, it should be fine
- Suhas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by Suhas Vasu <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64381
-----------------------------------------------------------
webapp/src/test/java/org/apache/falcon/resource/TestContext.java
<https://reviews.apache.org/r/28740/#comment107065>
Should we be using HiveMetastoreClient for tests as well to maintain consistency ?
- Suhas Vasu
On Dec. 9, 2014, 11:53 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 11:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/
-----------------------------------------------------------
(Updated Dec. 9, 2014, 11:53 a.m.)
Review request for Falcon.
Changes
-------
incorporated review comments.
The reason why code is removed from CatalogStorage.dropPartitions(): It was optimising calls to hcat by aggregating partitions so that fewer calls are made to hcat. But HCatClient.dropPartitions() calls listPartitions and then drops each partition at a time. So, this optimisation is not required
Bugs: FALCON-419
https://issues.apache.org/jira/browse/FALCON-419
Repository: falcon-git
Description
-------
changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
Diffs (updated)
-----
common/pom.xml 50dd2ea
common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
pom.xml 7a8aacc
prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
Diff: https://reviews.apache.org/r/28740/diff/
Testing
-------
UTs
Thanks,
shwethags
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by sh...@inmobi.com.
> On Dec. 9, 2014, 10:17 a.m., Suhas Vasu wrote:
> > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java, line 38
> > <https://reviews.apache.org/r/28740/diff/1/?file=783497#file783497line38>
> >
> > unnecessary import ?
Its used to create delegation token. HCatClient APIs are simpler that way:)
> On Dec. 9, 2014, 10:17 a.m., Suhas Vasu wrote:
> > pom.xml, line 110
> > <https://reviews.apache.org/r/28740/diff/1/?file=783499#file783499line110>
> >
> > As far as i am aware, lot of issues are fixed in hive 0.13.0 & 0.13.1. Since we are changing the API's should we also consider upgrading the hive version as well ?
That has dependency on upgrading oozie. There is already a jira tracking that
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64354
-----------------------------------------------------------
On Dec. 5, 2014, 4:55 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 4:55 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>
Re: Review Request 28740: FALCON-419 Update deprecated HCatalog API
to use Hive Metastore API
Posted by Suhas Vasu <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28740/#review64354
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java
<https://reviews.apache.org/r/28740/#comment107005>
unnecessary import ?
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java
<https://reviews.apache.org/r/28740/#comment107006>
error message should be "creating hivemetastore client" ?
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java
<https://reviews.apache.org/r/28740/#comment107007>
same here.
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java
<https://reviews.apache.org/r/28740/#comment107009>
We should also log the deletion of each partition. If theres some issue while deleting one of the partitions, it may not be clear what is deleted and what is not.
pom.xml
<https://reviews.apache.org/r/28740/#comment107004>
As far as i am aware, lot of issues are fixed in hive 0.13.0 & 0.13.1. Since we are changing the API's should we also consider upgrading the hive version as well ?
- Suhas Vasu
On Dec. 5, 2014, 4:55 a.m., shwethags wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28740/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 4:55 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-419
> https://issues.apache.org/jira/browse/FALCON-419
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> changed HiveCatalogService to use HiveMetastoreClient instead of HCatClient.
>
>
> Diffs
> -----
>
> common/pom.xml 50dd2ea
> common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java 348fac0
> common/src/main/java/org/apache/falcon/catalog/CatalogPartition.java c5d4705
> common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java 3216f1e
> common/src/main/java/org/apache/falcon/entity/CatalogStorage.java e68044a
> pom.xml 7a8aacc
> prism/src/test/java/org/apache/falcon/security/FalconAuthenticationFilterTest.java 4ceca29
> rerun/src/main/java/org/apache/falcon/latedata/LateDataHandler.java d5b7db0
> webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java fcf7f96
> webapp/src/test/java/org/apache/falcon/late/LateDataHandlerIT.java c4e046b
> webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java d508a2d
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 64f98d4
> webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 3b71f08
>
> Diff: https://reviews.apache.org/r/28740/diff/
>
>
> Testing
> -------
>
> UTs
>
>
> Thanks,
>
> shwethags
>
>