You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nicholas Telford (JIRA)" <ji...@apache.org> on 2011/03/02 11:57:36 UTC
[jira] Created: (THRIFT-1078) ThriftTest.thrift generates invalid
PHP library
ThriftTest.thrift generates invalid PHP library
-----------------------------------------------
Key: THRIFT-1078
URL: https://issues.apache.org/jira/browse/THRIFT-1078
Project: Thrift
Issue Type: Bug
Components: Test Suite
Reporter: Nicholas Telford
Assignee: Nicholas Telford
Priority: Minor
The ThriftTest.thrift test suite generates a PHP client library that uses the default namespace "thrift.test" as the class prefix. Since "." is an invalid character in PHP class names this is a bug.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (THRIFT-1078) ThriftTest.thrift generates invalid
PHP library
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1078.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
I just committed this.
> ThriftTest.thrift generates invalid PHP library
> -----------------------------------------------
>
> Key: THRIFT-1078
> URL: https://issues.apache.org/jira/browse/THRIFT-1078
> Project: Thrift
> Issue Type: Bug
> Components: Test Suite
> Reporter: Nicholas Telford
> Assignee: Nicholas Telford
> Priority: Minor
> Fix For: 0.7
>
> Attachments: thrift-testsuite-1078.patch
>
>
> The ThriftTest.thrift test suite generates a PHP client library that uses the default namespace "thrift.test" as the class prefix. Since "." is an invalid character in PHP class names this is a bug.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1078) ThriftTest.thrift generates invalid
PHP library
Posted by "Nicholas Telford (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicholas Telford updated THRIFT-1078:
-------------------------------------
Attachment: thrift-testsuite-1078.patch
Patch to fix generation of PHP test suite and associated TestClient.php
> ThriftTest.thrift generates invalid PHP library
> -----------------------------------------------
>
> Key: THRIFT-1078
> URL: https://issues.apache.org/jira/browse/THRIFT-1078
> Project: Thrift
> Issue Type: Bug
> Components: Test Suite
> Reporter: Nicholas Telford
> Assignee: Nicholas Telford
> Priority: Minor
> Attachments: thrift-testsuite-1078.patch
>
>
> The ThriftTest.thrift test suite generates a PHP client library that uses the default namespace "thrift.test" as the class prefix. Since "." is an invalid character in PHP class names this is a bug.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira