You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sentry.apache.org by "Ryan P (JIRA)" <ji...@apache.org> on 2015/10/29 19:52:27 UTC

[jira] [Commented] (SENTRY-940) Drop table should revert the user:group rules of the directory and underlying files to original hdfs rules

    [ https://issues.apache.org/jira/browse/SENTRY-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981032#comment-14981032 ] 

Ryan P commented on SENTRY-940:
-------------------------------

Is there a particular reason we bother to implement getUser() as opposed to relying on DefaultAuthorizationProvider's implementation? It's hardly a security hole if the creator or the directory/file has access to it's own files. Instead we should limit the plugin's scope to ACL features instead of manipulating ownership bits.

I suggest we passthrough all requests to getUser() to the DefaultAuthorizationProvider rather than having a plugin specific implementation. In the event HDFS falls out of sync with Sentry we can just remove the ACLs, leaving ownership in tact. Let me know your thoughts, I would be more than happy to write/test this patch. 


> Drop table should revert the user:group rules of the directory and underlying files to original hdfs rules
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-940
>                 URL: https://issues.apache.org/jira/browse/SENTRY-940
>             Project: Sentry
>          Issue Type: Bug
>          Components: Hdfs Plugin
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Sravya Tirukkovalur
>             Fix For: 1.7.0
>
>
> Note that, the directory is created first before creating a table, so the original user can be different from hive:hive



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)