You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/02/06 22:04:27 UTC
Review Request 69913: Added more operation reconciliation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Joseph Wu.
Bugs: MESOS-9473
https://issues.apache.org/jira/browse/MESOS-9473
Repository: mesos
Description
-------
Added more operation reconciliation tests.
Diffs
-----
src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
Diff: https://reviews.apache.org/r/69913/diff/1/
Testing
-------
`GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
Thanks,
Gastón Kleiman
Re: Review Request 69913: Added more operation reconciliation tests.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 12:33 a.m.)
Review request for mesos, Greg Mann and Joseph Wu.
Bugs: MESOS-9473
https://issues.apache.org/jira/browse/MESOS-9473
Repository: mesos
Description
-------
Added more operation reconciliation tests.
Diffs
-----
src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
Diff: https://reviews.apache.org/r/69913/diff/1/
Testing
-------
`GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
Thanks,
Gastón Kleiman
Re: Review Request 69913: Added more operation reconciliation tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/#review212620
-----------------------------------------------------------
PASS: Mesos patch 69913 was successfully built and tested.
Reviews applied: `['69910', '69911', '69912', '69913']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2861/mesos-review-69913
- Mesos Reviewbot Windows
On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69913/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 2:04 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added more operation reconciliation tests.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
>
>
> Diff: https://reviews.apache.org/r/69913/diff/1/
>
>
> Testing
> -------
>
> `GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69913: Added more operation reconciliation tests.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
> On Feb. 7, 2019, 10:32 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1244 (patched)
> > <https://reviews.apache.org/r/69913/diff/1/?file=2124157#file2124157line1244>
> >
> > I think the detector isn't necessary in this test?
`StartSlave()` needs the detector to find the master.
Note that this is not a `StandAloneDetector`.
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/#review212635
-----------------------------------------------------------
On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69913/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 2:04 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added more operation reconciliation tests.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
>
>
> Diff: https://reviews.apache.org/r/69913/diff/1/
>
>
> Testing
> -------
>
> `GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69913: Added more operation reconciliation tests.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
> On Feb. 7, 2019, 10:32 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 943-945 (original), 943-947 (patched)
> > <https://reviews.apache.org/r/69913/diff/1/?file=2124157#file2124157line943>
> >
> > Ah, looks like this part of the diff belongs in a previous patch.
Squashed both patches together, see: https://reviews.apache.org/r/69911/
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/#review212635
-----------------------------------------------------------
On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69913/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 2:04 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added more operation reconciliation tests.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
>
>
> Diff: https://reviews.apache.org/r/69913/diff/1/
>
>
> Testing
> -------
>
> `GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69913: Added more operation reconciliation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/#review212635
-----------------------------------------------------------
Fix it, then Ship it!
Nit: the commit message says that "tests" are added, but there is only one test in this patch.
src/tests/operation_reconciliation_tests.cpp
Lines 943-945 (original), 943-947 (patched)
<https://reviews.apache.org/r/69913/#comment298462>
Ah, looks like this part of the diff belongs in a previous patch.
src/tests/operation_reconciliation_tests.cpp
Lines 1244 (patched)
<https://reviews.apache.org/r/69913/#comment298463>
I think the detector isn't necessary in this test?
src/tests/operation_reconciliation_tests.cpp
Lines 1320-1321 (patched)
<https://reviews.apache.org/r/69913/#comment298464>
Should we also expect that RP ID is unset?
src/tests/operation_reconciliation_tests.cpp
Lines 1352-1353 (patched)
<https://reviews.apache.org/r/69913/#comment298465>
Ditto regarding RP ID.
src/tests/operation_reconciliation_tests.cpp
Lines 1355 (patched)
<https://reviews.apache.org/r/69913/#comment298466>
Nit: period at the end of comment. Here and below.
src/tests/operation_reconciliation_tests.cpp
Lines 1383 (patched)
<https://reviews.apache.org/r/69913/#comment298467>
Could you explain in this comment why the response contains no operation statuses?
- Greg Mann
On Feb. 6, 2019, 10:04 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69913/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 10:04 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added more operation reconciliation tests.
>
>
> Diffs
> -----
>
> src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3
>
>
> Diff: https://reviews.apache.org/r/69913/diff/1/
>
>
> Testing
> -------
>
> `GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"` passed
>
>
> Thanks,
>
> Gastón Kleiman
>
>