[GitHub] [submarine] hhhizzz commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.

[GitBox <gi...@apache.org>]

hhhizzz commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r352570571
 
 

 ##########
 File path: bin/submarine-daemon.sh
 ##########
 @@ -36,9 +36,9 @@ cd ${BIN}/>/dev/null
 SUBMARINE_SERVER_NAME="Submarine Server"
 SUBMARINE_SERVER_LOGFILE="${SUBMARINE_LOG_DIR}/submarine.log"
 SUBMARINE_SERVER_MAIN=org.apache.submarine.server.SubmarineServer
-JAVA_OPTS+=" -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
+JAVA_OPTS+="${SUBMARINE_SERVER_JAVA_OPTS} ${SUBMARINE_SERVER_MEM} -Dsubmarine.log.file=${SUBMARINE_SERVER_LOGFILE}"
 
-add_jar_in_dir "${BIN}/../lib"
+add_each_jar_in_dir_recursive "${BIN}/../lib"
 
 Review comment:
   maybe create a variable SUBMARINE_HOME=${BIN}/.. and then add_each_jar_in_dir_recursive "${SUBMARINE_HOME}/lib"  is better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org