You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by dsclose <gi...@git.apache.org> on 2016/05/27 17:15:28 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is r...
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1568
CLOUDSTACK-9385 - Ensure passwd srvr is restarts after keepalived transitions
Based on @ustcweizhou code suggestion. Tried on redundant and standalone virtual routers and works fine.
Needs to be checked on VPC routers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-9385
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1568.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1568
----
commit c535e22e8cf310ca288a1b6566318b85bd98c347
Author: dean.close <de...@icloudhosting.com>
Date: 2016-05-27T17:09:31Z
CLOUDSTACK-9385 - Ensure that the password server is restarted after keepalived transitions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1568: CLOUDSTACK-9385 - Ensure passwd srvr is resta...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1568: CLOUDSTACK-9385 - Ensure passwd srvr is restarts aft...
Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:
https://github.com/apache/cloudstack/pull/1568
### ACS CI BVT Run
**Sumarry:**
Build Number 200
Hypervisor xenserver
NetworkType Advanced
Passed=20
Failed=21
Skipped=3
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_deploy_vm_with_userdata.py
* test_deployvm_userdata Failed
* test_deployvm_userdata_post Failed
* test_affinity_groups_projects.py
* test_DeployVmAntiAffinityGroup_in_project Failed
* test_vpc_vpn.py
* test_01_redundant_vpc_site2site_vpn Failed
* test_01_vpc_remote_access_vpn Failed
* test_01_vpc_site2site_vpn Failed
* test_scale_vm.py
* ContextSuite context=TestScaleVm>:setup Failing since 3 runs
* test_service_offerings.py
* ContextSuite context=TestServiceOfferings>:setup Failing since 10 runs
* test_routers_iptables_default_policy.py
* test_02_routervm_iptables_policies Failed
* test_01_single_VPC_iptables_policies Failed
* test_routers.py
* ContextSuite context=TestRouterServices>:setup Failed
* test_reset_vm_on_reboot.py
* ContextSuite context=TestResetVmOnReboot>:setup Failing since 3 runs
* test_snapshots.py
* ContextSuite context=TestSnapshotRootDisk>:setup Failing since 2 runs
* test_list_ids_parameter.py
* ContextSuite context=TestListIdsParams>:setup Failing since 3 runs
* test_multipleips_per_nic.py
* test_nic_secondaryip_add_remove Failed
* test_affinity_groups.py
* test_DeployVmAntiAffinityGroup Failed
* test_network_acl.py
* test_network_acl Failed
* test_volumes.py
* ContextSuite context=TestCreateVolume>:setup Failed
* ContextSuite context=TestVolumes>:setup Failed
* test_nic.py
* test_01_nic Failed
* test_vm_life_cycle.py
* ContextSuite context=TestVMLifeCycle>:setup Failing since 3 runs
**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_login.py
test_public_ip_range.py
test_regions.py
test_pvlan.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is r...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1568#issuecomment-222315777
Hi @dsclose The passwd server should not run on the backup router, the same counts for dnsmasq. Cloud-init will get the passwd from the server it got the ip address from (on the direct ip, not the vip) so it is not needed.
It's a nice idea to have "redundancy" here but it will lead to unexpected problems. Imagine a VM starting and getting the passwd from the master, which marks it as sent. Then the VM restarts and a failover had taken place. Now it gets the same password from the new master (old backup, which has not been marked as retrieved). If a user had changed the password manually, it is now being reset to the previous one. We had this going in in production for a while and it confuses users a lot. Keep it simple, run on the master only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1568: CLOUDSTACK-9385 - Ensure passwd srvr is restarts aft...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the issue:
https://github.com/apache/cloudstack/pull/1568
Unfortunately I won't be available to do further work on this PR. I'll leave the commits available incase they are useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is r...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1568#issuecomment-222308460
**NB**: This PR should be considered controversial because it restarts the password server after each keepalived transition, rather than stopping the service on transitions to backup or fault states.
This decision was taken in anticipation of CLOUDSTACK-9035, which suggests that the password server should be running on backup redundant routers. However, this may be ill-advised.
I'm happy to incorporate any feedback into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1568: CLOUDSTACK-9385 - Ensure passwd srvr is resta...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1568#discussion_r66037301
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -346,6 +341,25 @@ def set_master(self):
CsHelper.reconfigure_interfaces(self.cl, interfaces)
logging.info("Router switched to master mode")
+
+ def _restart_password_server(self):
+ '''
+ CLOUDSTACK-9385
+ Redundant virtual routers should have the password server running.
+ '''
+ if self.config.is_vpc():
+ vrrp_addresses = [address for address in self.address.get_ips() if address.needs_vrrp()]
--- End diff --
@dsclose get_ips has been changed to get_interfaces, by Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is r...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1568#issuecomment-222421440
@remibergsma is correct, password server should not be running on router on BACKUP/FAULT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1568: CLOUDSTACK-9385 - Ensure passwd srvr is resta...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1568#discussion_r66031974
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -346,6 +341,25 @@ def set_master(self):
CsHelper.reconfigure_interfaces(self.cl, interfaces)
logging.info("Router switched to master mode")
+
+ def _restart_password_server(self):
+ '''
+ CLOUDSTACK-9385
+ Redundant virtual routers should have the password server running.
+ '''
+ if self.config.is_vpc():
+ vrrp_addresses = [address for address in self.address.get_ips() if address.needs_vrrp()]
+
+ for address in vrrp_addresses:
+ CsPasswdSvc(address.get_gateway()).restart()
+ CsPasswdSvc(address.get_ip()).restart()
+ else:
+ guest_addresses = [address for address in self.address.get_ips() if address.is_guest()]
+
+ for address in guest_addresses:
+ CsPasswdSvc(address.get_ip()).restart()
--- End diff --
@dsclose indent should be added here. otherwise, the VR will fail to start.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9385 - Ensure passwd srvr is restarts af...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1568
@remibergsma @ustcweizhou Well that clears that up! I'll see about adjusting the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---