You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Caleb William Rackliffe (JIRA)" <ji...@apache.org> on 2015/12/04 00:17:11 UTC

[jira] [Commented] (CASSANDRA-7466) Unit Test Suite Breaks when Run in a Single JVM

    [ https://issues.apache.org/jira/browse/CASSANDRA-7466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038807#comment-15038807 ] 

Caleb William Rackliffe commented on CASSANDRA-7466:
----------------------------------------------------

Given the way I'm seeing {{cassandra-2.1}} behave, I think this ticket is invalid. I can still only run groups of tests from IDEA in a run configuration with class-level forking, but the failures appear to be different than I had originally reported here. In any case, I don't have time to track them down at the moment.

The new failures are a hodgepodge of things like:

{noformat}
FSWriteError in build/test/cassandra/data/cql_test_keyspace/table_1-0fd6a7109a1311e586ed079249e818e0/backups/cql_test_keyspace-table_1.some_index-ka-5-Summary.db
	at org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:135)
	at org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:381)
	at org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:377)
	at org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:377)
	at org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:377)
	at org.apache.cassandra.io.util.FileUtils.deleteRecursive(FileUtils.java:377)
	at org.apache.cassandra.SchemaLoader.cleanup(SchemaLoader.java:454)
	at org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:429)
	at org.apache.cassandra.SchemaLoader.prepareServer(SchemaLoader.java:85)
	at org.apache.cassandra.SchemaLoader.loadSchema(SchemaLoader.java:61)
	at org.apache.cassandra.SchemaLoader.loadSchema(SchemaLoader.java:56)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:117)
	at org.junit.runners.Suite.runChild(Suite.java:24)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:159)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
Caused by: java.nio.file.NoSuchFileException: build/test/cassandra/data/cql_test_keyspace/table_1-0fd6a7109a1311e586ed079249e818e0/backups/cql_test_keyspace-table_1.some_index-ka-5-Summary.db
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:244)
	at sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
	at java.nio.file.Files.delete(Files.java:1079)
	at org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:131)
{noformat}
...and...
{noformat}
org.apache.cassandra.exceptions.AlreadyExistsException: Cannot add existing keyspace "Keyspace1"
	at org.apache.cassandra.service.MigrationManager.announceNewKeyspace(MigrationManager.java:228)
	at org.apache.cassandra.service.MigrationManager.announceNewKeyspace(MigrationManager.java:220)
	at org.apache.cassandra.service.MigrationManager.announceNewKeyspace(MigrationManager.java:215)
	at org.apache.cassandra.SchemaLoader.loadSchema(SchemaLoader.java:70)
	at org.apache.cassandra.SchemaLoader.loadSchema(SchemaLoader.java:56)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:117)
	at org.junit.runners.Suite.runChild(Suite.java:24)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:180)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:41)
	at org.junit.runners.ParentRunner$1.evaluate(ParentRunner.java:173)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:220)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:159)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
{noformat}

> Unit Test Suite Breaks when Run in a Single JVM
> -----------------------------------------------
>
>                 Key: CASSANDRA-7466
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7466
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>         Environment: MacOS 10.9.3, IntelliJ IDEA 13.1.3, Java 1.7.0_51
>            Reporter: Caleb William Rackliffe
>            Assignee: Caleb William Rackliffe
>            Priority: Minor
>              Labels: unit-test
>
> Note: Instead of picking a version below, I'll simply note that I'm on {{trunk}} at commit {{c027183ea4e901cf1d44e06704f6d78f84405bb4}}
> I pulled down the source and followed http://wiki.apache.org/cassandra/RunningCassandraInIDEA to import C* as an IDEA project. Everything in the tutorial works as it should, but when I tried to run the unit tests in {{test/unit/org.apache.cassandra}}, the suite failed a couple tests in, complaining that it couldn't find the {{system}} keyspace in {{build/test/cassandra/data}}.
> tl;dr static initialization makes it hard to run the unit tests in the same JVM
> The full story is that...
> 1.) When the first test in the suite is run, the {{system}} keyspace is created on disk and in the in-memory schema.
> 2.) Many subsequent tests, like {{BlacklistingCompactionsTest}}, remove the {{system}} keyspace directory (among other things) in {{defineSchema()}} with a call to {{SchemaLoader.prepareServer()}}.
> 3.) While these tests create the keyspaces they require, they do *not* recreate the system keyspace, and so they fail when they force a compaction or perform any other action that goes looking for it.
> You can run the suite with IDEA's class/method forking, and you get a little bit better results, but it still seems like this shouldn't be necessary.
> I guess there are two ways to fix it:
> 1.) We rebuild the system keyspace before for each test.
> 2.) We leave the system keyspace alone.
> I took a hack at #1 in the attached patch. It looks like it to fixes this specific problem, but I'm not super-believable in this codebase yet...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)