[GitHub] [spark] LuciferYang commented on a change in pull request #31644: [SPARK-34535][SQL] Cleanup unused symbol in Orc related code

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #31644:
URL: https://github.com/apache/spark/pull/31644#discussion_r582859339



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala
##########
@@ -98,8 +98,7 @@ case class OrcPartitionReaderFactory(
       new EmptyPartitionReader[InternalRow]
     } else {
       val (requestedColIds, canPruneCols) = resultedColPruneInfo.get
-      val resultSchemaString = OrcUtils.orcResultSchemaString(canPruneCols,
-        dataSchema, resultSchema, partitionSchema, conf)
+      OrcUtils.orcResultSchemaString(canPruneCols, dataSchema, resultSchema, partitionSchema, conf)

Review comment:
       https://github.com/apache/spark/blob/4a3200b08ac3e7733b5a3dc7271d35e6872c5967/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L240-L253
   
   @HyukjinKwon The previous failed test cases are mainly due to  `OrcUtils.orcResultSchemaString` will set `resultSchemaString`  to `conf`, so only ignore useless return value `val resultSchemaString` here .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org