You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/11/13 19:39:52 UTC
Review Request 40304: Upgrade to checkstyle 6.12.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Release notes: http://checkstyle.sourceforge.net/releasenotes.html
Context - i'm trying to keep up-to-date with checkstyle, pmd, and findbugs to get past various issues related to use of lambdas and method references without giving up code quality checks. There is a significant update to PMD that is nearly to ready for us - just one false positive issue i bumped into: http://sourceforge.net/p/pmd/bugs/1422/
Diffs
-----
build.gradle ca18d6c3b998321bc64e3806ad885b1ceabc99a8
Diff: https://reviews.apache.org/r/40304/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 40304: Upgrade to checkstyle 6.12.1
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/#review106484
-----------------------------------------------------------
Ship it!
Master (ba9819e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 13, 2015, 6:39 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40304/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 6:39 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes: http://checkstyle.sourceforge.net/releasenotes.html
>
> Context - i'm trying to keep up-to-date with checkstyle, pmd, and findbugs to get past various issues related to use of lambdas and method references without giving up code quality checks. There is a significant update to PMD that is nearly to ready for us - just one false positive issue i bumped into: http://sourceforge.net/p/pmd/bugs/1422/
>
>
> Diffs
> -----
>
> build.gradle ca18d6c3b998321bc64e3806ad885b1ceabc99a8
>
> Diff: https://reviews.apache.org/r/40304/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 40304: Upgrade to checkstyle 6.12.1
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40304/#review106507
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Nov. 13, 2015, 10:39 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40304/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 10:39 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes: http://checkstyle.sourceforge.net/releasenotes.html
>
> Context - i'm trying to keep up-to-date with checkstyle, pmd, and findbugs to get past various issues related to use of lambdas and method references without giving up code quality checks. There is a significant update to PMD that is nearly to ready for us - just one false positive issue i bumped into: http://sourceforge.net/p/pmd/bugs/1422/
>
>
> Diffs
> -----
>
> build.gradle ca18d6c3b998321bc64e3806ad885b1ceabc99a8
>
> Diff: https://reviews.apache.org/r/40304/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>