You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by anuragknoldus <gi...@git.apache.org> on 2016/10/28 05:09:20 UTC
[GitHub] incubator-carbondata pull request #267: implement test cases for core.load m...
GitHub user anuragknoldus opened a pull request:
https://github.com/apache/incubator-carbondata/pull/267
implement test cases for core.load module
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- What manual testing you have done?
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anuragknoldus/incubator-carbondata CARBONDATA-340
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit c3d66fc38d3b04983697ca28fba9d8ccbeeebf6a
Author: Anurag <an...@knoldus.com>
Date: 2016-10-28T05:04:51Z
implement test cases for core.load module
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #267: [CARBONDATA-340] implement test case...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #267: [CARBONDATA-340] implement test case...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/267#discussion_r87442533
--- Diff: core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java ---
@@ -150,7 +150,7 @@ public String getLoadStartTime() {
* return loadStartTime
* @return
*/
- public long getLoadStartTimeAsLong() {
+ public Long getLoadStartTimeAsLong() {
--- End diff --
Why it is required to change to `Long`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---