You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/10 20:22:06 UTC

[GitHub] [arrow] aocsa commented on a change in pull request #11132: ARROW-13974: [C++] Resolve follow-up reviews for TopK/BottomK

aocsa commented on a change in pull request #11132:
URL: https://github.com/apache/arrow/pull/11132#discussion_r706448942



##########
File path: cpp/src/arrow/compute/kernels/select_k_test.cc
##########
@@ -42,7 +42,7 @@ using internal::checked_pointer_cast;
 namespace compute {
 
 template <typename ArrayType, SortOrder order>
-class SelectKComparator {
+class SelectKCompareForResult {
  public:

Review comment:
       SelectKComparatorForResult consider duplicates to check duplicates in the result that's why it uses <=, the other it only uses `<` as a comparator in the Heap.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org