[GitHub] [zookeeper] maoling edited a comment on pull request #1704: Add command to force a zookeeper server to take a snapshot

[GitBox <gi...@apache.org>]

maoling edited a comment on pull request #1704:
URL: https://github.com/apache/zookeeper/pull/1704#issuecomment-887431152


   For this PR:
   - Look at the command naming: `force_snapshot`(semantic ambiguity), it seems like that when using this command, users can force the server to take a snapshot immediately. 
   - However, this PR just sets a flag:`forceSnapshot` and we cannot control the timing of snapshot(we cannot know when the server will take a snapshot). When there're no write requests during that period, the snapshot cannot never be triggered.
   - Another important things is: when the server is taking a snapshot, we should not allow another process to take snapshot which will put too much pressure on the server. This PR also cannot guarantee this?
   - I have some thoughts for this topic: `Backup and recovery`. I will sort it out and share it here at this weekend(08-28)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org