You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by René Peinl <re...@hof-university.de> on 2013/03/06 10:21:13 UTC

Review Request: Alternative database backend based on graph database neo4j

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

Review request for shindig.


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


This addresses bug Shindig-1911.
    https://issues.apache.org/jira/browse/Shindig-1911


Diffs
-----

  /trunk/java/neo4j-backend/pom.xml PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java PRE-CREATION 
  /trunk/pom.xml 1452786 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


Thanks,

René Peinl


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Florian Holzschuher <fl...@iisys.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review17541
-----------------------------------------------------------


Hello,

To activate the neo4j back-end you need to replace the following modules in the default web.xml:
org.apache.shindig.social.core.config.SocialApiGuiceModule: -> de.hofuniversity.iisys.graphbackend.GraphAPIModule:
org.apache.shindig.social.sample.SampleModule: -> de.hofuniversity.iisys.graphbackend.GuiceModule:

Additionally, you can configure the back-end by modifying the included file "graph-backend.properties" and putting it in WEB-INF/classes.
At the moment its primary use is to set a database directory, but it could also be used to connect to a remote neo4j server.
(The implementations for services optimized for remote access are included, but not covered by the tests yet and thus not activated)

You may need to include some library jars manually to make it work:
hamcrest-core
jta
lucene-core
neo4j
neo4j-cypher
neo4j-graph-algo
neo4j-graph-matching
neo4j-jmx
neo4j-kernel
neo4j-lucene-index
neo4j-udc
scala-library

Furthermore, a batch XML parser is included to fill a local database with initial data, but a default data set is not yet included. I'll try to create a file containing similar data to your JSON example if desired.

But since by default our back-end provides an extended API, you could create users and other data using OpenSocial calls.
At the moment these new endpoints are:
-user creation and deletion methods as specified by OpenSocial 2.5
-friendship creation and deletion methods as specified by OpenSocial 2.5
-.../user/ - (user.getAll) - gets all available users
-.../user/<id>/fof/(<depth>(/<unknown>)) - (user.getFof) - gets friends of friends for the given user ID, up to a certain depth (default: 2), that the user is not yet friends with (default for unknown: true)
-.../user/<id>/sfriend/(<minFriends>) - (user.getSFriend) - gets ordered friend suggestions for a user with a minimum of common friends (default: 1), ordered by the number of common friends
-.../user/<id>/sgroup/(<minFriends>) - (user.getSGroup) - gets ordered group suggestions for a user, same principle
-.../user/<id>/spath/<id> - (user.getSPath) - gets the shortest path between two people defined over friendships (ordered list of people in between)

Regards,
Florian

- Florian Holzschuher


On March 7, 2013, 1:17 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 1:17 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> This addresses bug Shindig-1911.
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Diffs
> -----
> 
>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java PRE-CREATION 
>   /trunk/pom.xml 1452786 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32690
-----------------------------------------------------------


Sorry about the multiple comments :(

- Ryan Baxter


On Jan. 21, 2014, 4:23 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32687
-----------------------------------------------------------


Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.

- Ryan Baxter


On Jan. 21, 2014, 4:23 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Feb. 13, 2014, 2:59 p.m., Ryan Baxter wrote:
> > /trunk/java/websocket-backend/pom.xml, line 150
> > <https://reviews.apache.org/r/9773/diff/5/?file=433348#file433348line150>
> >
> >     Shouldn't these just point to the SNAPSHOT and not specifically to update1?

I've uploaded a new diff, which refers to version 2.5.2-SNAPSHOT now.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review34367
-----------------------------------------------------------


On March 17, 2014, 3:13 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 3:13 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1578387 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review34367
-----------------------------------------------------------



/trunk/java/websocket-backend/pom.xml
<https://reviews.apache.org/r/9773/#comment64446>

    Shouldn't these just point to the SNAPSHOT and not specifically to update1?


- Ryan Baxter


On Feb. 4, 2014, 2:35 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 2:35 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On May 26, 2014, 3:29 p.m., Stanton Sievers wrote:
> > I verified that the patch applies cleanly, although IntelliJ had some path issues that needed manual correction.  I built with the websocket-backend profile enabled and verified that a war file was produced, the contents of which looked correct.
> > 
> > Ryan had some questions in an earlier comment about properties file and the sample data that I would like to see addressed.
> > 
> > Other than that, I think this is in a state where we can commit it.  It is sufficiently roped-off via the profile that the risk is low.

Thanks Stanton.
Regarding the issues you mention:

- sample data: as described in the readme on github https://github.com/iisys-hof/neo4j-websocket-server/blob/master/README the servlet container is optional. That means, you can run either the war file in a servlet container like Glassfish 4 or use a normal Java SE JRE. In the latter case, the Tyrus Web socket library (included in the dependencies-jars folder) will be used to establish the connection. 
The sample data provided on dropbox https://dl.dropboxusercontent.com/u/32445341/neo4j.zip should be extracted to a local directory and this directory has to be specified in the neo4j-websocket-server.properties as described in step 3 in the readme.

- properties file: there should not be a neo4j-websocket-server.properites file in the Shindig project and neither was there in all our tests. We cannot reproduce this behavior. Maybe it is due to the platform. We have only tested several Linux versions. Our main development line is Ubuntu 12.04. We could also test on Windows 7, but you already did that and it works there as well. We don't have a Mac OS X test environment unfortunately.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review43936
-----------------------------------------------------------


On April 8, 2014, 1:45 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 1:45 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ConnectionWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/HashUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/PingWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/faces-config.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1585650 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review43936
-----------------------------------------------------------


I verified that the patch applies cleanly, although IntelliJ had some path issues that needed manual correction.  I built with the websocket-backend profile enabled and verified that a war file was produced, the contents of which looked correct.

Ryan had some questions in an earlier comment about properties file and the sample data that I would like to see addressed.

Other than that, I think this is in a state where we can commit it.  It is sufficiently roped-off via the profile that the risk is low.

- Stanton Sievers


On April 8, 2014, 1:45 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 1:45 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ConnectionWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/HashUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/PingWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/faces-config.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1585650 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated April 8, 2014, 1:45 p.m.)


Review request for shindig.


Changes
-------

We've further enhanced the multi-threading and management of multiple connections
We updated the Tyrus Websocket library from 1.2.1 to 1.5
Timeouts are now configurabale
In case the connection to the database is lost during runtime (even if it is only one of many) the system is now trying to reconnect automatically
It is now possible to use authenticated connections with a basic security setting at server side.


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs (updated)
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ConnectionWatchdog.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/HashUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/PingWatchdog.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/faces-config.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1585650 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


File Attachments
----------------

Neo4j-Blogpost-v3.odt
  https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt


Thanks,

René Peinl


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated March 17, 2014, 3:13 p.m.)


Review request for shindig.


Changes
-------

Updated patch that addresses the dependency issue.


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs (updated)
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1578387 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


File Attachments
----------------

Neo4j-Blogpost-v3.odt
  https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt


Thanks,

René Peinl


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 2:35 p.m.)


Review request for shindig.


Changes
-------

Added some documentation


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1559939 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


File Attachments (updated)
----------------

Neo4j-Blogpost-v3.odt
  https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt


Thanks,

René Peinl


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32688
-----------------------------------------------------------


Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.

- Ryan Baxter


On Jan. 21, 2014, 4:23 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Jan. 24, 2014, 1:49 a.m., Ryan Baxter wrote:
> > Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.

Dear Ryan,
we thought we had documented everything, but realized that it may be more complicated than we thought. Therefore we attached a document that describes the setup of the driver in more detail and also includes some hints for developers how to use our code in their projects.
Hope that helps
René


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32689
-----------------------------------------------------------


On Jan. 21, 2014, 4:23 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.

> On Jan. 24, 2014, 1:49 a.m., Ryan Baxter wrote:
> > Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.
> 
> René Peinl wrote:
>     Dear Ryan,
>     we thought we had documented everything, but realized that it may be more complicated than we thought. Therefore we attached a document that describes the setup of the driver in more detail and also includes some hints for developers how to use our code in their projects.
>     Hope that helps
>     René
> 
> Ryan Baxter wrote:
>     Rene, very comprehensive!  Although I ran into a couple of problems.  I cloned the neo4j-websocket-common project and tried to build it and the build failed.  About 27 tests are not passing.
>     
>     Also I have a question about the shindig sample data.  Do I need to run the war produced by the neo4j-websocket-server project and have my neo4j-websocket-sever.properties point to the shindig sample data you have on DropBox?  I noticed there is a neo4j-websocket-server.properites in the Shindig project as well, does that just point to the neo4j-websocket-server?
> 
> Stanton Sievers wrote:
>     I did not see the same test issues that Ryan saw.  All of the neo4j-websocket-* projects built just fine for me.  I built on Win7 64-bit.  Ryan, did you build on Mac OS X?  Maybe there's a platform-specific issue there.

Yes I was running the tests on OSX.

Rene any comment on my other questions?


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32689
-----------------------------------------------------------


On April 8, 2014, 1:45 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 1:45 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ConnectionWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/HashUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/PingWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/faces-config.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1585650 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.

> On Jan. 24, 2014, 1:49 a.m., Ryan Baxter wrote:
> > Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.
> 
> René Peinl wrote:
>     Dear Ryan,
>     we thought we had documented everything, but realized that it may be more complicated than we thought. Therefore we attached a document that describes the setup of the driver in more detail and also includes some hints for developers how to use our code in their projects.
>     Hope that helps
>     René

Rene, very comprehensive!  Although I ran into a couple of problems.  I cloned the neo4j-websocket-common project and tried to build it and the build failed.  About 27 tests are not passing.

Also I have a question about the shindig sample data.  Do I need to run the war produced by the neo4j-websocket-server project and have my neo4j-websocket-sever.properties point to the shindig sample data you have on DropBox?  I noticed there is a neo4j-websocket-server.properites in the Shindig project as well, does that just point to the neo4j-websocket-server?


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32689
-----------------------------------------------------------


On Feb. 4, 2014, 2:35 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 2:35 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Stanton Sievers <si...@gmail.com>.

> On Jan. 24, 2014, 1:49 a.m., Ryan Baxter wrote:
> > Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.
> 
> René Peinl wrote:
>     Dear Ryan,
>     we thought we had documented everything, but realized that it may be more complicated than we thought. Therefore we attached a document that describes the setup of the driver in more detail and also includes some hints for developers how to use our code in their projects.
>     Hope that helps
>     René
> 
> Ryan Baxter wrote:
>     Rene, very comprehensive!  Although I ran into a couple of problems.  I cloned the neo4j-websocket-common project and tried to build it and the build failed.  About 27 tests are not passing.
>     
>     Also I have a question about the shindig sample data.  Do I need to run the war produced by the neo4j-websocket-server project and have my neo4j-websocket-sever.properties point to the shindig sample data you have on DropBox?  I noticed there is a neo4j-websocket-server.properites in the Shindig project as well, does that just point to the neo4j-websocket-server?

I did not see the same test issues that Ryan saw.  All of the neo4j-websocket-* projects built just fine for me.  I built on Win7 64-bit.  Ryan, did you build on Mac OS X?  Maybe there's a platform-specific issue there.


- Stanton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32689
-----------------------------------------------------------


On April 8, 2014, 1:45 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 1:45 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ConnectionWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/HashUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/PingWatchdog.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/faces-config.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1585650 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Neo4j-Blogpost-v3.odt
>   https://reviews.apache.org/media/uploaded/files/2014/02/04/cab9b5b9-ce49-4e0b-b36b-8e6f0b2cb056__Neo4j-Blogpost-v3.odt
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review32689
-----------------------------------------------------------


Good news I applied the patch and built the code and it produced a war :)  What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right?  Some simple instructions in the README would be good.

- Ryan Baxter


On Jan. 21, 2014, 4:23 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 4:23 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1559939 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 4:23 p.m.)


Review request for shindig.


Changes
-------

some last minute fixes of tabs that somehow got into the code again


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs (updated)
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1559939 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


Thanks,

René Peinl


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated Jan. 21, 2014, 1:26 p.m.)


Review request for shindig.


Changes
-------

We've updated the diff, so that a war file is built. The default values for the configuration files should fit with the demo database we have provided. For changes in the configuration files you will still need to extract them from the war file and add them after editing. 


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs (updated)
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1559939 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


Thanks,

René Peinl


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?
> 
> René Peinl wrote:
>     Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
>     For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
>     Just extract it, add the data we referenced in the previous comment and run the jar file. 
>     
>     Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)
>     
>     We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
>     The IDs are effectively integers; the range from 0 to 200 should be filled completely.
> 
> Ryan Baxter wrote:
>     Rene, I went back and read thought the README in the patch and after reading this I wondered if you have considered creating a separate upstream project for this?  There is a lot of manual manipulation of the code and then you have to repackage everything.  With an upstream project you don't have to worry about doing any of this, you ca have your own web app the demonstrated the graph db implementation.  Also I assume that if you were to put this on github you would avoid the legal issues with neo4j and be able to include the dependencies.
> 
> René Peinl wrote:
>     Ryan, thanks for your comments. I can't really believe that you don't want to include our patch although it would give Shindig a proper database backend, which it doesn't have currently and we explicitly asked whether you would like to have it before we started. The last comment from you on 25th of July 2013 was: "I think Rene can move forward with his proposal". What made you change your mind?
>     If it is only a problem of how to compile it with the rest of Shindig, I'm sure we can work it out together. Maybe Florian's description is not the best way to do it. I think if you compile our code together with the rest if Shindig before packaging the WAR file then there would be no need to repackage. Florian took the old JPA backend and it's deployment as an example for his own description. 
>     Please reconsider this.
>

Rene, by no means am I saying we can't deliver the patch I am just trying to solve the problem of making it as easy as possible to use it.  Could we create another maven project that produces a war containing a web xml with the correct guice modules?


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?

Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
Just extract it, add the data we referenced in the previous comment and run the jar file. 

Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)

We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
The IDs are effectively integers; the range from 0 to 200 should be filled completely.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?
> 
> René Peinl wrote:
>     Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
>     For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
>     Just extract it, add the data we referenced in the previous comment and run the jar file. 
>     
>     Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)
>     
>     We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
>     The IDs are effectively integers; the range from 0 to 200 should be filled completely.
> 
> Ryan Baxter wrote:
>     Rene, I went back and read thought the README in the patch and after reading this I wondered if you have considered creating a separate upstream project for this?  There is a lot of manual manipulation of the code and then you have to repackage everything.  With an upstream project you don't have to worry about doing any of this, you ca have your own web app the demonstrated the graph db implementation.  Also I assume that if you were to put this on github you would avoid the legal issues with neo4j and be able to include the dependencies.

Ryan, thanks for your comments. I can't really believe that you don't want to include our patch although it would give Shindig a proper database backend, which it doesn't have currently and we explicitly asked whether you would like to have it before we started. The last comment from you on 25th of July 2013 was: "I think Rene can move forward with his proposal". What made you change your mind?
If it is only a problem of how to compile it with the rest of Shindig, I'm sure we can work it out together. Maybe Florian's description is not the best way to do it. I think if you compile our code together with the rest if Shindig before packaging the WAR file then there would be no need to repackage. Florian took the old JPA backend and it's deployment as an example for his own description. 
Please reconsider this.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?
> 
> René Peinl wrote:
>     Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
>     For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
>     Just extract it, add the data we referenced in the previous comment and run the jar file. 
>     
>     Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)
>     
>     We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
>     The IDs are effectively integers; the range from 0 to 200 should be filled completely.
> 
> Ryan Baxter wrote:
>     Rene, I went back and read thought the README in the patch and after reading this I wondered if you have considered creating a separate upstream project for this?  There is a lot of manual manipulation of the code and then you have to repackage everything.  With an upstream project you don't have to worry about doing any of this, you ca have your own web app the demonstrated the graph db implementation.  Also I assume that if you were to put this on github you would avoid the legal issues with neo4j and be able to include the dependencies.
> 
> René Peinl wrote:
>     Ryan, thanks for your comments. I can't really believe that you don't want to include our patch although it would give Shindig a proper database backend, which it doesn't have currently and we explicitly asked whether you would like to have it before we started. The last comment from you on 25th of July 2013 was: "I think Rene can move forward with his proposal". What made you change your mind?
>     If it is only a problem of how to compile it with the rest of Shindig, I'm sure we can work it out together. Maybe Florian's description is not the best way to do it. I think if you compile our code together with the rest if Shindig before packaging the WAR file then there would be no need to repackage. Florian took the old JPA backend and it's deployment as an example for his own description. 
>     Please reconsider this.
>
> 
> Ryan Baxter wrote:
>     Rene, by no means am I saying we can't deliver the patch I am just trying to solve the problem of making it as easy as possible to use it.  Could we create another maven project that produces a war containing a web xml with the correct guice modules?
> 
> René Peinl wrote:
>     That seems like a good solution to me. We will work on that.

We've updated the patch attached to the issue, so that a war file is built. The default values for the configuration files should fit with the demo database we have provided. For changes in the configuration files you will still need to extract them from the war file and add them after editing. 


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?
> 
> René Peinl wrote:
>     Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
>     For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
>     Just extract it, add the data we referenced in the previous comment and run the jar file. 
>     
>     Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)
>     
>     We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
>     The IDs are effectively integers; the range from 0 to 200 should be filled completely.

Rene, I went back and read thought the README in the patch and after reading this I wondered if you have considered creating a separate upstream project for this?  There is a lot of manual manipulation of the code and then you have to repackage everything.  With an upstream project you don't have to worry about doing any of this, you ca have your own web app the demonstrated the graph db implementation.  Also I assume that if you were to put this on github you would avoid the legal issues with neo4j and be able to include the dependencies.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.

> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote:
> > Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?
> 
> René Peinl wrote:
>     Ryan, now I'm a little confused too. I guess you would do it the same way as you did before with MySQL or any other database server. You would download the JAR files or compile the code, which is open source. 
>     For your convenience, we have put everything in a package on dropbox. https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip
>     Just extract it, add the data we referenced in the previous comment and run the jar file. 
>     
>     Our Shindig module is an optional one, so if any user decides not to use it there is no problem. (It will only be compiled when the profile "websocket-backend" is specified as can be seen in the pom file)
>     
>     We forgot to provide some user IDs from our sample dataset so you can formulate some requests.
>     The IDs are effectively integers; the range from 0 to 200 should be filled completely.
> 
> Ryan Baxter wrote:
>     Rene, I went back and read thought the README in the patch and after reading this I wondered if you have considered creating a separate upstream project for this?  There is a lot of manual manipulation of the code and then you have to repackage everything.  With an upstream project you don't have to worry about doing any of this, you ca have your own web app the demonstrated the graph db implementation.  Also I assume that if you were to put this on github you would avoid the legal issues with neo4j and be able to include the dependencies.
> 
> René Peinl wrote:
>     Ryan, thanks for your comments. I can't really believe that you don't want to include our patch although it would give Shindig a proper database backend, which it doesn't have currently and we explicitly asked whether you would like to have it before we started. The last comment from you on 25th of July 2013 was: "I think Rene can move forward with his proposal". What made you change your mind?
>     If it is only a problem of how to compile it with the rest of Shindig, I'm sure we can work it out together. Maybe Florian's description is not the best way to do it. I think if you compile our code together with the rest if Shindig before packaging the WAR file then there would be no need to repackage. Florian took the old JPA backend and it's deployment as an example for his own description. 
>     Please reconsider this.
>
> 
> Ryan Baxter wrote:
>     Rene, by no means am I saying we can't deliver the patch I am just trying to solve the problem of making it as easy as possible to use it.  Could we create another maven project that produces a war containing a web xml with the correct guice modules?

That seems like a good solution to me. We will work on that.


- René


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review31420
-----------------------------------------------------------


Rene I guess I am a little confused, how could we ever apply this patch to Shindig if it would require additional software to run Shindig with it?

- Ryan Baxter


On Jan. 8, 2014, 1:37 p.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:37 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Bugs: Shindig-1911
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> Diffs
> -----
> 
>   /trunk/java/websocket-backend/LICENSE PRE-CREATION 
>   /trunk/java/websocket-backend/NOTICE PRE-CREATION 
>   /trunk/java/websocket-backend/README PRE-CREATION 
>   /trunk/java/websocket-backend/pom.xml PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
>   /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
>   /trunk/pom.xml 1556165 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>


Re: Review Request 9773: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 1:37 p.m.)


Review request for shindig.


Changes
-------

We created a new patch that has a substantially improved architecture separating APL-licensed code at Shindig side from GPL-licensed code at neo4j side by a Websocket connection, so that no compile dependencies between the two code parts exists. 
Please note that additional software is necessary to run Shindig with that patch. It is described in the environment field of the issue. 
Test data to verify the patch can be obtained from dropbox
https://dl.dropboxusercontent.com/u/32445341/neo4j.zip
Zip file should be extracted to a new folder. Then point the neo4j server to this folder as its database folder.


Bugs: Shindig-1911
    https://issues.apache.org/jira/browse/Shindig-1911


Repository: shindig


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


Diffs (updated)
-----

  /trunk/java/websocket-backend/LICENSE PRE-CREATION 
  /trunk/java/websocket-backend/NOTICE PRE-CREATION 
  /trunk/java/websocket-backend/README PRE-CREATION 
  /trunk/java/websocket-backend/pom.xml PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java PRE-CREATION 
  /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java PRE-CREATION 
  /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java PRE-CREATION 
  /trunk/pom.xml 1556165 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


Thanks,

René Peinl


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/
-----------------------------------------------------------

(Updated March 7, 2013, 1:17 p.m.)


Review request for shindig.


Changes
-------

we applied the style formatting in Eclipse as requested. Florian, the developer, will provide additional information regarding the Guice settings in web.xml


Description
-------

Review for Shindig-1911
Alternative database backend based on graph database neo4j
Any comments welcome. We are committed to further improve this.


This addresses bug Shindig-1911.
    https://issues.apache.org/jira/browse/Shindig-1911


Diffs (updated)
-----

  /trunk/java/neo4j-backend/pom.xml PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java PRE-CREATION 
  /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java PRE-CREATION 
  /trunk/pom.xml 1452786 

Diff: https://reviews.apache.org/r/9773/diff/


Testing
-------


Thanks,

René Peinl


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Peter Neubauer <pe...@neotechnology.com>.
Guys,
I also will ask around on my side. Thanks!

/peter

Sent from mobile device.
On Mar 10, 2013 8:29 PM, <rb...@gmail.com> wrote:

> Thanks for the insight Ate.
>
> Rene, I think we should take Ate's suggestion and send an email to
> legal-discussion@ (please CC shindig-dev@).  If they say it is OK than we
> continue the discussion about integrating the patch.
>
>
> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
> wrote:
>
> > Dear Ate,
> > thanks for your comments. I already thought about this and asked the
> guys from neo technologies. Here is the answer from Peter Neubauer.
> >
> > in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL
> code. In runtime, the user will not be shielded from the GPL core, which
> means the runtime will have GPL characteristics when you plug in Neo4j.
> That is exactly the intent, and should be ok. The bindings-code is
> development-time Apache license, regarding contributions and copyright etc,
> so I think this should be ok.
> >
> > I'm not quite sure if that answers your question. I can further
> investigate if necessary.
> > Regards
> > René
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Ate Douma [mailto:ate@douma.nu]
> > Gesendet: Freitag, 8. März 2013 14:18
> > An: dev@shindig.apache.org
> > Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
> >
> > Just from the peanut gallery, but neo4j is AGPL licensed.
> > Normally any database backend access which is abstracted away behind
> 'plain'
> > JDBC interfaces are allright to use, commercial versions or otherwise
> licensed, because the end-user would have the option to choose whatever
> (compatible) database they want to use.
> >
> > However with neo4j this seems different. Even with only optional support
> for neo4j, the neo4j integration might require explicit neo4j (Java) APIs
> and dependencies? I haven't reviewed the code for this, but if it imports
> neo4j APIs then their AGPL license can be too invasive and then possibly
> not acceptable for uses within our AL2.0 licensed codebase.
> > Or even if that could be allowed, I would make sure to check and ask
> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
> >
> > Regards, Ate
> >
> > On 03/07/2013 07:46 PM, Henry Saputra wrote:
> >> This is good news.
> >>
> >> One immediate comment is about the package name.
> >> Would it be possible to put it under org.apache.shindig rather than
> >> the de.hofuniversity?
> >>
> >> This would make the contributions uniform like from other companies
> >> and organizations.
> >>
> >> - Henry
> >>
> >>
> >> 2013/3/6 René Peinl <re...@hof-university.de>
> >>
> >>>
> >>> -----------------------------------------------------------
> >>> This is an automatically generated e-mail. To reply, visit:
> >>> https://reviews.apache.org/r/9773/
> >>> -----------------------------------------------------------
> >>>
> >>> Review request for shindig.
> >>>
> >>>
> >>> Description
> >>> -------
> >>>
> >>> Review for Shindig-1911
> >>> Alternative database backend based on graph database neo4j Any
> >>> comments welcome. We are committed to further improve this.
> >>>
> >>>
> >>> This addresses bug Shindig-1911.
> >>>     https://issues.apache.org/jira/browse/Shindig-1911
> >>>
> >>>
> >>> Diffs
> >>> -----
> >>>
> >>>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/Constants.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GraphAPIModule.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GraphConfig.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GuiceModule.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/db/neo4j/INeo4jConnector.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/db/neo4j/Neo4jConnector.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/db/neo4j/Neo4jHAConnector.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/db/neo4j/Neo4jRelTypes.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/db/neo4j/Neo4jRestConnector.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/ExtOrgPersonImpl.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/ExtOrganizationImpl.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/IExtOrgPerson.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/IExtOrganization.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherActivityEntry.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherActivityObject.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherAttributesMessage.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherListFieldList.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherMessage.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherMessageCollection.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/cypher/CypherPerson.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/ADataTransferObject.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/AccountDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/ActivityDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/ActivityEntryDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/ActivityObjectDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/AddressDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/DTOHelper.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/GroupDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/MediaItemDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/MediaLinkDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/MessageCollectionDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/MessageDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/OrganizationDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/dto/PersonDTO.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphAccount.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphActivity.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphActivityEntry.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphActivityObject.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphAddress.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphAppData.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphGroup.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphListFieldList.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMediaItem.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMediaLink.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMessage.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMessageCollection.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphOrganization.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphPerson.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/spring/SpringAccount.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/spring/SpringAddress.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/spring/SpringApplication.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/spring/SpringOrganization.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/spring/SpringPerson.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/service/ExtPersonHandler.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/service/UserHandler.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphActivitySPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphActivityStreamSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphAlbumSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphAppDataSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphFriendSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphGroupSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphMediaItemSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphMessageSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/IExtPersonService.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/IFriendService.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/IGraphService.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/CypherGraphSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/CypherGroupSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/CypherMessageSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/CypherPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/RestCypherGraphSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/RestCypherGroupSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/RestCypherMessageSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/RestCypherPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/gremlin/GremlinGraphSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/gremlin/GremlinMessageSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/gremlin/GremlinPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/spring/PersonRepository.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/spring/SpringPersonSPI.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/ActivityObjectService.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/ApplicationService.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/IDManager.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/testdata/BatchParser.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/testdata/DataGenerator.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/testdata/DataParser.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/NodeFilter.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/NodeSorter.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/PersonFilter.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphActivityEntryTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphAppDataTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphGroupTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMessageCollectionTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphMessageTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/model/graph/GraphPersonTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/service/UserHandlerTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphActivitySPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphActivityStreamSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphAppDataSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphFriendSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphGroupSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphMessageSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphPersonSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/opensocial/spi/GraphSPITest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/ActivityObjectServiceTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/ApplicationServiceTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/service/IDManagerTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/NodeFilterTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/NodeSorterTest.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
> >>> ackend/util/PersonFilterTest.java
> >>> PRE-CREATION
> >>>   /trunk/pom.xml 1452786
> >>>
> >>> Diff: https://reviews.apache.org/r/9773/diff/
> >>>
> >>>
> >>> Testing
> >>> -------
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> René Peinl
> >>>
> >>>
> >>
> >
> >
> >
>
>

AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
Good to know, but that doesn't solve the problem for Camel, does it? 
What difference does it make to have APL => APL => GPL or directly APL =>
GPL coupling?
It just shifts the problem from Shindig or Camel to SpringData.

-----Ursprüngliche Nachricht-----
Von: Chris Geer [mailto:chris@cxtsoftware.com] 
Gesendet: Montag, 11. März 2013 15:08
An: dev@shindig.apache.org
Betreff: Re: Review Request: Alternative database backend based on graph
database neo4j

On Mon, Mar 11, 2013 at 12:48 AM, Ate Douma <at...@douma.nu> wrote:

> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>
>> On Sunday, March 10, 2013, wrote:
>>
>>  Thanks for the insight Ate.
>>>
>>> Rene, I think we should take Ate's suggestion and send an email to 
>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK 
>>> than we continue the discussion about integrating the patch.
>>>
>>
>>
> Although the answer from Peter Neubauer / neotechnology is 
> accommodating on this matter and seems to indicate *they* might think 
> this is not a problem, reading the AGPL [1] license tells me something
differently.
> I definitely would like this contribution to be acceptable, but we 
> must be very sure we're not opening a can of worms here.
>
>
>
>> I agree that legal should be consulted if we intent to ship a war or 
>> other archive with any neo4j (or other agpl) licensed binaries included.
>>
> I don't think we can do that anyway. AGPL is a variant of GPL, and 
> we're not allowed, by ASF policy, to distribute any GPL artifact.
>
>
>
>> As a first mitigation step, why don't we make this a separate maven 
>> module and only ship the source and non-inclusive jar?  It should not 
>> be a problem to ship a jar and source that only references the neo4j 
>> libs as runtime dependencies.
>>
> That might be a possibility to investigate. As Chris noted in another 
> email, it might be doable as Camel seemingly also has a neo4j component.
>

I looked into it and Camel uses the Spring Neo4J library which is apache
licensed [1].

[1] http://www.springsource.org/spring-data/neo4j

>
> But also note: it will also depend on the type of reference such an 
> optional module uses. If it requires explicit Java imports and direct 
> usage of the neo4j APIs, this might qualifies as what is called in the 
> AGPL 'Corresponding Source'. Especially as neo4j and Shindig provide 
> and expect 'Remote Network Interaction' for which the AGPL is 
> especially created to enforce its license to downstream users. IMO 
> this can lead to a conflict with the AS2.0 license, to possibly not 
> even be allowed distribution under that license from within the ASF, 
> or not even its sources be checked into svn...
>
> But IANAL so indeed this should be run through legal-discuss@ first.
>
> [1] 
> http://www.gnu.org/licenses/**agpl-3.0.html<http://www.gnu.org/license
> s/agpl-3.0.html>
>
>
>
>>
>>
>>
>>>
>>> On Mar 9, 2013, at 7:56 AM, René Peinl 
>>> <re...@hof-university.de>
>>> wrote:
>>>
>>>  Dear Ate,
>>>> thanks for your comments. I already thought about this and asked 
>>>> the
>>>>
>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>
>>>>
>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to 
>>>> GPL
>>>>
>>> code. In runtime, the user will not be shielded from the GPL core, 
>>> which means the runtime will have GPL characteristics when you plug in
Neo4j.
>>> That is exactly the intent, and should be ok. The bindings-code is 
>>> development-time Apache license, regarding contributions and 
>>> copyright etc, so I think this should be ok.
>>>
>>>>
>>>> I'm not quite sure if that answers your question. I can further
>>>>
>>> investigate if necessary.
>>>
>>>> Regards
>>>> René
>>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>> An: dev@shindig.apache.org
>>>> Betreff: Re: Review Request: Alternative database backend based on 
>>>> graph
>>>>
>>> database neo4j
>>>
>>>>
>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>> Normally any database backend access which is abstracted away 
>>>> behind
>>>>
>>> 'plain'
>>>
>>>> JDBC interfaces are allright to use, commercial versions or 
>>>> otherwise
>>>>
>>> licensed, because the end-user would have the option to choose 
>>> whatever
>>> (compatible) database they want to use.
>>>
>>>>
>>>> However with neo4j this seems different. Even with only optional 
>>>> support
>>>>
>>> for neo4j, the neo4j integration might require explicit neo4j (Java) 
>>> APIs and dependencies? I haven't reviewed the code for this, but if 
>>> it imports neo4j APIs then their AGPL license can be too invasive 
>>> and then possibly not acceptable for uses within our AL2.0 licensed
codebase.
>>>
>>>> Or even if that could be allowed, I would make sure to check and 
>>>> ask
>>>>
>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>
>>>>
>>>> Regards, Ate
>>>>
>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>
>>>>> This is good news.
>>>>>
>>>>> One immediate comment is about the package name.
>>>>> Would it be possible to put it under org.apache.shindig rather 
>>>>> than the de.hofuniversity?
>>>>>
>>>>> This would make the contributions uniform like from other 
>>>>> companies and organizations.
>>>>>
>>>>> - Henry
>>>>>
>>>>>
>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>
>>>>>
>>>>>> ------------------------------**-----------------------------
>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>> https://reviews.apache.org/r/**9773/<https://reviews.apache.org/r
>>>>>> /9773/>
>>>>>> ------------------------------**-----------------------------
>>>>>>
>>>>>> Review request for shindig.
>>>>>>
>>>>>>
>>>>>> Description
>>>>>> -------
>>>>>>
>>>>>> Review for Shindig-1911
>>>>>> Alternative database backend based on graph database neo4j Any 
>>>>>> comments welcome. We are committed to further improve this.
>>>>>>
>>>>>>
>>>>>> This addresses bug Shindig-1911.
>>>>>>      
>>>>>> https://issues.apache.org/**jira/browse/Shindig-1911<https://issu
>>>>>> es.apache.org/jira/browse/Shindig-1911>
>>>>>>
>>>>>>
>>>>>> Diffs
>>>>>> -----
>>>>>>
>>>>>>    /trunk/java/neo4j-backend/pom.**xml PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/Constants.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GraphAPIModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GraphConfig.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GuiceModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> acke
>>>>>>
>>>>>
>>
>
>


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Chris Geer <ch...@cxtsoftware.com>.
On Mon, Mar 11, 2013 at 12:48 AM, Ate Douma <at...@douma.nu> wrote:

> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>
>> On Sunday, March 10, 2013, wrote:
>>
>>  Thanks for the insight Ate.
>>>
>>> Rene, I think we should take Ate's suggestion and send an email to
>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK than
>>> we
>>> continue the discussion about integrating the patch.
>>>
>>
>>
> Although the answer from Peter Neubauer / neotechnology is accommodating
> on this matter and seems to indicate *they* might think this is not a
> problem, reading the AGPL [1] license tells me something differently.
> I definitely would like this contribution to be acceptable, but we must be
> very sure we're not opening a can of worms here.
>
>
>
>> I agree that legal should be consulted if we intent to ship a war or other
>> archive with any neo4j (or other agpl) licensed binaries included.
>>
> I don't think we can do that anyway. AGPL is a variant of GPL, and we're
> not allowed, by ASF policy, to distribute any GPL artifact.
>
>
>
>> As a first mitigation step, why don't we make this a separate maven module
>> and only ship the source and non-inclusive jar?  It should not be a
>> problem
>> to ship a jar and source that only references the neo4j libs as runtime
>> dependencies.
>>
> That might be a possibility to investigate. As Chris noted in another
> email, it might be doable as Camel seemingly also has a neo4j component.
>

I looked into it and Camel uses the Spring Neo4J library which is
apache licensed [1].

[1] http://www.springsource.org/spring-data/neo4j

>
> But also note: it will also depend on the type of reference such an
> optional module uses. If it requires explicit Java imports and direct usage
> of the neo4j APIs, this might qualifies as what is called in the AGPL
> 'Corresponding Source'. Especially as neo4j and Shindig provide and expect
> 'Remote Network Interaction' for which the AGPL is especially created to
> enforce its license to downstream users. IMO this can lead to a conflict
> with the AS2.0 license, to possibly not even be allowed distribution under
> that license from within the ASF, or not even its sources be checked into
> svn...
>
> But IANAL so indeed this should be run through legal-discuss@ first.
>
> [1] http://www.gnu.org/licenses/**agpl-3.0.html<http://www.gnu.org/licenses/agpl-3.0.html>
>
>
>
>>
>>
>>
>>>
>>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>>> wrote:
>>>
>>>  Dear Ate,
>>>> thanks for your comments. I already thought about this and asked the
>>>>
>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>
>>>>
>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL
>>>>
>>> code. In runtime, the user will not be shielded from the GPL core, which
>>> means the runtime will have GPL characteristics when you plug in Neo4j.
>>> That is exactly the intent, and should be ok. The bindings-code is
>>> development-time Apache license, regarding contributions and copyright
>>> etc,
>>> so I think this should be ok.
>>>
>>>>
>>>> I'm not quite sure if that answers your question. I can further
>>>>
>>> investigate if necessary.
>>>
>>>> Regards
>>>> René
>>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>> An: dev@shindig.apache.org
>>>> Betreff: Re: Review Request: Alternative database backend based on graph
>>>>
>>> database neo4j
>>>
>>>>
>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>> Normally any database backend access which is abstracted away behind
>>>>
>>> 'plain'
>>>
>>>> JDBC interfaces are allright to use, commercial versions or otherwise
>>>>
>>> licensed, because the end-user would have the option to choose whatever
>>> (compatible) database they want to use.
>>>
>>>>
>>>> However with neo4j this seems different. Even with only optional support
>>>>
>>> for neo4j, the neo4j integration might require explicit neo4j (Java) APIs
>>> and dependencies? I haven't reviewed the code for this, but if it imports
>>> neo4j APIs then their AGPL license can be too invasive and then possibly
>>> not acceptable for uses within our AL2.0 licensed codebase.
>>>
>>>> Or even if that could be allowed, I would make sure to check and ask
>>>>
>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>
>>>>
>>>> Regards, Ate
>>>>
>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>
>>>>> This is good news.
>>>>>
>>>>> One immediate comment is about the package name.
>>>>> Would it be possible to put it under org.apache.shindig rather than
>>>>> the de.hofuniversity?
>>>>>
>>>>> This would make the contributions uniform like from other companies
>>>>> and organizations.
>>>>>
>>>>> - Henry
>>>>>
>>>>>
>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>
>>>>>
>>>>>> ------------------------------**-----------------------------
>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>> https://reviews.apache.org/r/**9773/<https://reviews.apache.org/r/9773/>
>>>>>> ------------------------------**-----------------------------
>>>>>>
>>>>>> Review request for shindig.
>>>>>>
>>>>>>
>>>>>> Description
>>>>>> -------
>>>>>>
>>>>>> Review for Shindig-1911
>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>> comments welcome. We are committed to further improve this.
>>>>>>
>>>>>>
>>>>>> This addresses bug Shindig-1911.
>>>>>>      https://issues.apache.org/**jira/browse/Shindig-1911<https://issues.apache.org/jira/browse/Shindig-1911>
>>>>>>
>>>>>>
>>>>>> Diffs
>>>>>> -----
>>>>>>
>>>>>>    /trunk/java/neo4j-backend/pom.**xml PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/Constants.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GraphAPIModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GraphConfig.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> ackend/GuiceModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/**main/java/de/hofuniversity/**
>>>>>> iisys/graphb
>>>>>> acke
>>>>>>
>>>>>
>>
>
>

Re: AW: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
Forwarding to correct legal-discuss@ address, as intended.

NB: I'm going to forward two more responses to the below question which likewise 
were also incorrectly addressed at legal-discussion@

On 03/11/2013 09:22 AM, René Peinl wrote:
> Dear Apache legal advisors, dear Shindig developers,
> as you can see from the discussion below, we have a possible license
> conflict between AGPL and APL v2.
> We want to integrate code that uses neo4j, a graph database which is
> licensed under AGPL, into Shindig. From my perspective it is not necessary
> to include any neo4j binaries nor code, but I'm not sure how this affects
> compilability. Maybe we can only use the REST API then and don't offer to
> run neo4j in embedded mode.
> I'm not a lawyer nor a licensing specialist, so please advise on how to
> proceed. Maybe we can find a workaround that ensures we are conforming to
> the licensing terms and still get the new functionality into Shindig.
> One suggestion that seems a good one was to check how Apache Camel deals
> with this issue.
> Regards and many thanks for clarification in advance
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu]
> Gesendet: Montag, 11. März 2013 08:49
> An: dev@shindig.apache.org
> Cc: Peter Neubauer
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>> On Sunday, March 10, 2013, wrote:
>>
>>> Thanks for the insight Ate.
>>>
>>> Rene, I think we should take Ate's suggestion and send an email to
>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK
>>> than we continue the discussion about integrating the patch.
>>
>
> Although the answer from Peter Neubauer / neotechnology is accommodating on
> this matter and seems to indicate *they* might think this is not a problem,
> reading the AGPL [1] license tells me something differently.
> I definitely would like this contribution to be acceptable, but we must be
> very sure we're not opening a can of worms here.
>
>>
>> I agree that legal should be consulted if we intent to ship a war or
>> other archive with any neo4j (or other agpl) licensed binaries included.
> I don't think we can do that anyway. AGPL is a variant of GPL, and we're not
> allowed, by ASF policy, to distribute any GPL artifact.
>
>>
>> As a first mitigation step, why don't we make this a separate maven
>> module and only ship the source and non-inclusive jar?  It should not
>> be a problem to ship a jar and source that only references the neo4j
>> libs as runtime dependencies.
> That might be a possibility to investigate. As Chris noted in another email,
> it might be doable as Camel seemingly also has a neo4j component.
>
> But also note: it will also depend on the type of reference such an optional
> module uses. If it requires explicit Java imports and direct usage of the
> neo4j APIs, this might qualifies as what is called in the AGPL
> 'Corresponding Source'.
> Especially as neo4j and Shindig provide and expect 'Remote Network
> Interaction'
> for which the AGPL is especially created to enforce its license to
> downstream users. IMO this can lead to a conflict with the AS2.0 license, to
> possibly not even be allowed distribution under that license from within the
> ASF, or not even its sources be checked into svn...
>
> But IANAL so indeed this should be run through legal-discuss@ first.
>
> [1] http://www.gnu.org/licenses/agpl-3.0.html
>
>>
>>
>>
>>>
>>>
>>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>>> wrote:
>>>
>>>> Dear Ate,
>>>> thanks for your comments. I already thought about this and asked the
>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>
>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to
>>>> GPL
>>> code. In runtime, the user will not be shielded from the GPL core,
>>> which means the runtime will have GPL characteristics when you plug in
> Neo4j.
>>> That is exactly the intent, and should be ok. The bindings-code is
>>> development-time Apache license, regarding contributions and
>>> copyright etc, so I think this should be ok.
>>>>
>>>> I'm not quite sure if that answers your question. I can further
>>> investigate if necessary.
>>>> Regards
>>>> René
>>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>> An: dev@shindig.apache.org
>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>> graph
>>> database neo4j
>>>>
>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>> Normally any database backend access which is abstracted away behind
>>> 'plain'
>>>> JDBC interfaces are allright to use, commercial versions or
>>>> otherwise
>>> licensed, because the end-user would have the option to choose
>>> whatever
>>> (compatible) database they want to use.
>>>>
>>>> However with neo4j this seems different. Even with only optional
>>>> support
>>> for neo4j, the neo4j integration might require explicit neo4j (Java)
>>> APIs and dependencies? I haven't reviewed the code for this, but if
>>> it imports neo4j APIs then their AGPL license can be too invasive and
>>> then possibly not acceptable for uses within our AL2.0 licensed codebase.
>>>> Or even if that could be allowed, I would make sure to check and ask
>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>
>>>> Regards, Ate
>>>>
>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>> This is good news.
>>>>>
>>>>> One immediate comment is about the package name.
>>>>> Would it be possible to put it under org.apache.shindig rather than
>>>>> the de.hofuniversity?
>>>>>
>>>>> This would make the contributions uniform like from other companies
>>>>> and organizations.
>>>>>
>>>>> - Henry
>>>>>
>>>>>
>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>
>>>>>>
>>>>>> -----------------------------------------------------------
>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>> https://reviews.apache.org/r/9773/
>>>>>> -----------------------------------------------------------
>>>>>>
>>>>>> Review request for shindig.
>>>>>>
>>>>>>
>>>>>> Description
>>>>>> -------
>>>>>>
>>>>>> Review for Shindig-1911
>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>> comments welcome. We are committed to further improve this.
>>>>>>
>>>>>>
>>>>>> This addresses bug Shindig-1911.
>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>
>>>>>>
>>>>>> Diffs
>>>>>> -----
>>>>>>
>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>> phb
>>>>>> ackend/Constants.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>> phb
>>>>>> ackend/GraphAPIModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>> phb
>>>>>> ackend/GraphConfig.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>> phb
>>>>>> ackend/GuiceModule.java
>>>>>> PRE-CREATION
>>>>>>
>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>> phb
>>>>>> acke
>>
>
>
>



Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
On 03/11/2013 09:41 AM, Peter Neubauer wrote:
> Also,
> keep in mind that only the enterprise components of Neo4j are AGPL, the
> community edition, which I believe is the most interesting part here, is
> GPL.

That is useful information indeed. Thanks for correcting me in this!

So for this case at hand I assume we only need to consider the possibilities to 
use the GPL3 licensed community edition of neo4j.

The question then is if at the ASF we may reference and explicitly use GPL3 
licensed APIs in our AL2.0 licensed code, in an optional module, which also 
requires these GPL3 libraries at runtime.
Even if we don't distribute those 3rd party GPL3 libraries ourselves.


>
> /peter
>
>
> Cheers,
>
> /peter neubauer
>
> G:  neubauer.peter
> S:  peter.neubauer
> P:  +46 704 106975
> L:   http://www.linkedin.com/in/neubauer
> T:   @peterneubauer
>
> Graph database introduction book for the uninitiated -
> http://graphdatabases.com
> Neo4j questions? Please use SO - http://stackoverflow.com/search?q=neo4j
>
>
> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl <re...@hof-university.de>wrote:
>
>> Dear Apache legal advisors, dear Shindig developers,
>> as you can see from the discussion below, we have a possible license
>> conflict between AGPL and APL v2.
>> We want to integrate code that uses neo4j, a graph database which is
>> licensed under AGPL, into Shindig. From my perspective it is not necessary
>> to include any neo4j binaries nor code, but I'm not sure how this affects
>> compilability. Maybe we can only use the REST API then and don't offer to
>> run neo4j in embedded mode.
>> I'm not a lawyer nor a licensing specialist, so please advise on how to
>> proceed. Maybe we can find a workaround that ensures we are conforming to
>> the licensing terms and still get the new functionality into Shindig.
>> One suggestion that seems a good one was to check how Apache Camel deals
>> with this issue.
>> Regards and many thanks for clarification in advance
>> René
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Ate Douma [mailto:ate@douma.nu]
>> Gesendet: Montag, 11. März 2013 08:49
>> An: dev@shindig.apache.org
>> Cc: Peter Neubauer
>> Betreff: Re: Review Request: Alternative database backend based on graph
>> database neo4j
>>
>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>> On Sunday, March 10, 2013, wrote:
>>>
>>>> Thanks for the insight Ate.
>>>>
>>>> Rene, I think we should take Ate's suggestion and send an email to
>>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK
>>>> than we continue the discussion about integrating the patch.
>>>
>>
>> Although the answer from Peter Neubauer / neotechnology is accommodating on
>> this matter and seems to indicate *they* might think this is not a problem,
>> reading the AGPL [1] license tells me something differently.
>> I definitely would like this contribution to be acceptable, but we must be
>> very sure we're not opening a can of worms here.
>>
>>>
>>> I agree that legal should be consulted if we intent to ship a war or
>>> other archive with any neo4j (or other agpl) licensed binaries included.
>> I don't think we can do that anyway. AGPL is a variant of GPL, and we're
>> not
>> allowed, by ASF policy, to distribute any GPL artifact.
>>
>>>
>>> As a first mitigation step, why don't we make this a separate maven
>>> module and only ship the source and non-inclusive jar?  It should not
>>> be a problem to ship a jar and source that only references the neo4j
>>> libs as runtime dependencies.
>> That might be a possibility to investigate. As Chris noted in another
>> email,
>> it might be doable as Camel seemingly also has a neo4j component.
>>
>> But also note: it will also depend on the type of reference such an
>> optional
>> module uses. If it requires explicit Java imports and direct usage of the
>> neo4j APIs, this might qualifies as what is called in the AGPL
>> 'Corresponding Source'.
>> Especially as neo4j and Shindig provide and expect 'Remote Network
>> Interaction'
>> for which the AGPL is especially created to enforce its license to
>> downstream users. IMO this can lead to a conflict with the AS2.0 license,
>> to
>> possibly not even be allowed distribution under that license from within
>> the
>> ASF, or not even its sources be checked into svn...
>>
>> But IANAL so indeed this should be run through legal-discuss@ first.
>>
>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>
>>>
>>>
>>>
>>>>
>>>>
>>>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>>>> wrote:
>>>>
>>>>> Dear Ate,
>>>>> thanks for your comments. I already thought about this and asked the
>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>
>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to
>>>>> GPL
>>>> code. In runtime, the user will not be shielded from the GPL core,
>>>> which means the runtime will have GPL characteristics when you plug in
>> Neo4j.
>>>> That is exactly the intent, and should be ok. The bindings-code is
>>>> development-time Apache license, regarding contributions and
>>>> copyright etc, so I think this should be ok.
>>>>>
>>>>> I'm not quite sure if that answers your question. I can further
>>>> investigate if necessary.
>>>>> Regards
>>>>> René
>>>>>
>>>>> -----Ursprüngliche Nachricht-----
>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>> An: dev@shindig.apache.org
>>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>>> graph
>>>> database neo4j
>>>>>
>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>> Normally any database backend access which is abstracted away behind
>>>> 'plain'
>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>> otherwise
>>>> licensed, because the end-user would have the option to choose
>>>> whatever
>>>> (compatible) database they want to use.
>>>>>
>>>>> However with neo4j this seems different. Even with only optional
>>>>> support
>>>> for neo4j, the neo4j integration might require explicit neo4j (Java)
>>>> APIs and dependencies? I haven't reviewed the code for this, but if
>>>> it imports neo4j APIs then their AGPL license can be too invasive and
>>>> then possibly not acceptable for uses within our AL2.0 licensed
>> codebase.
>>>>> Or even if that could be allowed, I would make sure to check and ask
>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>
>>>>> Regards, Ate
>>>>>
>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>> This is good news.
>>>>>>
>>>>>> One immediate comment is about the package name.
>>>>>> Would it be possible to put it under org.apache.shindig rather than
>>>>>> the de.hofuniversity?
>>>>>>
>>>>>> This would make the contributions uniform like from other companies
>>>>>> and organizations.
>>>>>>
>>>>>> - Henry
>>>>>>
>>>>>>
>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>
>>>>>>>
>>>>>>> -----------------------------------------------------------
>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>> -----------------------------------------------------------
>>>>>>>
>>>>>>> Review request for shindig.
>>>>>>>
>>>>>>>
>>>>>>> Description
>>>>>>> -------
>>>>>>>
>>>>>>> Review for Shindig-1911
>>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>>> comments welcome. We are committed to further improve this.
>>>>>>>
>>>>>>>
>>>>>>> This addresses bug Shindig-1911.
>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>
>>>>>>>
>>>>>>> Diffs
>>>>>>> -----
>>>>>>>
>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>
>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>> phb
>>>>>>> ackend/Constants.java
>>>>>>> PRE-CREATION
>>>>>>>
>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>> phb
>>>>>>> ackend/GraphAPIModule.java
>>>>>>> PRE-CREATION
>>>>>>>
>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>> phb
>>>>>>> ackend/GraphConfig.java
>>>>>>> PRE-CREATION
>>>>>>>
>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>> phb
>>>>>>> ackend/GuiceModule.java
>>>>>>> PRE-CREATION
>>>>>>>
>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>> phb
>>>>>>> acke
>>>
>>
>>
>>
>>
>



AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
That's still subject to discussion. As you see, we are pursuing two goals:
contribute to the Shindig project and do some research. 
Our first comparison was between SQL, Cypher, Gremlin and neo4j native API
regarding speed and maintainability of the code. We found out, that Cypher
is a good compromise.
For this next step we want to experiment with different network protocols
and payload types. In our first comparison, we found out that the existing
REST interface of neo4j is not performing very well. Neo technologies has
enhanced it since then, but we envision comparing a Web socket connection
with the existing http connection and a raw TCP socket connection regarding
speed. For the payload we are looking at JSON (currently used in neo4j),
BSON and an own object serialization. 
The last comparison will deal with the commands passed from Shindig to
neo4j. The obvious choice is Cypher, since this is becoming the default
language for neo4j, but we also want to experiment with kind of stored
procedures (not currently supported in neo4j), where we only transfer the
name of the query and the parameters. The implementation could then be
Cypher or native api on the neo4j side.
Any suggestions?
Regards
René
P.S.: Another interesting thing would be to experiment with asynchronous,
non-blocking database connections, but I guess that doesn't make sense, as
long as the rest of Shindig uses blocking calls.

-----Ursprüngliche Nachricht-----
Von: Ryan Baxter [mailto:rbaxter85@apache.org] 
Gesendet: Donnerstag, 18. Juli 2013 22:31
An: dev@shindig.apache.org
Betreff: Re: Review Request: Alternative database backend based on graph
database neo4j

Great.  So what technically will the code that is contributed to Shindig do?
How does it talk to the neo4j backend?

On Thu, Jul 18, 2013 at 9:25 AM, René Peinl <re...@hof-university.de>
wrote:
> Dear Ryan,
> fair question. The main contribution is to allow usage of neo4j as an 
> alternative database backend which improves performance significantly 
> in some areas compared to ORM and MySQL (see 
> http://www.edbt.org/Proceedings/2013-Genova/papers/workshops/a29-holzs
> chuher
> .pdf).
> In addition to that, we have also implemented some of the missing 
> features from Open Social 2.0 like adding friends to the friend 
> network and some additional features not mentioned in the Open Social 
> specification, but state-of-the-art in social networks like friend and 
> group recommendations based on friends in common and groups of friends.
> The limitation is, that these do only work or are only tested with 
> neo4j backend.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ryan Baxter [mailto:rbaxter85@apache.org]
> Gesendet: Mittwoch, 17. Juli 2013 02:32
> An: dev@shindig.apache.org
> Cc: Ate Douma; Peter Neubauer; Florian Holzschuher
> Betreff: Re: Review Request: Alternative database backend based on 
> graph database neo4j
>
> The split proposal sounds like a good approach, but what exactly would 
> be contributed to Shindig?
>
> On Tue, Jul 16, 2013 at 9:46 AM, René Peinl 
> <re...@hof-university.de>
> wrote:
>> Dear Ate, dear Shindig developers,
>> it's been some time since this discussion because we were a bit 
>> frustrated and the project on our side was frozen for some time.
>> Fortunately, I came up with an idea of how to circumvent this problem 
>> and this time wanted to do the legal check BEFORE we start the coding.
>>
>> The current code has a direct compilation dependency on either neo4j 
>> directly or at least their REST/JSON wrapper, which is also GPLv3
> licensed.
>> That seems to be the problem.
>> We therefore propose to split our code into two parts. One part 
>> should become part of the Apache Shindig project and will be licensed
APLv2.
>> The other part will directly use neo4j and therefore be licensed 
>> under
>> GPLv3 and published on sourceforge or somewhere. Between those two 
>> parts there will be only network communication, no compilation
dependency.
>>
>> Could somebody from the core team please confirm, that
>> a) this new proposal will have no licensing problem (my German 
>> lawyer, who is specialized in OSS licensing confirmed that, but the 
>> ASF may still see it
>> differently)
>> b) the community is still interested in the neo4j backend as an 
>> option for Shindig
>>
>> Otherwise, we would not invest any more time in this issue.
>> Regards
>> René
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Ate Douma [mailto:ate@douma.nu]
>> Gesendet: Mittwoch, 27. März 2013 15:22
>> An: dev@shindig.apache.org
>> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
>> Betreff: Re: Review Request: Alternative database backend based on 
>> graph database neo4j
>>
>> Sorry about top posting (and dropping legal-discuss@) but as we 
>> didn't get any feedback yet on the below question from 
>> legal-discuss@, I've dived into it myself a bit further.
>>
>> I already came to the conclusion (and discussed this internally with 
>> another ASF
>> member) that the current proposed contribution which directly uses 
>> Neo4J
>> GPL3 licensed APIs cannot be allowed, as that (source) dependency 
>> will enforce the
>> GPL3 license upon this contribution as a whole, optional or not.
>>
>> The possible 'workaround' of using a 3rd party library like 
>> spring-data-neo4j
>> (only) which is ALv2 licensed I am also very doubtful about, because 
>> that library itself has direct usage and dependency on the Neo4J 
>> APIs, so it really is only 'hiding' the same problem.
>> If this is a correct assumption, and I created an specific JIRA 
>> question [1] for legal-discuss@ for it, then the spring data 
>> 'workaround' is also tainted and not to be allowed either.
>>
>> I've also brought this forward to someone at Apache Camel which 
>> intend to (but hasn't yet) release a Camel Neo4J component, and it 
>> looks like they will decide also that Neo4J cannot be supported after 
>> all, at the
> ASF.
>>
>> Pending the resolution of [1], it now seems doubtful to me Apache 
>> Shindig can accept the neo4j support contribution.
>> If this becomes the case, I see two possible solutions, in preferred 
>> order (besides dropping it):
>>
>> a) NeoTechnology provides an additional (probably API only) library 
>> of its own under an ALv2 compatible license, which can be used to 
>> create integrations like these. This would be the most practical and 
>> beneficial solution IMO, similar to for instance the MongoDB (AGPL3
>> licensed) mongodb-java-driver library which is
>> ALv2 licensed, see [2].
>>
>> b) Provide the Shindig Neo4J support in a separate project outside 
>> the ASF, maybe at Apache Extras [3]. Downside of this of course is 
>> that alignment with Apache Shindig itself will be more difficult and 
>> likely trailing the development @Shindig.
>>
>> I'll keep the list noted on any progress or conclusion of [1].
>>
>> Regards, Ate
>>
>> [1] https://issues.apache.org/jira/browse/LEGAL-162
>> [2] https://github.com/mongodb/mongo-java-driver
>> [3] http://community.apache.org/apache-extras/faq.html
>>
>> On 03/11/2013 11:09 AM, Ate Douma wrote:
>>> Now replying again, but to the proper mail address, see inline below.
>>>
>>> Cheers, Ate
>>>
>>> On 03/11/2013 11:05 AM, Ate Douma wrote:
>>>> Another forward of an incorrectly addressed email for 
>>>> legal-discuss@
>>>>
>>>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>>>> Also,
>>>>> keep in mind that only the enterprise components of Neo4j are 
>>>>> AGPL, the community edition, which I believe is the most 
>>>>> interesting part here, is GPL.
>>>
>>> That is useful information indeed. Thanks for correcting me in this!
>>>
>>> So for this case at hand I assume we only need to consider the 
>>> possibilities to use the GPL3 licensed community edition of neo4j.
>>>
>>> The question then is if at the ASF we may reference and explicitly 
>>> use
>>> GPL3 licensed APIs in our AL2.0 licensed code, in an optional 
>>> module, which also requires these GPL3 libraries at runtime.
>>> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>>>
>>>>>
>>>>> /peter
>>>>>
>>>>>
>>>>> Cheers,
>>>>>
>>>>> /peter neubauer
>>>>>
>>>>> G:  neubauer.peter
>>>>> S:  peter.neubauer
>>>>> P:  +46 704 106975
>>>>> L:   http://www.linkedin.com/in/neubauer
>>>>> T:   @peterneubauer
>>>>>
>>>>> Graph database introduction book for the uninitiated - 
>>>>> http://graphdatabases.com Neo4j questions? Please use SO - 
>>>>> http://stackoverflow.com/search?q=neo4j
>>>>>
>>>>>
>>>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
>> <re...@hof-university.de>wrote:
>>>>>
>>>>>> Dear Apache legal advisors, dear Shindig developers, as you can 
>>>>>> see from the discussion below, we have a possible license 
>>>>>> conflict between AGPL and APL v2.
>>>>>> We want to integrate code that uses neo4j, a graph database which 
>>>>>> is licensed under AGPL, into Shindig. From my perspective it is 
>>>>>> not necessary to include any neo4j binaries nor code, but I'm not 
>>>>>> sure how this affects compilability. Maybe we can only use the 
>>>>>> REST API then and don't offer to run neo4j in embedded mode.
>>>>>> I'm not a lawyer nor a licensing specialist, so please advise on 
>>>>>> how to proceed. Maybe we can find a workaround that ensures we 
>>>>>> are conforming to the licensing terms and still get the new 
>>>>>> functionality
>> into Shindig.
>>>>>> One suggestion that seems a good one was to check how Apache 
>>>>>> Camel deals with this issue.
>>>>>> Regards and many thanks for clarification in advance René
>>>>>>
>>>>>> -----Ursprüngliche Nachricht-----
>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>> Gesendet: Montag, 11. März 2013 08:49
>>>>>> An: dev@shindig.apache.org
>>>>>> Cc: Peter Neubauer
>>>>>> Betreff: Re: Review Request: Alternative database backend based 
>>>>>> on graph database neo4j
>>>>>>
>>>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>>>> On Sunday, March 10, 2013, wrote:
>>>>>>>
>>>>>>>> Thanks for the insight Ate.
>>>>>>>>
>>>>>>>> Rene, I think we should take Ate's suggestion and send an email 
>>>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it 
>>>>>>>> is OK than we continue the discussion about integrating the patch.
>>>>>>>
>>>>>>
>>>>>> Although the answer from Peter Neubauer / neotechnology is 
>>>>>> accommodating on this matter and seems to indicate *they* might 
>>>>>> think this is not a problem, reading the AGPL [1] license tells 
>>>>>> me
>> something differently.
>>>>>> I definitely would like this contribution to be acceptable, but 
>>>>>> we must be very sure we're not opening a can of worms here.
>>>>>>
>>>>>>>
>>>>>>> I agree that legal should be consulted if we intent to ship a 
>>>>>>> war or other archive with any neo4j (or other agpl) licensed 
>>>>>>> binaries
>> included.
>>>>>> I don't think we can do that anyway. AGPL is a variant of GPL, 
>>>>>> and we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>>>
>>>>>>>
>>>>>>> As a first mitigation step, why don't we make this a separate 
>>>>>>> maven module and only ship the source and non-inclusive jar?  It 
>>>>>>> should not be a problem to ship a jar and source that only 
>>>>>>> references the neo4j libs as runtime dependencies.
>>>>>> That might be a possibility to investigate. As Chris noted in 
>>>>>> another email, it might be doable as Camel seemingly also has a 
>>>>>> neo4j component.
>>>>>>
>>>>>> But also note: it will also depend on the type of reference such 
>>>>>> an optional module uses. If it requires explicit Java imports and 
>>>>>> direct usage of the neo4j APIs, this might qualifies as what is 
>>>>>> called in the AGPL 'Corresponding Source'.
>>>>>> Especially as neo4j and Shindig provide and expect 'Remote 
>>>>>> Network Interaction'
>>>>>> for which the AGPL is especially created to enforce its license 
>>>>>> to downstream users. IMO this can lead to a conflict with the 
>>>>>> AS2.0 license, to possibly not even be allowed distribution under 
>>>>>> that license from within the ASF, or not even its sources be 
>>>>>> checked into svn...
>>>>>>
>>>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>>>
>>>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl 
>>>>>>>> <re...@hof-university.de>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Dear Ate,
>>>>>>>>> thanks for your comments. I already thought about this and 
>>>>>>>>> asked the
>>>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>>>
>>>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code 
>>>>>>>>> binding to GPL
>>>>>>>> code. In runtime, the user will not be shielded from the GPL 
>>>>>>>> core, which means the runtime will have GPL characteristics 
>>>>>>>> when you plug in
>>>>>> Neo4j.
>>>>>>>> That is exactly the intent, and should be ok. The bindings-code 
>>>>>>>> is development-time Apache license, regarding contributions and 
>>>>>>>> copyright etc, so I think this should be ok.
>>>>>>>>>
>>>>>>>>> I'm not quite sure if that answers your question. I can 
>>>>>>>>> further
>>>>>>>> investigate if necessary.
>>>>>>>>> Regards
>>>>>>>>> René
>>>>>>>>>
>>>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>>>> An: dev@shindig.apache.org
>>>>>>>>> Betreff: Re: Review Request: Alternative database backend 
>>>>>>>>> based on graph
>>>>>>>> database neo4j
>>>>>>>>>
>>>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>>>> Normally any database backend access which is abstracted away 
>>>>>>>>> behind
>>>>>>>> 'plain'
>>>>>>>>> JDBC interfaces are allright to use, commercial versions or 
>>>>>>>>> otherwise
>>>>>>>> licensed, because the end-user would have the option to choose 
>>>>>>>> whatever
>>>>>>>> (compatible) database they want to use.
>>>>>>>>>
>>>>>>>>> However with neo4j this seems different. Even with only 
>>>>>>>>> optional support
>>>>>>>> for neo4j, the neo4j integration might require explicit neo4j
>>>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for 
>>>>>>>> this, but if it imports neo4j APIs then their AGPL license can 
>>>>>>>> be too invasive and then possibly not acceptable for uses 
>>>>>>>> within our
>>>>>>>> AL2.0 licensed
>>>>>> codebase.
>>>>>>>>> Or even if that could be allowed, I would make sure to check 
>>>>>>>>> and ask
>>>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy
POV.
>>>>>>>>>
>>>>>>>>> Regards, Ate
>>>>>>>>>
>>>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>>>> This is good news.
>>>>>>>>>>
>>>>>>>>>> One immediate comment is about the package name.
>>>>>>>>>> Would it be possible to put it under org.apache.shindig 
>>>>>>>>>> rather than the de.hofuniversity?
>>>>>>>>>>
>>>>>>>>>> This would make the contributions uniform like from other 
>>>>>>>>>> companies and organizations.
>>>>>>>>>>
>>>>>>>>>> - Henry
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> Review request for shindig.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Description
>>>>>>>>>>> -------
>>>>>>>>>>>
>>>>>>>>>>> Review for Shindig-1911
>>>>>>>>>>> Alternative database backend based on graph database neo4j 
>>>>>>>>>>> Any comments welcome. We are committed to further improve this.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Diffs
>>>>>>>>>>> -----
>>>>>>>>>>>
>>>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>> y
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/Constants.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>> y
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>> y
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>> y
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>> y
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> acke
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@apache.org>.
What does everyone else think?

I think that Rene and team can move forward with their proposal.

On Tue, Jul 23, 2013 at 4:59 PM, René Peinl
<re...@hof-university.de> wrote:
> Hi Ryan,
> yes, I would appreciate your thoughts on our plans.  (see below)
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: René Peinl [mailto:rene.peinl@hof-university.de]
> Gesendet: Montag, 22. Juli 2013 22:41
> An: 'Ryan Baxter'
> Betreff: WG: Review Request: Alternative database backend based on graph
> database neo4j
>
> Hi Ryan,
> maybe you had no time to answer my last email due to the problems with
> Shindig 2.5 but I would be really interested in your opinion on my proposal.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: René Peinl [mailto:rene.peinl@hof-university.de]
> Gesendet: Freitag, 19. Juli 2013 09:41
> An: 'dev@shindig.apache.org'
> Cc: Florian Holzschuher (fholzschuher2@hof-university.de);
> michael.hunger@neotechnology.com
> Betreff: AW: Review Request: Alternative database backend based on graph
> database neo4j
>
> That's still subject to discussion. As you see, we are pursuing two goals:
> contribute to the Shindig project and do some research.
> Our first comparison was between SQL, Cypher, Gremlin and neo4j native API
> regarding speed and maintainability of the code. We found out, that Cypher
> is a good compromise.
> For this next step we want to experiment with different network protocols
> and payload types. In our first comparison, we found out that the existing
> REST interface of neo4j is not performing very well. Neo technologies has
> enhanced it since then, but we envision comparing a Web socket connection
> with the existing http connection and a raw TCP socket connection regarding
> speed. For the payload we are looking at JSON (currently used in neo4j),
> BSON and an own object serialization.
> The last comparison will deal with the commands passed from Shindig to
> neo4j. The obvious choice is Cypher, since this is becoming the default
> language for neo4j, but we also want to experiment with kind of stored
> procedures (not currently supported in neo4j), where we only transfer the
> name of the query and the parameters. The implementation could then be
> Cypher or native api on the neo4j side.
> Any suggestions?
> Regards
> René
> P.S.: Another interesting thing would be to experiment with asynchronous,
> non-blocking database connections, but I guess that doesn't make sense, as
> long as the rest of Shindig uses blocking calls.
>
> -----Ursprüngliche Nachricht-----
> Von: Ryan Baxter [mailto:rbaxter85@apache.org]
> Gesendet: Donnerstag, 18. Juli 2013 22:31
> An: dev@shindig.apache.org
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> Great.  So what technically will the code that is contributed to Shindig do?
> How does it talk to the neo4j backend?
>
> On Thu, Jul 18, 2013 at 9:25 AM, René Peinl <re...@hof-university.de>
> wrote:
>> Dear Ryan,
>> fair question. The main contribution is to allow usage of neo4j as an
>> alternative database backend which improves performance significantly
>> in some areas compared to ORM and MySQL (see
>> http://www.edbt.org/Proceedings/2013-Genova/papers/workshops/a29-holzs
>> chuher
>> .pdf).
>> In addition to that, we have also implemented some of the missing
>> features from Open Social 2.0 like adding friends to the friend
>> network and some additional features not mentioned in the Open Social
>> specification, but state-of-the-art in social networks like friend and
>> group recommendations based on friends in common and groups of friends.
>> The limitation is, that these do only work or are only tested with
>> neo4j backend.
>> Regards
>> René
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Ryan Baxter [mailto:rbaxter85@apache.org]
>> Gesendet: Mittwoch, 17. Juli 2013 02:32
>> An: dev@shindig.apache.org
>> Cc: Ate Douma; Peter Neubauer; Florian Holzschuher
>> Betreff: Re: Review Request: Alternative database backend based on
>> graph database neo4j
>>
>> The split proposal sounds like a good approach, but what exactly would
>> be contributed to Shindig?
>>
>> On Tue, Jul 16, 2013 at 9:46 AM, René Peinl
>> <re...@hof-university.de>
>> wrote:
>>> Dear Ate, dear Shindig developers,
>>> it's been some time since this discussion because we were a bit
>>> frustrated and the project on our side was frozen for some time.
>>> Fortunately, I came up with an idea of how to circumvent this problem
>>> and this time wanted to do the legal check BEFORE we start the coding.
>>>
>>> The current code has a direct compilation dependency on either neo4j
>>> directly or at least their REST/JSON wrapper, which is also GPLv3
>> licensed.
>>> That seems to be the problem.
>>> We therefore propose to split our code into two parts. One part
>>> should become part of the Apache Shindig project and will be licensed
> APLv2.
>>> The other part will directly use neo4j and therefore be licensed
>>> under
>>> GPLv3 and published on sourceforge or somewhere. Between those two
>>> parts there will be only network communication, no compilation
> dependency.
>>>
>>> Could somebody from the core team please confirm, that
>>> a) this new proposal will have no licensing problem (my German
>>> lawyer, who is specialized in OSS licensing confirmed that, but the
>>> ASF may still see it
>>> differently)
>>> b) the community is still interested in the neo4j backend as an
>>> option for Shindig
>>>
>>> Otherwise, we would not invest any more time in this issue.
>>> Regards
>>> René
>>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: Ate Douma [mailto:ate@douma.nu]
>>> Gesendet: Mittwoch, 27. März 2013 15:22
>>> An: dev@shindig.apache.org
>>> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
>>> Betreff: Re: Review Request: Alternative database backend based on
>>> graph database neo4j
>>>
>>> Sorry about top posting (and dropping legal-discuss@) but as we
>>> didn't get any feedback yet on the below question from
>>> legal-discuss@, I've dived into it myself a bit further.
>>>
>>> I already came to the conclusion (and discussed this internally with
>>> another ASF
>>> member) that the current proposed contribution which directly uses
>>> Neo4J
>>> GPL3 licensed APIs cannot be allowed, as that (source) dependency
>>> will enforce the
>>> GPL3 license upon this contribution as a whole, optional or not.
>>>
>>> The possible 'workaround' of using a 3rd party library like
>>> spring-data-neo4j
>>> (only) which is ALv2 licensed I am also very doubtful about, because
>>> that library itself has direct usage and dependency on the Neo4J
>>> APIs, so it really is only 'hiding' the same problem.
>>> If this is a correct assumption, and I created an specific JIRA
>>> question [1] for legal-discuss@ for it, then the spring data
>>> 'workaround' is also tainted and not to be allowed either.
>>>
>>> I've also brought this forward to someone at Apache Camel which
>>> intend to (but hasn't yet) release a Camel Neo4J component, and it
>>> looks like they will decide also that Neo4J cannot be supported after
>>> all, at the
>> ASF.
>>>
>>> Pending the resolution of [1], it now seems doubtful to me Apache
>>> Shindig can accept the neo4j support contribution.
>>> If this becomes the case, I see two possible solutions, in preferred
>>> order (besides dropping it):
>>>
>>> a) NeoTechnology provides an additional (probably API only) library
>>> of its own under an ALv2 compatible license, which can be used to
>>> create integrations like these. This would be the most practical and
>>> beneficial solution IMO, similar to for instance the MongoDB (AGPL3
>>> licensed) mongodb-java-driver library which is
>>> ALv2 licensed, see [2].
>>>
>>> b) Provide the Shindig Neo4J support in a separate project outside
>>> the ASF, maybe at Apache Extras [3]. Downside of this of course is
>>> that alignment with Apache Shindig itself will be more difficult and
>>> likely trailing the development @Shindig.
>>>
>>> I'll keep the list noted on any progress or conclusion of [1].
>>>
>>> Regards, Ate
>>>
>>> [1] https://issues.apache.org/jira/browse/LEGAL-162
>>> [2] https://github.com/mongodb/mongo-java-driver
>>> [3] http://community.apache.org/apache-extras/faq.html
>>>
>>> On 03/11/2013 11:09 AM, Ate Douma wrote:
>>>> Now replying again, but to the proper mail address, see inline below.
>>>>
>>>> Cheers, Ate
>>>>
>>>> On 03/11/2013 11:05 AM, Ate Douma wrote:
>>>>> Another forward of an incorrectly addressed email for
>>>>> legal-discuss@
>>>>>
>>>>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>>>>> Also,
>>>>>> keep in mind that only the enterprise components of Neo4j are
>>>>>> AGPL, the community edition, which I believe is the most
>>>>>> interesting part here, is GPL.
>>>>
>>>> That is useful information indeed. Thanks for correcting me in this!
>>>>
>>>> So for this case at hand I assume we only need to consider the
>>>> possibilities to use the GPL3 licensed community edition of neo4j.
>>>>
>>>> The question then is if at the ASF we may reference and explicitly
>>>> use
>>>> GPL3 licensed APIs in our AL2.0 licensed code, in an optional
>>>> module, which also requires these GPL3 libraries at runtime.
>>>> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>>>>
>>>>>>
>>>>>> /peter
>>>>>>
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> /peter neubauer
>>>>>>
>>>>>> G:  neubauer.peter
>>>>>> S:  peter.neubauer
>>>>>> P:  +46 704 106975
>>>>>> L:   http://www.linkedin.com/in/neubauer
>>>>>> T:   @peterneubauer
>>>>>>
>>>>>> Graph database introduction book for the uninitiated -
>>>>>> http://graphdatabases.com Neo4j questions? Please use SO -
>>>>>> http://stackoverflow.com/search?q=neo4j
>>>>>>
>>>>>>
>>>>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
>>> <re...@hof-university.de>wrote:
>>>>>>
>>>>>>> Dear Apache legal advisors, dear Shindig developers, as you can
>>>>>>> see from the discussion below, we have a possible license
>>>>>>> conflict between AGPL and APL v2.
>>>>>>> We want to integrate code that uses neo4j, a graph database which
>>>>>>> is licensed under AGPL, into Shindig. From my perspective it is
>>>>>>> not necessary to include any neo4j binaries nor code, but I'm not
>>>>>>> sure how this affects compilability. Maybe we can only use the
>>>>>>> REST API then and don't offer to run neo4j in embedded mode.
>>>>>>> I'm not a lawyer nor a licensing specialist, so please advise on
>>>>>>> how to proceed. Maybe we can find a workaround that ensures we
>>>>>>> are conforming to the licensing terms and still get the new
>>>>>>> functionality
>>> into Shindig.
>>>>>>> One suggestion that seems a good one was to check how Apache
>>>>>>> Camel deals with this issue.
>>>>>>> Regards and many thanks for clarification in advance René
>>>>>>>
>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>> Gesendet: Montag, 11. März 2013 08:49
>>>>>>> An: dev@shindig.apache.org
>>>>>>> Cc: Peter Neubauer
>>>>>>> Betreff: Re: Review Request: Alternative database backend based
>>>>>>> on graph database neo4j
>>>>>>>
>>>>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>>>>> On Sunday, March 10, 2013, wrote:
>>>>>>>>
>>>>>>>>> Thanks for the insight Ate.
>>>>>>>>>
>>>>>>>>> Rene, I think we should take Ate's suggestion and send an email
>>>>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it
>>>>>>>>> is OK than we continue the discussion about integrating the patch.
>>>>>>>>
>>>>>>>
>>>>>>> Although the answer from Peter Neubauer / neotechnology is
>>>>>>> accommodating on this matter and seems to indicate *they* might
>>>>>>> think this is not a problem, reading the AGPL [1] license tells
>>>>>>> me
>>> something differently.
>>>>>>> I definitely would like this contribution to be acceptable, but
>>>>>>> we must be very sure we're not opening a can of worms here.
>>>>>>>
>>>>>>>>
>>>>>>>> I agree that legal should be consulted if we intent to ship a
>>>>>>>> war or other archive with any neo4j (or other agpl) licensed
>>>>>>>> binaries
>>> included.
>>>>>>> I don't think we can do that anyway. AGPL is a variant of GPL,
>>>>>>> and we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>>>>
>>>>>>>>
>>>>>>>> As a first mitigation step, why don't we make this a separate
>>>>>>>> maven module and only ship the source and non-inclusive jar?  It
>>>>>>>> should not be a problem to ship a jar and source that only
>>>>>>>> references the neo4j libs as runtime dependencies.
>>>>>>> That might be a possibility to investigate. As Chris noted in
>>>>>>> another email, it might be doable as Camel seemingly also has a
>>>>>>> neo4j component.
>>>>>>>
>>>>>>> But also note: it will also depend on the type of reference such
>>>>>>> an optional module uses. If it requires explicit Java imports and
>>>>>>> direct usage of the neo4j APIs, this might qualifies as what is
>>>>>>> called in the AGPL 'Corresponding Source'.
>>>>>>> Especially as neo4j and Shindig provide and expect 'Remote
>>>>>>> Network Interaction'
>>>>>>> for which the AGPL is especially created to enforce its license
>>>>>>> to downstream users. IMO this can lead to a conflict with the
>>>>>>> AS2.0 license, to possibly not even be allowed distribution under
>>>>>>> that license from within the ASF, or not even its sources be
>>>>>>> checked into svn...
>>>>>>>
>>>>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>>>>
>>>>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl
>>>>>>>>> <re...@hof-university.de>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Dear Ate,
>>>>>>>>>> thanks for your comments. I already thought about this and
>>>>>>>>>> asked the
>>>>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>>>>
>>>>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code
>>>>>>>>>> binding to GPL
>>>>>>>>> code. In runtime, the user will not be shielded from the GPL
>>>>>>>>> core, which means the runtime will have GPL characteristics
>>>>>>>>> when you plug in
>>>>>>> Neo4j.
>>>>>>>>> That is exactly the intent, and should be ok. The bindings-code
>>>>>>>>> is development-time Apache license, regarding contributions and
>>>>>>>>> copyright etc, so I think this should be ok.
>>>>>>>>>>
>>>>>>>>>> I'm not quite sure if that answers your question. I can
>>>>>>>>>> further
>>>>>>>>> investigate if necessary.
>>>>>>>>>> Regards
>>>>>>>>>> René
>>>>>>>>>>
>>>>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>>>>> An: dev@shindig.apache.org
>>>>>>>>>> Betreff: Re: Review Request: Alternative database backend
>>>>>>>>>> based on graph
>>>>>>>>> database neo4j
>>>>>>>>>>
>>>>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>>>>> Normally any database backend access which is abstracted away
>>>>>>>>>> behind
>>>>>>>>> 'plain'
>>>>>>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>>>>>>> otherwise
>>>>>>>>> licensed, because the end-user would have the option to choose
>>>>>>>>> whatever
>>>>>>>>> (compatible) database they want to use.
>>>>>>>>>>
>>>>>>>>>> However with neo4j this seems different. Even with only
>>>>>>>>>> optional support
>>>>>>>>> for neo4j, the neo4j integration might require explicit neo4j
>>>>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for
>>>>>>>>> this, but if it imports neo4j APIs then their AGPL license can
>>>>>>>>> be too invasive and then possibly not acceptable for uses
>>>>>>>>> within our
>>>>>>>>> AL2.0 licensed
>>>>>>> codebase.
>>>>>>>>>> Or even if that could be allowed, I would make sure to check
>>>>>>>>>> and ask
>>>>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy
> POV.
>>>>>>>>>>
>>>>>>>>>> Regards, Ate
>>>>>>>>>>
>>>>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>>>>> This is good news.
>>>>>>>>>>>
>>>>>>>>>>> One immediate comment is about the package name.
>>>>>>>>>>> Would it be possible to put it under org.apache.shindig
>>>>>>>>>>> rather than the de.hofuniversity?
>>>>>>>>>>>
>>>>>>>>>>> This would make the contributions uniform like from other
>>>>>>>>>>> companies and organizations.
>>>>>>>>>>>
>>>>>>>>>>> - Henry
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>>>
>>>>>>>>>>>> Review request for shindig.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Description
>>>>>>>>>>>> -------
>>>>>>>>>>>>
>>>>>>>>>>>> Review for Shindig-1911
>>>>>>>>>>>> Alternative database backend based on graph database neo4j
>>>>>>>>>>>> Any comments welcome. We are committed to further improve this.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Diffs
>>>>>>>>>>>> -----
>>>>>>>>>>>>
>>>>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>>>>
>>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>>> y
>>>>>>>>>>>> s
>>>>>>>>>>>> /gra
>>>>>>>>>>>> phb
>>>>>>>>>>>> ackend/Constants.java
>>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>>
>>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>>> y
>>>>>>>>>>>> s
>>>>>>>>>>>> /gra
>>>>>>>>>>>> phb
>>>>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>>
>>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>>> y
>>>>>>>>>>>> s
>>>>>>>>>>>> /gra
>>>>>>>>>>>> phb
>>>>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>>
>>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>>> y
>>>>>>>>>>>> s
>>>>>>>>>>>> /gra
>>>>>>>>>>>> phb
>>>>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>>
>>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iis
>>>>>>>>>>>> y
>>>>>>>>>>>> s
>>>>>>>>>>>> /gra
>>>>>>>>>>>> phb
>>>>>>>>>>>> acke
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>

Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@apache.org>.
Great.  So what technically will the code that is contributed to
Shindig do?  How does it talk to the neo4j backend?

On Thu, Jul 18, 2013 at 9:25 AM, René Peinl
<re...@hof-university.de> wrote:
> Dear Ryan,
> fair question. The main contribution is to allow usage of neo4j as an
> alternative database backend which improves performance significantly in
> some areas compared to ORM and MySQL (see
> http://www.edbt.org/Proceedings/2013-Genova/papers/workshops/a29-holzschuher
> .pdf).
> In addition to that, we have also implemented some of the missing features
> from Open Social 2.0 like adding friends to the friend network and some
> additional features not mentioned in the Open Social specification, but
> state-of-the-art in social networks like friend and group recommendations
> based on friends in common and groups of friends.
> The limitation is, that these do only work or are only tested with neo4j
> backend.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ryan Baxter [mailto:rbaxter85@apache.org]
> Gesendet: Mittwoch, 17. Juli 2013 02:32
> An: dev@shindig.apache.org
> Cc: Ate Douma; Peter Neubauer; Florian Holzschuher
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> The split proposal sounds like a good approach, but what exactly would be
> contributed to Shindig?
>
> On Tue, Jul 16, 2013 at 9:46 AM, René Peinl <re...@hof-university.de>
> wrote:
>> Dear Ate, dear Shindig developers,
>> it's been some time since this discussion because we were a bit
>> frustrated and the project on our side was frozen for some time.
>> Fortunately, I came up with an idea of how to circumvent this problem
>> and this time wanted to do the legal check BEFORE we start the coding.
>>
>> The current code has a direct compilation dependency on either neo4j
>> directly or at least their REST/JSON wrapper, which is also GPLv3
> licensed.
>> That seems to be the problem.
>> We therefore propose to split our code into two parts. One part should
>> become part of the Apache Shindig project and will be licensed APLv2.
>> The other part will directly use neo4j and therefore be licensed under
>> GPLv3 and published on sourceforge or somewhere. Between those two
>> parts there will be only network communication, no compilation dependency.
>>
>> Could somebody from the core team please confirm, that
>> a) this new proposal will have no licensing problem (my German lawyer,
>> who is specialized in OSS licensing confirmed that, but the ASF may
>> still see it
>> differently)
>> b) the community is still interested in the neo4j backend as an option
>> for Shindig
>>
>> Otherwise, we would not invest any more time in this issue.
>> Regards
>> René
>>
>> -----Ursprüngliche Nachricht-----
>> Von: Ate Douma [mailto:ate@douma.nu]
>> Gesendet: Mittwoch, 27. März 2013 15:22
>> An: dev@shindig.apache.org
>> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
>> Betreff: Re: Review Request: Alternative database backend based on
>> graph database neo4j
>>
>> Sorry about top posting (and dropping legal-discuss@) but as we didn't
>> get any feedback yet on the below question from legal-discuss@, I've
>> dived into it myself a bit further.
>>
>> I already came to the conclusion (and discussed this internally with
>> another ASF
>> member) that the current proposed contribution which directly uses
>> Neo4J
>> GPL3 licensed APIs cannot be allowed, as that (source) dependency will
>> enforce the
>> GPL3 license upon this contribution as a whole, optional or not.
>>
>> The possible 'workaround' of using a 3rd party library like
>> spring-data-neo4j
>> (only) which is ALv2 licensed I am also very doubtful about, because
>> that library itself has direct usage and dependency on the Neo4J APIs,
>> so it really is only 'hiding' the same problem.
>> If this is a correct assumption, and I created an specific JIRA
>> question [1] for legal-discuss@ for it, then the spring data
>> 'workaround' is also tainted and not to be allowed either.
>>
>> I've also brought this forward to someone at Apache Camel which intend
>> to (but hasn't yet) release a Camel Neo4J component, and it looks like
>> they will decide also that Neo4J cannot be supported after all, at the
> ASF.
>>
>> Pending the resolution of [1], it now seems doubtful to me Apache
>> Shindig can accept the neo4j support contribution.
>> If this becomes the case, I see two possible solutions, in preferred
>> order (besides dropping it):
>>
>> a) NeoTechnology provides an additional (probably API only) library of
>> its own under an ALv2 compatible license, which can be used to create
>> integrations like these. This would be the most practical and
>> beneficial solution IMO, similar to for instance the MongoDB (AGPL3
>> licensed) mongodb-java-driver library which is
>> ALv2 licensed, see [2].
>>
>> b) Provide the Shindig Neo4J support in a separate project outside the
>> ASF, maybe at Apache Extras [3]. Downside of this of course is that
>> alignment with Apache Shindig itself will be more difficult and likely
>> trailing the development @Shindig.
>>
>> I'll keep the list noted on any progress or conclusion of [1].
>>
>> Regards, Ate
>>
>> [1] https://issues.apache.org/jira/browse/LEGAL-162
>> [2] https://github.com/mongodb/mongo-java-driver
>> [3] http://community.apache.org/apache-extras/faq.html
>>
>> On 03/11/2013 11:09 AM, Ate Douma wrote:
>>> Now replying again, but to the proper mail address, see inline below.
>>>
>>> Cheers, Ate
>>>
>>> On 03/11/2013 11:05 AM, Ate Douma wrote:
>>>> Another forward of an incorrectly addressed email for legal-discuss@
>>>>
>>>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>>>> Also,
>>>>> keep in mind that only the enterprise components of Neo4j are AGPL,
>>>>> the community edition, which I believe is the most interesting part
>>>>> here, is GPL.
>>>
>>> That is useful information indeed. Thanks for correcting me in this!
>>>
>>> So for this case at hand I assume we only need to consider the
>>> possibilities to use the GPL3 licensed community edition of neo4j.
>>>
>>> The question then is if at the ASF we may reference and explicitly
>>> use
>>> GPL3 licensed APIs in our AL2.0 licensed code, in an optional module,
>>> which also requires these GPL3 libraries at runtime.
>>> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>>>
>>>>>
>>>>> /peter
>>>>>
>>>>>
>>>>> Cheers,
>>>>>
>>>>> /peter neubauer
>>>>>
>>>>> G:  neubauer.peter
>>>>> S:  peter.neubauer
>>>>> P:  +46 704 106975
>>>>> L:   http://www.linkedin.com/in/neubauer
>>>>> T:   @peterneubauer
>>>>>
>>>>> Graph database introduction book for the uninitiated -
>>>>> http://graphdatabases.com Neo4j questions? Please use SO -
>>>>> http://stackoverflow.com/search?q=neo4j
>>>>>
>>>>>
>>>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
>> <re...@hof-university.de>wrote:
>>>>>
>>>>>> Dear Apache legal advisors, dear Shindig developers, as you can
>>>>>> see from the discussion below, we have a possible license conflict
>>>>>> between AGPL and APL v2.
>>>>>> We want to integrate code that uses neo4j, a graph database which
>>>>>> is licensed under AGPL, into Shindig. From my perspective it is
>>>>>> not necessary to include any neo4j binaries nor code, but I'm not
>>>>>> sure how this affects compilability. Maybe we can only use the
>>>>>> REST API then and don't offer to run neo4j in embedded mode.
>>>>>> I'm not a lawyer nor a licensing specialist, so please advise on
>>>>>> how to proceed. Maybe we can find a workaround that ensures we are
>>>>>> conforming to the licensing terms and still get the new
>>>>>> functionality
>> into Shindig.
>>>>>> One suggestion that seems a good one was to check how Apache Camel
>>>>>> deals with this issue.
>>>>>> Regards and many thanks for clarification in advance René
>>>>>>
>>>>>> -----Ursprüngliche Nachricht-----
>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>> Gesendet: Montag, 11. März 2013 08:49
>>>>>> An: dev@shindig.apache.org
>>>>>> Cc: Peter Neubauer
>>>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>>>> graph database neo4j
>>>>>>
>>>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>>>> On Sunday, March 10, 2013, wrote:
>>>>>>>
>>>>>>>> Thanks for the insight Ate.
>>>>>>>>
>>>>>>>> Rene, I think we should take Ate's suggestion and send an email
>>>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it
>>>>>>>> is OK than we continue the discussion about integrating the patch.
>>>>>>>
>>>>>>
>>>>>> Although the answer from Peter Neubauer / neotechnology is
>>>>>> accommodating on this matter and seems to indicate *they* might
>>>>>> think this is not a problem, reading the AGPL [1] license tells me
>> something differently.
>>>>>> I definitely would like this contribution to be acceptable, but we
>>>>>> must be very sure we're not opening a can of worms here.
>>>>>>
>>>>>>>
>>>>>>> I agree that legal should be consulted if we intent to ship a war
>>>>>>> or other archive with any neo4j (or other agpl) licensed binaries
>> included.
>>>>>> I don't think we can do that anyway. AGPL is a variant of GPL, and
>>>>>> we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>>>
>>>>>>>
>>>>>>> As a first mitigation step, why don't we make this a separate
>>>>>>> maven module and only ship the source and non-inclusive jar?  It
>>>>>>> should not be a problem to ship a jar and source that only
>>>>>>> references the neo4j libs as runtime dependencies.
>>>>>> That might be a possibility to investigate. As Chris noted in
>>>>>> another email, it might be doable as Camel seemingly also has a
>>>>>> neo4j component.
>>>>>>
>>>>>> But also note: it will also depend on the type of reference such
>>>>>> an optional module uses. If it requires explicit Java imports and
>>>>>> direct usage of the neo4j APIs, this might qualifies as what is
>>>>>> called in the AGPL 'Corresponding Source'.
>>>>>> Especially as neo4j and Shindig provide and expect 'Remote Network
>>>>>> Interaction'
>>>>>> for which the AGPL is especially created to enforce its license to
>>>>>> downstream users. IMO this can lead to a conflict with the AS2.0
>>>>>> license, to possibly not even be allowed distribution under that
>>>>>> license from within the ASF, or not even its sources be checked
>>>>>> into svn...
>>>>>>
>>>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>>>
>>>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl
>>>>>>>> <re...@hof-university.de>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Dear Ate,
>>>>>>>>> thanks for your comments. I already thought about this and
>>>>>>>>> asked the
>>>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>>>
>>>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code
>>>>>>>>> binding to GPL
>>>>>>>> code. In runtime, the user will not be shielded from the GPL
>>>>>>>> core, which means the runtime will have GPL characteristics when
>>>>>>>> you plug in
>>>>>> Neo4j.
>>>>>>>> That is exactly the intent, and should be ok. The bindings-code
>>>>>>>> is development-time Apache license, regarding contributions and
>>>>>>>> copyright etc, so I think this should be ok.
>>>>>>>>>
>>>>>>>>> I'm not quite sure if that answers your question. I can further
>>>>>>>> investigate if necessary.
>>>>>>>>> Regards
>>>>>>>>> René
>>>>>>>>>
>>>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>>>> An: dev@shindig.apache.org
>>>>>>>>> Betreff: Re: Review Request: Alternative database backend based
>>>>>>>>> on graph
>>>>>>>> database neo4j
>>>>>>>>>
>>>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>>>> Normally any database backend access which is abstracted away
>>>>>>>>> behind
>>>>>>>> 'plain'
>>>>>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>>>>>> otherwise
>>>>>>>> licensed, because the end-user would have the option to choose
>>>>>>>> whatever
>>>>>>>> (compatible) database they want to use.
>>>>>>>>>
>>>>>>>>> However with neo4j this seems different. Even with only
>>>>>>>>> optional support
>>>>>>>> for neo4j, the neo4j integration might require explicit neo4j
>>>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for
>>>>>>>> this, but if it imports neo4j APIs then their AGPL license can
>>>>>>>> be too invasive and then possibly not acceptable for uses within
>>>>>>>> our
>>>>>>>> AL2.0 licensed
>>>>>> codebase.
>>>>>>>>> Or even if that could be allowed, I would make sure to check
>>>>>>>>> and ask
>>>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>>>>
>>>>>>>>> Regards, Ate
>>>>>>>>>
>>>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>>>> This is good news.
>>>>>>>>>>
>>>>>>>>>> One immediate comment is about the package name.
>>>>>>>>>> Would it be possible to put it under org.apache.shindig rather
>>>>>>>>>> than the de.hofuniversity?
>>>>>>>>>>
>>>>>>>>>> This would make the contributions uniform like from other
>>>>>>>>>> companies and organizations.
>>>>>>>>>>
>>>>>>>>>> - Henry
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> Review request for shindig.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Description
>>>>>>>>>>> -------
>>>>>>>>>>>
>>>>>>>>>>> Review for Shindig-1911
>>>>>>>>>>> Alternative database backend based on graph database neo4j
>>>>>>>>>>> Any comments welcome. We are committed to further improve this.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Diffs
>>>>>>>>>>> -----
>>>>>>>>>>>
>>>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/Constants.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>>>> PRE-CREATION
>>>>>>>>>>>
>>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>>> s
>>>>>>>>>>> /gra
>>>>>>>>>>> phb
>>>>>>>>>>> acke
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>

AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
Dear Ryan,
fair question. The main contribution is to allow usage of neo4j as an
alternative database backend which improves performance significantly in
some areas compared to ORM and MySQL (see
http://www.edbt.org/Proceedings/2013-Genova/papers/workshops/a29-holzschuher
.pdf). 
In addition to that, we have also implemented some of the missing features
from Open Social 2.0 like adding friends to the friend network and some
additional features not mentioned in the Open Social specification, but
state-of-the-art in social networks like friend and group recommendations
based on friends in common and groups of friends.
The limitation is, that these do only work or are only tested with neo4j
backend.
Regards
René 

-----Ursprüngliche Nachricht-----
Von: Ryan Baxter [mailto:rbaxter85@apache.org] 
Gesendet: Mittwoch, 17. Juli 2013 02:32
An: dev@shindig.apache.org
Cc: Ate Douma; Peter Neubauer; Florian Holzschuher
Betreff: Re: Review Request: Alternative database backend based on graph
database neo4j

The split proposal sounds like a good approach, but what exactly would be
contributed to Shindig?

On Tue, Jul 16, 2013 at 9:46 AM, René Peinl <re...@hof-university.de>
wrote:
> Dear Ate, dear Shindig developers,
> it's been some time since this discussion because we were a bit 
> frustrated and the project on our side was frozen for some time. 
> Fortunately, I came up with an idea of how to circumvent this problem 
> and this time wanted to do the legal check BEFORE we start the coding.
>
> The current code has a direct compilation dependency on either neo4j 
> directly or at least their REST/JSON wrapper, which is also GPLv3
licensed.
> That seems to be the problem.
> We therefore propose to split our code into two parts. One part should 
> become part of the Apache Shindig project and will be licensed APLv2. 
> The other part will directly use neo4j and therefore be licensed under 
> GPLv3 and published on sourceforge or somewhere. Between those two 
> parts there will be only network communication, no compilation dependency.
>
> Could somebody from the core team please confirm, that
> a) this new proposal will have no licensing problem (my German lawyer, 
> who is specialized in OSS licensing confirmed that, but the ASF may 
> still see it
> differently)
> b) the community is still interested in the neo4j backend as an option 
> for Shindig
>
> Otherwise, we would not invest any more time in this issue.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu]
> Gesendet: Mittwoch, 27. März 2013 15:22
> An: dev@shindig.apache.org
> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
> Betreff: Re: Review Request: Alternative database backend based on 
> graph database neo4j
>
> Sorry about top posting (and dropping legal-discuss@) but as we didn't 
> get any feedback yet on the below question from legal-discuss@, I've 
> dived into it myself a bit further.
>
> I already came to the conclusion (and discussed this internally with 
> another ASF
> member) that the current proposed contribution which directly uses 
> Neo4J
> GPL3 licensed APIs cannot be allowed, as that (source) dependency will 
> enforce the
> GPL3 license upon this contribution as a whole, optional or not.
>
> The possible 'workaround' of using a 3rd party library like 
> spring-data-neo4j
> (only) which is ALv2 licensed I am also very doubtful about, because 
> that library itself has direct usage and dependency on the Neo4J APIs, 
> so it really is only 'hiding' the same problem.
> If this is a correct assumption, and I created an specific JIRA 
> question [1] for legal-discuss@ for it, then the spring data 
> 'workaround' is also tainted and not to be allowed either.
>
> I've also brought this forward to someone at Apache Camel which intend 
> to (but hasn't yet) release a Camel Neo4J component, and it looks like 
> they will decide also that Neo4J cannot be supported after all, at the
ASF.
>
> Pending the resolution of [1], it now seems doubtful to me Apache 
> Shindig can accept the neo4j support contribution.
> If this becomes the case, I see two possible solutions, in preferred 
> order (besides dropping it):
>
> a) NeoTechnology provides an additional (probably API only) library of 
> its own under an ALv2 compatible license, which can be used to create 
> integrations like these. This would be the most practical and 
> beneficial solution IMO, similar to for instance the MongoDB (AGPL3 
> licensed) mongodb-java-driver library which is
> ALv2 licensed, see [2].
>
> b) Provide the Shindig Neo4J support in a separate project outside the 
> ASF, maybe at Apache Extras [3]. Downside of this of course is that 
> alignment with Apache Shindig itself will be more difficult and likely 
> trailing the development @Shindig.
>
> I'll keep the list noted on any progress or conclusion of [1].
>
> Regards, Ate
>
> [1] https://issues.apache.org/jira/browse/LEGAL-162
> [2] https://github.com/mongodb/mongo-java-driver
> [3] http://community.apache.org/apache-extras/faq.html
>
> On 03/11/2013 11:09 AM, Ate Douma wrote:
>> Now replying again, but to the proper mail address, see inline below.
>>
>> Cheers, Ate
>>
>> On 03/11/2013 11:05 AM, Ate Douma wrote:
>>> Another forward of an incorrectly addressed email for legal-discuss@
>>>
>>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>>> Also,
>>>> keep in mind that only the enterprise components of Neo4j are AGPL, 
>>>> the community edition, which I believe is the most interesting part 
>>>> here, is GPL.
>>
>> That is useful information indeed. Thanks for correcting me in this!
>>
>> So for this case at hand I assume we only need to consider the 
>> possibilities to use the GPL3 licensed community edition of neo4j.
>>
>> The question then is if at the ASF we may reference and explicitly 
>> use
>> GPL3 licensed APIs in our AL2.0 licensed code, in an optional module, 
>> which also requires these GPL3 libraries at runtime.
>> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>>
>>>>
>>>> /peter
>>>>
>>>>
>>>> Cheers,
>>>>
>>>> /peter neubauer
>>>>
>>>> G:  neubauer.peter
>>>> S:  peter.neubauer
>>>> P:  +46 704 106975
>>>> L:   http://www.linkedin.com/in/neubauer
>>>> T:   @peterneubauer
>>>>
>>>> Graph database introduction book for the uninitiated - 
>>>> http://graphdatabases.com Neo4j questions? Please use SO - 
>>>> http://stackoverflow.com/search?q=neo4j
>>>>
>>>>
>>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
> <re...@hof-university.de>wrote:
>>>>
>>>>> Dear Apache legal advisors, dear Shindig developers, as you can 
>>>>> see from the discussion below, we have a possible license conflict 
>>>>> between AGPL and APL v2.
>>>>> We want to integrate code that uses neo4j, a graph database which 
>>>>> is licensed under AGPL, into Shindig. From my perspective it is 
>>>>> not necessary to include any neo4j binaries nor code, but I'm not 
>>>>> sure how this affects compilability. Maybe we can only use the 
>>>>> REST API then and don't offer to run neo4j in embedded mode.
>>>>> I'm not a lawyer nor a licensing specialist, so please advise on 
>>>>> how to proceed. Maybe we can find a workaround that ensures we are 
>>>>> conforming to the licensing terms and still get the new 
>>>>> functionality
> into Shindig.
>>>>> One suggestion that seems a good one was to check how Apache Camel 
>>>>> deals with this issue.
>>>>> Regards and many thanks for clarification in advance René
>>>>>
>>>>> -----Ursprüngliche Nachricht-----
>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>> Gesendet: Montag, 11. März 2013 08:49
>>>>> An: dev@shindig.apache.org
>>>>> Cc: Peter Neubauer
>>>>> Betreff: Re: Review Request: Alternative database backend based on 
>>>>> graph database neo4j
>>>>>
>>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>>> On Sunday, March 10, 2013, wrote:
>>>>>>
>>>>>>> Thanks for the insight Ate.
>>>>>>>
>>>>>>> Rene, I think we should take Ate's suggestion and send an email 
>>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it 
>>>>>>> is OK than we continue the discussion about integrating the patch.
>>>>>>
>>>>>
>>>>> Although the answer from Peter Neubauer / neotechnology is 
>>>>> accommodating on this matter and seems to indicate *they* might 
>>>>> think this is not a problem, reading the AGPL [1] license tells me
> something differently.
>>>>> I definitely would like this contribution to be acceptable, but we 
>>>>> must be very sure we're not opening a can of worms here.
>>>>>
>>>>>>
>>>>>> I agree that legal should be consulted if we intent to ship a war 
>>>>>> or other archive with any neo4j (or other agpl) licensed binaries
> included.
>>>>> I don't think we can do that anyway. AGPL is a variant of GPL, and 
>>>>> we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>>
>>>>>>
>>>>>> As a first mitigation step, why don't we make this a separate 
>>>>>> maven module and only ship the source and non-inclusive jar?  It 
>>>>>> should not be a problem to ship a jar and source that only 
>>>>>> references the neo4j libs as runtime dependencies.
>>>>> That might be a possibility to investigate. As Chris noted in 
>>>>> another email, it might be doable as Camel seemingly also has a 
>>>>> neo4j component.
>>>>>
>>>>> But also note: it will also depend on the type of reference such 
>>>>> an optional module uses. If it requires explicit Java imports and 
>>>>> direct usage of the neo4j APIs, this might qualifies as what is 
>>>>> called in the AGPL 'Corresponding Source'.
>>>>> Especially as neo4j and Shindig provide and expect 'Remote Network 
>>>>> Interaction'
>>>>> for which the AGPL is especially created to enforce its license to 
>>>>> downstream users. IMO this can lead to a conflict with the AS2.0 
>>>>> license, to possibly not even be allowed distribution under that 
>>>>> license from within the ASF, or not even its sources be checked 
>>>>> into svn...
>>>>>
>>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>>
>>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl 
>>>>>>> <re...@hof-university.de>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Dear Ate,
>>>>>>>> thanks for your comments. I already thought about this and 
>>>>>>>> asked the
>>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>>
>>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code 
>>>>>>>> binding to GPL
>>>>>>> code. In runtime, the user will not be shielded from the GPL 
>>>>>>> core, which means the runtime will have GPL characteristics when 
>>>>>>> you plug in
>>>>> Neo4j.
>>>>>>> That is exactly the intent, and should be ok. The bindings-code 
>>>>>>> is development-time Apache license, regarding contributions and 
>>>>>>> copyright etc, so I think this should be ok.
>>>>>>>>
>>>>>>>> I'm not quite sure if that answers your question. I can further
>>>>>>> investigate if necessary.
>>>>>>>> Regards
>>>>>>>> René
>>>>>>>>
>>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>>> An: dev@shindig.apache.org
>>>>>>>> Betreff: Re: Review Request: Alternative database backend based 
>>>>>>>> on graph
>>>>>>> database neo4j
>>>>>>>>
>>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>>> Normally any database backend access which is abstracted away 
>>>>>>>> behind
>>>>>>> 'plain'
>>>>>>>> JDBC interfaces are allright to use, commercial versions or 
>>>>>>>> otherwise
>>>>>>> licensed, because the end-user would have the option to choose 
>>>>>>> whatever
>>>>>>> (compatible) database they want to use.
>>>>>>>>
>>>>>>>> However with neo4j this seems different. Even with only 
>>>>>>>> optional support
>>>>>>> for neo4j, the neo4j integration might require explicit neo4j
>>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for 
>>>>>>> this, but if it imports neo4j APIs then their AGPL license can 
>>>>>>> be too invasive and then possibly not acceptable for uses within 
>>>>>>> our
>>>>>>> AL2.0 licensed
>>>>> codebase.
>>>>>>>> Or even if that could be allowed, I would make sure to check 
>>>>>>>> and ask
>>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>>>
>>>>>>>> Regards, Ate
>>>>>>>>
>>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>>> This is good news.
>>>>>>>>>
>>>>>>>>> One immediate comment is about the package name.
>>>>>>>>> Would it be possible to put it under org.apache.shindig rather 
>>>>>>>>> than the de.hofuniversity?
>>>>>>>>>
>>>>>>>>> This would make the contributions uniform like from other 
>>>>>>>>> companies and organizations.
>>>>>>>>>
>>>>>>>>> - Henry
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> Review request for shindig.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Description
>>>>>>>>>> -------
>>>>>>>>>>
>>>>>>>>>> Review for Shindig-1911
>>>>>>>>>> Alternative database backend based on graph database neo4j 
>>>>>>>>>> Any comments welcome. We are committed to further improve this.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Diffs
>>>>>>>>>> -----
>>>>>>>>>>
>>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>> s
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/Constants.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>> s
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>> s
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>> s
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisy
>>>>>>>>>> s
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> acke
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>>
>
>
>


Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Matt Franklin <m....@gmail.com>.
On Tue, Jul 16, 2013 at 8:46 AM, René Peinl <re...@hof-university.de>wrote:

> Dear Ate, dear Shindig developers,
> it's been some time since this discussion because we were a bit frustrated
> and the project on our side was frozen for some time. Fortunately, I came
> up
> with an idea of how to circumvent this problem and this time wanted to do
> the legal check BEFORE we start the coding.
>
> The current code has a direct compilation dependency on either neo4j
> directly or at least their REST/JSON wrapper, which is also GPLv3 licensed.
> That seems to be the problem.
> We therefore propose to split our code into two parts. One part should
> become part of the Apache Shindig project and will be licensed APLv2. The
> other part will directly use neo4j and therefore be licensed under GPLv3
> and
> published on sourceforge or somewhere. Between those two parts there will
> be
> only network communication, no compilation dependency.
>
> Could somebody from the core team please confirm, that
> a) this new proposal will have no licensing problem (my German lawyer, who
> is specialized in OSS licensing confirmed that, but the ASF may still see
> it
> differently)
> b) the community is still interested in the neo4j backend as an option for
> Shindig
>

I actually had a conversation with Emil Eifrem from Neo Technologies at a
conference about this subject and we couldn't come to any better proposal
than what you suggest.

As long as there is no reference to the GPL API in the code, I don't
foresee an issue at all.  Ate, do you have any concerns?


>
> Otherwise, we would not invest any more time in this issue.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu]
> Gesendet: Mittwoch, 27. März 2013 15:22
> An: dev@shindig.apache.org
> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> Sorry about top posting (and dropping legal-discuss@) but as we didn't get
> any feedback yet on the below question from legal-discuss@, I've dived
> into
> it myself a bit further.
>
> I already came to the conclusion (and discussed this internally with
> another
> ASF
> member) that the current proposed contribution which directly uses Neo4J
> GPL3 licensed APIs cannot be allowed, as that (source) dependency will
> enforce the
> GPL3 license upon this contribution as a whole, optional or not.
>
> The possible 'workaround' of using a 3rd party library like
> spring-data-neo4j
> (only) which is ALv2 licensed I am also very doubtful about, because that
> library itself has direct usage and dependency on the Neo4J APIs, so it
> really is only 'hiding' the same problem.
> If this is a correct assumption, and I created an specific JIRA question
> [1]
> for legal-discuss@ for it, then the spring data 'workaround' is also
> tainted
> and not to be allowed either.
>
> I've also brought this forward to someone at Apache Camel which intend to
> (but hasn't yet) release a Camel Neo4J component, and it looks like they
> will decide also that Neo4J cannot be supported after all, at the ASF.
>
> Pending the resolution of [1], it now seems doubtful to me Apache Shindig
> can accept the neo4j support contribution.
> If this becomes the case, I see two possible solutions, in preferred order
> (besides dropping it):
>
> a) NeoTechnology provides an additional (probably API only) library of its
> own under an ALv2 compatible license, which can be used to create
> integrations like these. This would be the most practical and beneficial
> solution IMO, similar to for instance the MongoDB (AGPL3 licensed)
> mongodb-java-driver library which is
> ALv2 licensed, see [2].
>
> b) Provide the Shindig Neo4J support in a separate project outside the ASF,
> maybe at Apache Extras [3]. Downside of this of course is that alignment
> with Apache Shindig itself will be more difficult and likely trailing the
> development @Shindig.
>
> I'll keep the list noted on any progress or conclusion of [1].
>
> Regards, Ate
>
> [1] https://issues.apache.org/jira/browse/LEGAL-162
> [2] https://github.com/mongodb/mongo-java-driver
> [3] http://community.apache.org/apache-extras/faq.html
>
> On 03/11/2013 11:09 AM, Ate Douma wrote:
> > Now replying again, but to the proper mail address, see inline below.
> >
> > Cheers, Ate
> >
> > On 03/11/2013 11:05 AM, Ate Douma wrote:
> >> Another forward of an incorrectly addressed email for legal-discuss@
> >>
> >> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
> >>> Also,
> >>> keep in mind that only the enterprise components of Neo4j are AGPL,
> >>> the community edition, which I believe is the most interesting part
> >>> here, is GPL.
> >
> > That is useful information indeed. Thanks for correcting me in this!
> >
> > So for this case at hand I assume we only need to consider the
> > possibilities to use the GPL3 licensed community edition of neo4j.
> >
> > The question then is if at the ASF we may reference and explicitly use
> > GPL3 licensed APIs in our AL2.0 licensed code, in an optional module,
> > which also requires these GPL3 libraries at runtime.
> > Even if we don't distribute those 3rd party GPL3 libraries ourselves.
> >
> >>>
> >>> /peter
> >>>
> >>>
> >>> Cheers,
> >>>
> >>> /peter neubauer
> >>>
> >>> G:  neubauer.peter
> >>> S:  peter.neubauer
> >>> P:  +46 704 106975
> >>> L:   http://www.linkedin.com/in/neubauer
> >>> T:   @peterneubauer
> >>>
> >>> Graph database introduction book for the uninitiated -
> >>> http://graphdatabases.com Neo4j questions? Please use SO -
> >>> http://stackoverflow.com/search?q=neo4j
> >>>
> >>>
> >>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
> <re...@hof-university.de>wrote:
> >>>
> >>>> Dear Apache legal advisors, dear Shindig developers, as you can see
> >>>> from the discussion below, we have a possible license conflict
> >>>> between AGPL and APL v2.
> >>>> We want to integrate code that uses neo4j, a graph database which
> >>>> is licensed under AGPL, into Shindig. From my perspective it is not
> >>>> necessary to include any neo4j binaries nor code, but I'm not sure
> >>>> how this affects compilability. Maybe we can only use the REST API
> >>>> then and don't offer to run neo4j in embedded mode.
> >>>> I'm not a lawyer nor a licensing specialist, so please advise on
> >>>> how to proceed. Maybe we can find a workaround that ensures we are
> >>>> conforming to the licensing terms and still get the new functionality
> into Shindig.
> >>>> One suggestion that seems a good one was to check how Apache Camel
> >>>> deals with this issue.
> >>>> Regards and many thanks for clarification in advance René
> >>>>
> >>>> -----Ursprüngliche Nachricht-----
> >>>> Von: Ate Douma [mailto:ate@douma.nu]
> >>>> Gesendet: Montag, 11. März 2013 08:49
> >>>> An: dev@shindig.apache.org
> >>>> Cc: Peter Neubauer
> >>>> Betreff: Re: Review Request: Alternative database backend based on
> >>>> graph database neo4j
> >>>>
> >>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
> >>>>> On Sunday, March 10, 2013, wrote:
> >>>>>
> >>>>>> Thanks for the insight Ate.
> >>>>>>
> >>>>>> Rene, I think we should take Ate's suggestion and send an email
> >>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it is
> >>>>>> OK than we continue the discussion about integrating the patch.
> >>>>>
> >>>>
> >>>> Although the answer from Peter Neubauer / neotechnology is
> >>>> accommodating on this matter and seems to indicate *they* might
> >>>> think this is not a problem, reading the AGPL [1] license tells me
> something differently.
> >>>> I definitely would like this contribution to be acceptable, but we
> >>>> must be very sure we're not opening a can of worms here.
> >>>>
> >>>>>
> >>>>> I agree that legal should be consulted if we intent to ship a war
> >>>>> or other archive with any neo4j (or other agpl) licensed binaries
> included.
> >>>> I don't think we can do that anyway. AGPL is a variant of GPL, and
> >>>> we're not allowed, by ASF policy, to distribute any GPL artifact.
> >>>>
> >>>>>
> >>>>> As a first mitigation step, why don't we make this a separate
> >>>>> maven module and only ship the source and non-inclusive jar?  It
> >>>>> should not be a problem to ship a jar and source that only
> >>>>> references the neo4j libs as runtime dependencies.
> >>>> That might be a possibility to investigate. As Chris noted in
> >>>> another email, it might be doable as Camel seemingly also has a
> >>>> neo4j component.
> >>>>
> >>>> But also note: it will also depend on the type of reference such an
> >>>> optional module uses. If it requires explicit Java imports and
> >>>> direct usage of the neo4j APIs, this might qualifies as what is
> >>>> called in the AGPL 'Corresponding Source'.
> >>>> Especially as neo4j and Shindig provide and expect 'Remote Network
> >>>> Interaction'
> >>>> for which the AGPL is especially created to enforce its license to
> >>>> downstream users. IMO this can lead to a conflict with the AS2.0
> >>>> license, to possibly not even be allowed distribution under that
> >>>> license from within the ASF, or not even its sources be checked
> >>>> into svn...
> >>>>
> >>>> But IANAL so indeed this should be run through legal-discuss@ first.
> >>>>
> >>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
> >>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl
> >>>>>> <re...@hof-university.de>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Dear Ate,
> >>>>>>> thanks for your comments. I already thought about this and asked
> >>>>>>> the
> >>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
> >>>>>>>
> >>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding
> >>>>>>> to GPL
> >>>>>> code. In runtime, the user will not be shielded from the GPL
> >>>>>> core, which means the runtime will have GPL characteristics when
> >>>>>> you plug in
> >>>> Neo4j.
> >>>>>> That is exactly the intent, and should be ok. The bindings-code
> >>>>>> is development-time Apache license, regarding contributions and
> >>>>>> copyright etc, so I think this should be ok.
> >>>>>>>
> >>>>>>> I'm not quite sure if that answers your question. I can further
> >>>>>> investigate if necessary.
> >>>>>>> Regards
> >>>>>>> René
> >>>>>>>
> >>>>>>> -----Ursprüngliche Nachricht-----
> >>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
> >>>>>>> Gesendet: Freitag, 8. März 2013 14:18
> >>>>>>> An: dev@shindig.apache.org
> >>>>>>> Betreff: Re: Review Request: Alternative database backend based
> >>>>>>> on graph
> >>>>>> database neo4j
> >>>>>>>
> >>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
> >>>>>>> Normally any database backend access which is abstracted away
> >>>>>>> behind
> >>>>>> 'plain'
> >>>>>>> JDBC interfaces are allright to use, commercial versions or
> >>>>>>> otherwise
> >>>>>> licensed, because the end-user would have the option to choose
> >>>>>> whatever
> >>>>>> (compatible) database they want to use.
> >>>>>>>
> >>>>>>> However with neo4j this seems different. Even with only optional
> >>>>>>> support
> >>>>>> for neo4j, the neo4j integration might require explicit neo4j
> >>>>>> (Java) APIs and dependencies? I haven't reviewed the code for
> >>>>>> this, but if it imports neo4j APIs then their AGPL license can be
> >>>>>> too invasive and then possibly not acceptable for uses within our
> >>>>>> AL2.0 licensed
> >>>> codebase.
> >>>>>>> Or even if that could be allowed, I would make sure to check and
> >>>>>>> ask
> >>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy
> POV.
> >>>>>>>
> >>>>>>> Regards, Ate
> >>>>>>>
> >>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
> >>>>>>>> This is good news.
> >>>>>>>>
> >>>>>>>> One immediate comment is about the package name.
> >>>>>>>> Would it be possible to put it under org.apache.shindig rather
> >>>>>>>> than the de.hofuniversity?
> >>>>>>>>
> >>>>>>>> This would make the contributions uniform like from other
> >>>>>>>> companies and organizations.
> >>>>>>>>
> >>>>>>>> - Henry
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
> >>>>>>>>
> >>>>>>>>>
> >>>>>>>>> -----------------------------------------------------------
> >>>>>>>>> This is an automatically generated e-mail. To reply, visit:
> >>>>>>>>> https://reviews.apache.org/r/9773/
> >>>>>>>>> -----------------------------------------------------------
> >>>>>>>>>
> >>>>>>>>> Review request for shindig.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Description
> >>>>>>>>> -------
> >>>>>>>>>
> >>>>>>>>> Review for Shindig-1911
> >>>>>>>>> Alternative database backend based on graph database neo4j Any
> >>>>>>>>> comments welcome. We are committed to further improve this.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> This addresses bug Shindig-1911.
> >>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Diffs
> >>>>>>>>> -----
> >>>>>>>>>
> >>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
> >>>>>>>>>
> >>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
> >>>>>>>>> /gra
> >>>>>>>>> phb
> >>>>>>>>> ackend/Constants.java
> >>>>>>>>> PRE-CREATION
> >>>>>>>>>
> >>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
> >>>>>>>>> /gra
> >>>>>>>>> phb
> >>>>>>>>> ackend/GraphAPIModule.java
> >>>>>>>>> PRE-CREATION
> >>>>>>>>>
> >>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
> >>>>>>>>> /gra
> >>>>>>>>> phb
> >>>>>>>>> ackend/GraphConfig.java
> >>>>>>>>> PRE-CREATION
> >>>>>>>>>
> >>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
> >>>>>>>>> /gra
> >>>>>>>>> phb
> >>>>>>>>> ackend/GuiceModule.java
> >>>>>>>>> PRE-CREATION
> >>>>>>>>>
> >>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
> >>>>>>>>> /gra
> >>>>>>>>> phb
> >>>>>>>>> acke
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >
> >
>
>
>
>

Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ryan Baxter <rb...@apache.org>.
The split proposal sounds like a good approach, but what exactly would
be contributed to Shindig?

On Tue, Jul 16, 2013 at 9:46 AM, René Peinl
<re...@hof-university.de> wrote:
> Dear Ate, dear Shindig developers,
> it's been some time since this discussion because we were a bit frustrated
> and the project on our side was frozen for some time. Fortunately, I came up
> with an idea of how to circumvent this problem and this time wanted to do
> the legal check BEFORE we start the coding.
>
> The current code has a direct compilation dependency on either neo4j
> directly or at least their REST/JSON wrapper, which is also GPLv3 licensed.
> That seems to be the problem.
> We therefore propose to split our code into two parts. One part should
> become part of the Apache Shindig project and will be licensed APLv2. The
> other part will directly use neo4j and therefore be licensed under GPLv3 and
> published on sourceforge or somewhere. Between those two parts there will be
> only network communication, no compilation dependency.
>
> Could somebody from the core team please confirm, that
> a) this new proposal will have no licensing problem (my German lawyer, who
> is specialized in OSS licensing confirmed that, but the ASF may still see it
> differently)
> b) the community is still interested in the neo4j backend as an option for
> Shindig
>
> Otherwise, we would not invest any more time in this issue.
> Regards
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu]
> Gesendet: Mittwoch, 27. März 2013 15:22
> An: dev@shindig.apache.org
> Cc: Peter Neubauer; René Peinl; Florian Holzschuher
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> Sorry about top posting (and dropping legal-discuss@) but as we didn't get
> any feedback yet on the below question from legal-discuss@, I've dived into
> it myself a bit further.
>
> I already came to the conclusion (and discussed this internally with another
> ASF
> member) that the current proposed contribution which directly uses Neo4J
> GPL3 licensed APIs cannot be allowed, as that (source) dependency will
> enforce the
> GPL3 license upon this contribution as a whole, optional or not.
>
> The possible 'workaround' of using a 3rd party library like
> spring-data-neo4j
> (only) which is ALv2 licensed I am also very doubtful about, because that
> library itself has direct usage and dependency on the Neo4J APIs, so it
> really is only 'hiding' the same problem.
> If this is a correct assumption, and I created an specific JIRA question [1]
> for legal-discuss@ for it, then the spring data 'workaround' is also tainted
> and not to be allowed either.
>
> I've also brought this forward to someone at Apache Camel which intend to
> (but hasn't yet) release a Camel Neo4J component, and it looks like they
> will decide also that Neo4J cannot be supported after all, at the ASF.
>
> Pending the resolution of [1], it now seems doubtful to me Apache Shindig
> can accept the neo4j support contribution.
> If this becomes the case, I see two possible solutions, in preferred order
> (besides dropping it):
>
> a) NeoTechnology provides an additional (probably API only) library of its
> own under an ALv2 compatible license, which can be used to create
> integrations like these. This would be the most practical and beneficial
> solution IMO, similar to for instance the MongoDB (AGPL3 licensed)
> mongodb-java-driver library which is
> ALv2 licensed, see [2].
>
> b) Provide the Shindig Neo4J support in a separate project outside the ASF,
> maybe at Apache Extras [3]. Downside of this of course is that alignment
> with Apache Shindig itself will be more difficult and likely trailing the
> development @Shindig.
>
> I'll keep the list noted on any progress or conclusion of [1].
>
> Regards, Ate
>
> [1] https://issues.apache.org/jira/browse/LEGAL-162
> [2] https://github.com/mongodb/mongo-java-driver
> [3] http://community.apache.org/apache-extras/faq.html
>
> On 03/11/2013 11:09 AM, Ate Douma wrote:
>> Now replying again, but to the proper mail address, see inline below.
>>
>> Cheers, Ate
>>
>> On 03/11/2013 11:05 AM, Ate Douma wrote:
>>> Another forward of an incorrectly addressed email for legal-discuss@
>>>
>>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>>> Also,
>>>> keep in mind that only the enterprise components of Neo4j are AGPL,
>>>> the community edition, which I believe is the most interesting part
>>>> here, is GPL.
>>
>> That is useful information indeed. Thanks for correcting me in this!
>>
>> So for this case at hand I assume we only need to consider the
>> possibilities to use the GPL3 licensed community edition of neo4j.
>>
>> The question then is if at the ASF we may reference and explicitly use
>> GPL3 licensed APIs in our AL2.0 licensed code, in an optional module,
>> which also requires these GPL3 libraries at runtime.
>> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>>
>>>>
>>>> /peter
>>>>
>>>>
>>>> Cheers,
>>>>
>>>> /peter neubauer
>>>>
>>>> G:  neubauer.peter
>>>> S:  peter.neubauer
>>>> P:  +46 704 106975
>>>> L:   http://www.linkedin.com/in/neubauer
>>>> T:   @peterneubauer
>>>>
>>>> Graph database introduction book for the uninitiated -
>>>> http://graphdatabases.com Neo4j questions? Please use SO -
>>>> http://stackoverflow.com/search?q=neo4j
>>>>
>>>>
>>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
> <re...@hof-university.de>wrote:
>>>>
>>>>> Dear Apache legal advisors, dear Shindig developers, as you can see
>>>>> from the discussion below, we have a possible license conflict
>>>>> between AGPL and APL v2.
>>>>> We want to integrate code that uses neo4j, a graph database which
>>>>> is licensed under AGPL, into Shindig. From my perspective it is not
>>>>> necessary to include any neo4j binaries nor code, but I'm not sure
>>>>> how this affects compilability. Maybe we can only use the REST API
>>>>> then and don't offer to run neo4j in embedded mode.
>>>>> I'm not a lawyer nor a licensing specialist, so please advise on
>>>>> how to proceed. Maybe we can find a workaround that ensures we are
>>>>> conforming to the licensing terms and still get the new functionality
> into Shindig.
>>>>> One suggestion that seems a good one was to check how Apache Camel
>>>>> deals with this issue.
>>>>> Regards and many thanks for clarification in advance René
>>>>>
>>>>> -----Ursprüngliche Nachricht-----
>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>> Gesendet: Montag, 11. März 2013 08:49
>>>>> An: dev@shindig.apache.org
>>>>> Cc: Peter Neubauer
>>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>>> graph database neo4j
>>>>>
>>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>>> On Sunday, March 10, 2013, wrote:
>>>>>>
>>>>>>> Thanks for the insight Ate.
>>>>>>>
>>>>>>> Rene, I think we should take Ate's suggestion and send an email
>>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it is
>>>>>>> OK than we continue the discussion about integrating the patch.
>>>>>>
>>>>>
>>>>> Although the answer from Peter Neubauer / neotechnology is
>>>>> accommodating on this matter and seems to indicate *they* might
>>>>> think this is not a problem, reading the AGPL [1] license tells me
> something differently.
>>>>> I definitely would like this contribution to be acceptable, but we
>>>>> must be very sure we're not opening a can of worms here.
>>>>>
>>>>>>
>>>>>> I agree that legal should be consulted if we intent to ship a war
>>>>>> or other archive with any neo4j (or other agpl) licensed binaries
> included.
>>>>> I don't think we can do that anyway. AGPL is a variant of GPL, and
>>>>> we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>>
>>>>>>
>>>>>> As a first mitigation step, why don't we make this a separate
>>>>>> maven module and only ship the source and non-inclusive jar?  It
>>>>>> should not be a problem to ship a jar and source that only
>>>>>> references the neo4j libs as runtime dependencies.
>>>>> That might be a possibility to investigate. As Chris noted in
>>>>> another email, it might be doable as Camel seemingly also has a
>>>>> neo4j component.
>>>>>
>>>>> But also note: it will also depend on the type of reference such an
>>>>> optional module uses. If it requires explicit Java imports and
>>>>> direct usage of the neo4j APIs, this might qualifies as what is
>>>>> called in the AGPL 'Corresponding Source'.
>>>>> Especially as neo4j and Shindig provide and expect 'Remote Network
>>>>> Interaction'
>>>>> for which the AGPL is especially created to enforce its license to
>>>>> downstream users. IMO this can lead to a conflict with the AS2.0
>>>>> license, to possibly not even be allowed distribution under that
>>>>> license from within the ASF, or not even its sources be checked
>>>>> into svn...
>>>>>
>>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>>
>>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl
>>>>>>> <re...@hof-university.de>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Dear Ate,
>>>>>>>> thanks for your comments. I already thought about this and asked
>>>>>>>> the
>>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>>
>>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding
>>>>>>>> to GPL
>>>>>>> code. In runtime, the user will not be shielded from the GPL
>>>>>>> core, which means the runtime will have GPL characteristics when
>>>>>>> you plug in
>>>>> Neo4j.
>>>>>>> That is exactly the intent, and should be ok. The bindings-code
>>>>>>> is development-time Apache license, regarding contributions and
>>>>>>> copyright etc, so I think this should be ok.
>>>>>>>>
>>>>>>>> I'm not quite sure if that answers your question. I can further
>>>>>>> investigate if necessary.
>>>>>>>> Regards
>>>>>>>> René
>>>>>>>>
>>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>>> An: dev@shindig.apache.org
>>>>>>>> Betreff: Re: Review Request: Alternative database backend based
>>>>>>>> on graph
>>>>>>> database neo4j
>>>>>>>>
>>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>>> Normally any database backend access which is abstracted away
>>>>>>>> behind
>>>>>>> 'plain'
>>>>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>>>>> otherwise
>>>>>>> licensed, because the end-user would have the option to choose
>>>>>>> whatever
>>>>>>> (compatible) database they want to use.
>>>>>>>>
>>>>>>>> However with neo4j this seems different. Even with only optional
>>>>>>>> support
>>>>>>> for neo4j, the neo4j integration might require explicit neo4j
>>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for
>>>>>>> this, but if it imports neo4j APIs then their AGPL license can be
>>>>>>> too invasive and then possibly not acceptable for uses within our
>>>>>>> AL2.0 licensed
>>>>> codebase.
>>>>>>>> Or even if that could be allowed, I would make sure to check and
>>>>>>>> ask
>>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>>>
>>>>>>>> Regards, Ate
>>>>>>>>
>>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>>> This is good news.
>>>>>>>>>
>>>>>>>>> One immediate comment is about the package name.
>>>>>>>>> Would it be possible to put it under org.apache.shindig rather
>>>>>>>>> than the de.hofuniversity?
>>>>>>>>>
>>>>>>>>> This would make the contributions uniform like from other
>>>>>>>>> companies and organizations.
>>>>>>>>>
>>>>>>>>> - Henry
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> Review request for shindig.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Description
>>>>>>>>>> -------
>>>>>>>>>>
>>>>>>>>>> Review for Shindig-1911
>>>>>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>>>>>> comments welcome. We are committed to further improve this.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Diffs
>>>>>>>>>> -----
>>>>>>>>>>
>>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/Constants.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>>> PRE-CREATION
>>>>>>>>>>
>>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>>> /gra
>>>>>>>>>> phb
>>>>>>>>>> acke
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>>
>
>
>

AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
Dear Ate, dear Shindig developers,
it's been some time since this discussion because we were a bit frustrated
and the project on our side was frozen for some time. Fortunately, I came up
with an idea of how to circumvent this problem and this time wanted to do
the legal check BEFORE we start the coding.

The current code has a direct compilation dependency on either neo4j
directly or at least their REST/JSON wrapper, which is also GPLv3 licensed.
That seems to be the problem. 
We therefore propose to split our code into two parts. One part should
become part of the Apache Shindig project and will be licensed APLv2. The
other part will directly use neo4j and therefore be licensed under GPLv3 and
published on sourceforge or somewhere. Between those two parts there will be
only network communication, no compilation dependency. 

Could somebody from the core team please confirm, that 
a) this new proposal will have no licensing problem (my German lawyer, who
is specialized in OSS licensing confirmed that, but the ASF may still see it
differently)
b) the community is still interested in the neo4j backend as an option for
Shindig

Otherwise, we would not invest any more time in this issue.
Regards
René

-----Ursprüngliche Nachricht-----
Von: Ate Douma [mailto:ate@douma.nu] 
Gesendet: Mittwoch, 27. März 2013 15:22
An: dev@shindig.apache.org
Cc: Peter Neubauer; René Peinl; Florian Holzschuher
Betreff: Re: Review Request: Alternative database backend based on graph
database neo4j

Sorry about top posting (and dropping legal-discuss@) but as we didn't get
any feedback yet on the below question from legal-discuss@, I've dived into
it myself a bit further.

I already came to the conclusion (and discussed this internally with another
ASF
member) that the current proposed contribution which directly uses Neo4J
GPL3 licensed APIs cannot be allowed, as that (source) dependency will
enforce the
GPL3 license upon this contribution as a whole, optional or not.

The possible 'workaround' of using a 3rd party library like
spring-data-neo4j
(only) which is ALv2 licensed I am also very doubtful about, because that
library itself has direct usage and dependency on the Neo4J APIs, so it
really is only 'hiding' the same problem.
If this is a correct assumption, and I created an specific JIRA question [1]
for legal-discuss@ for it, then the spring data 'workaround' is also tainted
and not to be allowed either.

I've also brought this forward to someone at Apache Camel which intend to
(but hasn't yet) release a Camel Neo4J component, and it looks like they
will decide also that Neo4J cannot be supported after all, at the ASF.

Pending the resolution of [1], it now seems doubtful to me Apache Shindig
can accept the neo4j support contribution.
If this becomes the case, I see two possible solutions, in preferred order
(besides dropping it):

a) NeoTechnology provides an additional (probably API only) library of its
own under an ALv2 compatible license, which can be used to create
integrations like these. This would be the most practical and beneficial
solution IMO, similar to for instance the MongoDB (AGPL3 licensed)
mongodb-java-driver library which is
ALv2 licensed, see [2].

b) Provide the Shindig Neo4J support in a separate project outside the ASF,
maybe at Apache Extras [3]. Downside of this of course is that alignment
with Apache Shindig itself will be more difficult and likely trailing the
development @Shindig.

I'll keep the list noted on any progress or conclusion of [1].

Regards, Ate

[1] https://issues.apache.org/jira/browse/LEGAL-162
[2] https://github.com/mongodb/mongo-java-driver
[3] http://community.apache.org/apache-extras/faq.html

On 03/11/2013 11:09 AM, Ate Douma wrote:
> Now replying again, but to the proper mail address, see inline below.
>
> Cheers, Ate
>
> On 03/11/2013 11:05 AM, Ate Douma wrote:
>> Another forward of an incorrectly addressed email for legal-discuss@
>>
>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>> Also,
>>> keep in mind that only the enterprise components of Neo4j are AGPL, 
>>> the community edition, which I believe is the most interesting part 
>>> here, is GPL.
>
> That is useful information indeed. Thanks for correcting me in this!
>
> So for this case at hand I assume we only need to consider the 
> possibilities to use the GPL3 licensed community edition of neo4j.
>
> The question then is if at the ASF we may reference and explicitly use 
> GPL3 licensed APIs in our AL2.0 licensed code, in an optional module, 
> which also requires these GPL3 libraries at runtime.
> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>
>>>
>>> /peter
>>>
>>>
>>> Cheers,
>>>
>>> /peter neubauer
>>>
>>> G:  neubauer.peter
>>> S:  peter.neubauer
>>> P:  +46 704 106975
>>> L:   http://www.linkedin.com/in/neubauer
>>> T:   @peterneubauer
>>>
>>> Graph database introduction book for the uninitiated - 
>>> http://graphdatabases.com Neo4j questions? Please use SO - 
>>> http://stackoverflow.com/search?q=neo4j
>>>
>>>
>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl
<re...@hof-university.de>wrote:
>>>
>>>> Dear Apache legal advisors, dear Shindig developers, as you can see 
>>>> from the discussion below, we have a possible license conflict 
>>>> between AGPL and APL v2.
>>>> We want to integrate code that uses neo4j, a graph database which 
>>>> is licensed under AGPL, into Shindig. From my perspective it is not 
>>>> necessary to include any neo4j binaries nor code, but I'm not sure 
>>>> how this affects compilability. Maybe we can only use the REST API 
>>>> then and don't offer to run neo4j in embedded mode.
>>>> I'm not a lawyer nor a licensing specialist, so please advise on 
>>>> how to proceed. Maybe we can find a workaround that ensures we are 
>>>> conforming to the licensing terms and still get the new functionality
into Shindig.
>>>> One suggestion that seems a good one was to check how Apache Camel 
>>>> deals with this issue.
>>>> Regards and many thanks for clarification in advance René
>>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>> Gesendet: Montag, 11. März 2013 08:49
>>>> An: dev@shindig.apache.org
>>>> Cc: Peter Neubauer
>>>> Betreff: Re: Review Request: Alternative database backend based on 
>>>> graph database neo4j
>>>>
>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>> On Sunday, March 10, 2013, wrote:
>>>>>
>>>>>> Thanks for the insight Ate.
>>>>>>
>>>>>> Rene, I think we should take Ate's suggestion and send an email 
>>>>>> to legal-discussion@ (please CC shindig-dev@).  If they say it is 
>>>>>> OK than we continue the discussion about integrating the patch.
>>>>>
>>>>
>>>> Although the answer from Peter Neubauer / neotechnology is 
>>>> accommodating on this matter and seems to indicate *they* might 
>>>> think this is not a problem, reading the AGPL [1] license tells me
something differently.
>>>> I definitely would like this contribution to be acceptable, but we 
>>>> must be very sure we're not opening a can of worms here.
>>>>
>>>>>
>>>>> I agree that legal should be consulted if we intent to ship a war 
>>>>> or other archive with any neo4j (or other agpl) licensed binaries
included.
>>>> I don't think we can do that anyway. AGPL is a variant of GPL, and 
>>>> we're not allowed, by ASF policy, to distribute any GPL artifact.
>>>>
>>>>>
>>>>> As a first mitigation step, why don't we make this a separate 
>>>>> maven module and only ship the source and non-inclusive jar?  It 
>>>>> should not be a problem to ship a jar and source that only 
>>>>> references the neo4j libs as runtime dependencies.
>>>> That might be a possibility to investigate. As Chris noted in 
>>>> another email, it might be doable as Camel seemingly also has a 
>>>> neo4j component.
>>>>
>>>> But also note: it will also depend on the type of reference such an 
>>>> optional module uses. If it requires explicit Java imports and 
>>>> direct usage of the neo4j APIs, this might qualifies as what is 
>>>> called in the AGPL 'Corresponding Source'.
>>>> Especially as neo4j and Shindig provide and expect 'Remote Network 
>>>> Interaction'
>>>> for which the AGPL is especially created to enforce its license to 
>>>> downstream users. IMO this can lead to a conflict with the AS2.0 
>>>> license, to possibly not even be allowed distribution under that 
>>>> license from within the ASF, or not even its sources be checked 
>>>> into svn...
>>>>
>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>
>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl 
>>>>>> <re...@hof-university.de>
>>>>>> wrote:
>>>>>>
>>>>>>> Dear Ate,
>>>>>>> thanks for your comments. I already thought about this and asked 
>>>>>>> the
>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>
>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding 
>>>>>>> to GPL
>>>>>> code. In runtime, the user will not be shielded from the GPL 
>>>>>> core, which means the runtime will have GPL characteristics when 
>>>>>> you plug in
>>>> Neo4j.
>>>>>> That is exactly the intent, and should be ok. The bindings-code 
>>>>>> is development-time Apache license, regarding contributions and 
>>>>>> copyright etc, so I think this should be ok.
>>>>>>>
>>>>>>> I'm not quite sure if that answers your question. I can further
>>>>>> investigate if necessary.
>>>>>>> Regards
>>>>>>> René
>>>>>>>
>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>> An: dev@shindig.apache.org
>>>>>>> Betreff: Re: Review Request: Alternative database backend based 
>>>>>>> on graph
>>>>>> database neo4j
>>>>>>>
>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>> Normally any database backend access which is abstracted away 
>>>>>>> behind
>>>>>> 'plain'
>>>>>>> JDBC interfaces are allright to use, commercial versions or 
>>>>>>> otherwise
>>>>>> licensed, because the end-user would have the option to choose 
>>>>>> whatever
>>>>>> (compatible) database they want to use.
>>>>>>>
>>>>>>> However with neo4j this seems different. Even with only optional 
>>>>>>> support
>>>>>> for neo4j, the neo4j integration might require explicit neo4j 
>>>>>> (Java) APIs and dependencies? I haven't reviewed the code for 
>>>>>> this, but if it imports neo4j APIs then their AGPL license can be 
>>>>>> too invasive and then possibly not acceptable for uses within our 
>>>>>> AL2.0 licensed
>>>> codebase.
>>>>>>> Or even if that could be allowed, I would make sure to check and 
>>>>>>> ask
>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>>
>>>>>>> Regards, Ate
>>>>>>>
>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>> This is good news.
>>>>>>>>
>>>>>>>> One immediate comment is about the package name.
>>>>>>>> Would it be possible to put it under org.apache.shindig rather 
>>>>>>>> than the de.hofuniversity?
>>>>>>>>
>>>>>>>> This would make the contributions uniform like from other 
>>>>>>>> companies and organizations.
>>>>>>>>
>>>>>>>> - Henry
>>>>>>>>
>>>>>>>>
>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> -----------------------------------------------------------
>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>
>>>>>>>>> Review request for shindig.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Description
>>>>>>>>> -------
>>>>>>>>>
>>>>>>>>> Review for Shindig-1911
>>>>>>>>> Alternative database backend based on graph database neo4j Any 
>>>>>>>>> comments welcome. We are committed to further improve this.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Diffs
>>>>>>>>> -----
>>>>>>>>>
>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>> /gra
>>>>>>>>> phb
>>>>>>>>> ackend/Constants.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>> /gra
>>>>>>>>> phb
>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>> /gra
>>>>>>>>> phb
>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>> /gra
>>>>>>>>> phb
>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys
>>>>>>>>> /gra
>>>>>>>>> phb
>>>>>>>>> acke
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>
>




Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
Sorry about top posting (and dropping legal-discuss@) but as we didn't get any 
feedback yet on the below question from legal-discuss@, I've dived into it 
myself a bit further.

I already came to the conclusion (and discussed this internally with another ASF 
member) that the current proposed contribution which directly uses Neo4J GPL3 
licensed APIs cannot be allowed, as that (source) dependency will enforce the 
GPL3 license upon this contribution as a whole, optional or not.

The possible 'workaround' of using a 3rd party library like spring-data-neo4j 
(only) which is ALv2 licensed I am also very doubtful about, because that 
library itself has direct usage and dependency on the Neo4J APIs, so it really 
is only 'hiding' the same problem.
If this is a correct assumption, and I created an specific JIRA question [1] for 
legal-discuss@ for it, then the spring data 'workaround' is also tainted and not 
to be allowed either.

I've also brought this forward to someone at Apache Camel which intend to (but 
hasn't yet) release a Camel Neo4J component, and it looks like they will decide 
also that Neo4J cannot be supported after all, at the ASF.

Pending the resolution of [1], it now seems doubtful to me Apache Shindig can 
accept the neo4j support contribution.
If this becomes the case, I see two possible solutions, in preferred order 
(besides dropping it):

a) NeoTechnology provides an additional (probably API only) library of its own 
under an ALv2 compatible license, which can be used to create integrations like 
these. This would be the most practical and beneficial solution IMO, similar to 
for instance the MongoDB (AGPL3 licensed) mongodb-java-driver library which is 
ALv2 licensed, see [2].

b) Provide the Shindig Neo4J support in a separate project outside the ASF, 
maybe at Apache Extras [3]. Downside of this of course is that alignment with 
Apache Shindig itself will be more difficult and likely trailing the development 
@Shindig.

I'll keep the list noted on any progress or conclusion of [1].

Regards, Ate

[1] https://issues.apache.org/jira/browse/LEGAL-162
[2] https://github.com/mongodb/mongo-java-driver
[3] http://community.apache.org/apache-extras/faq.html

On 03/11/2013 11:09 AM, Ate Douma wrote:
> Now replying again, but to the proper mail address, see inline below.
>
> Cheers, Ate
>
> On 03/11/2013 11:05 AM, Ate Douma wrote:
>> Another forward of an incorrectly addressed email for legal-discuss@
>>
>> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>>> Also,
>>> keep in mind that only the enterprise components of Neo4j are AGPL, the
>>> community edition, which I believe is the most interesting part here, is
>>> GPL.
>
> That is useful information indeed. Thanks for correcting me in this!
>
> So for this case at hand I assume we only need to consider the possibilities to
> use the GPL3 licensed community edition of neo4j.
>
> The question then is if at the ASF we may reference and explicitly use GPL3
> licensed APIs in our AL2.0 licensed code, in an optional module, which also
> requires these GPL3 libraries at runtime.
> Even if we don't distribute those 3rd party GPL3 libraries ourselves.
>
>>>
>>> /peter
>>>
>>>
>>> Cheers,
>>>
>>> /peter neubauer
>>>
>>> G:  neubauer.peter
>>> S:  peter.neubauer
>>> P:  +46 704 106975
>>> L:   http://www.linkedin.com/in/neubauer
>>> T:   @peterneubauer
>>>
>>> Graph database introduction book for the uninitiated -
>>> http://graphdatabases.com
>>> Neo4j questions? Please use SO - http://stackoverflow.com/search?q=neo4j
>>>
>>>
>>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl <re...@hof-university.de>wrote:
>>>
>>>> Dear Apache legal advisors, dear Shindig developers,
>>>> as you can see from the discussion below, we have a possible license
>>>> conflict between AGPL and APL v2.
>>>> We want to integrate code that uses neo4j, a graph database which is
>>>> licensed under AGPL, into Shindig. From my perspective it is not necessary
>>>> to include any neo4j binaries nor code, but I'm not sure how this affects
>>>> compilability. Maybe we can only use the REST API then and don't offer to
>>>> run neo4j in embedded mode.
>>>> I'm not a lawyer nor a licensing specialist, so please advise on how to
>>>> proceed. Maybe we can find a workaround that ensures we are conforming to
>>>> the licensing terms and still get the new functionality into Shindig.
>>>> One suggestion that seems a good one was to check how Apache Camel deals
>>>> with this issue.
>>>> Regards and many thanks for clarification in advance
>>>> René
>>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>> Gesendet: Montag, 11. März 2013 08:49
>>>> An: dev@shindig.apache.org
>>>> Cc: Peter Neubauer
>>>> Betreff: Re: Review Request: Alternative database backend based on graph
>>>> database neo4j
>>>>
>>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>>> On Sunday, March 10, 2013, wrote:
>>>>>
>>>>>> Thanks for the insight Ate.
>>>>>>
>>>>>> Rene, I think we should take Ate's suggestion and send an email to
>>>>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK
>>>>>> than we continue the discussion about integrating the patch.
>>>>>
>>>>
>>>> Although the answer from Peter Neubauer / neotechnology is accommodating on
>>>> this matter and seems to indicate *they* might think this is not a problem,
>>>> reading the AGPL [1] license tells me something differently.
>>>> I definitely would like this contribution to be acceptable, but we must be
>>>> very sure we're not opening a can of worms here.
>>>>
>>>>>
>>>>> I agree that legal should be consulted if we intent to ship a war or
>>>>> other archive with any neo4j (or other agpl) licensed binaries included.
>>>> I don't think we can do that anyway. AGPL is a variant of GPL, and we're
>>>> not
>>>> allowed, by ASF policy, to distribute any GPL artifact.
>>>>
>>>>>
>>>>> As a first mitigation step, why don't we make this a separate maven
>>>>> module and only ship the source and non-inclusive jar?  It should not
>>>>> be a problem to ship a jar and source that only references the neo4j
>>>>> libs as runtime dependencies.
>>>> That might be a possibility to investigate. As Chris noted in another
>>>> email,
>>>> it might be doable as Camel seemingly also has a neo4j component.
>>>>
>>>> But also note: it will also depend on the type of reference such an
>>>> optional
>>>> module uses. If it requires explicit Java imports and direct usage of the
>>>> neo4j APIs, this might qualifies as what is called in the AGPL
>>>> 'Corresponding Source'.
>>>> Especially as neo4j and Shindig provide and expect 'Remote Network
>>>> Interaction'
>>>> for which the AGPL is especially created to enforce its license to
>>>> downstream users. IMO this can lead to a conflict with the AS2.0 license,
>>>> to
>>>> possibly not even be allowed distribution under that license from within
>>>> the
>>>> ASF, or not even its sources be checked into svn...
>>>>
>>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>>
>>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>>
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>>>>>> wrote:
>>>>>>
>>>>>>> Dear Ate,
>>>>>>> thanks for your comments. I already thought about this and asked the
>>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>>
>>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to
>>>>>>> GPL
>>>>>> code. In runtime, the user will not be shielded from the GPL core,
>>>>>> which means the runtime will have GPL characteristics when you plug in
>>>> Neo4j.
>>>>>> That is exactly the intent, and should be ok. The bindings-code is
>>>>>> development-time Apache license, regarding contributions and
>>>>>> copyright etc, so I think this should be ok.
>>>>>>>
>>>>>>> I'm not quite sure if that answers your question. I can further
>>>>>> investigate if necessary.
>>>>>>> Regards
>>>>>>> René
>>>>>>>
>>>>>>> -----Ursprüngliche Nachricht-----
>>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>>> An: dev@shindig.apache.org
>>>>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>>>>> graph
>>>>>> database neo4j
>>>>>>>
>>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>>> Normally any database backend access which is abstracted away behind
>>>>>> 'plain'
>>>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>>>> otherwise
>>>>>> licensed, because the end-user would have the option to choose
>>>>>> whatever
>>>>>> (compatible) database they want to use.
>>>>>>>
>>>>>>> However with neo4j this seems different. Even with only optional
>>>>>>> support
>>>>>> for neo4j, the neo4j integration might require explicit neo4j (Java)
>>>>>> APIs and dependencies? I haven't reviewed the code for this, but if
>>>>>> it imports neo4j APIs then their AGPL license can be too invasive and
>>>>>> then possibly not acceptable for uses within our AL2.0 licensed
>>>> codebase.
>>>>>>> Or even if that could be allowed, I would make sure to check and ask
>>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>>
>>>>>>> Regards, Ate
>>>>>>>
>>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>>> This is good news.
>>>>>>>>
>>>>>>>> One immediate comment is about the package name.
>>>>>>>> Would it be possible to put it under org.apache.shindig rather than
>>>>>>>> the de.hofuniversity?
>>>>>>>>
>>>>>>>> This would make the contributions uniform like from other companies
>>>>>>>> and organizations.
>>>>>>>>
>>>>>>>> - Henry
>>>>>>>>
>>>>>>>>
>>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> -----------------------------------------------------------
>>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>>> -----------------------------------------------------------
>>>>>>>>>
>>>>>>>>> Review request for shindig.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Description
>>>>>>>>> -------
>>>>>>>>>
>>>>>>>>> Review for Shindig-1911
>>>>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>>>>> comments welcome. We are committed to further improve this.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Diffs
>>>>>>>>> -----
>>>>>>>>>
>>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>>> phb
>>>>>>>>> ackend/Constants.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>>> phb
>>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>>> phb
>>>>>>>>> ackend/GraphConfig.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>>> phb
>>>>>>>>> ackend/GuiceModule.java
>>>>>>>>> PRE-CREATION
>>>>>>>>>
>>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>>> phb
>>>>>>>>> acke
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>
>



Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
Now replying again, but to the proper mail address, see inline below.

Cheers, Ate

On 03/11/2013 11:05 AM, Ate Douma wrote:
> Another forward of an incorrectly addressed email for legal-discuss@
>
> On 03/11/2013 09:41 AM, Peter Neubauer wrote:
>> Also,
>> keep in mind that only the enterprise components of Neo4j are AGPL, the
>> community edition, which I believe is the most interesting part here, is
>> GPL.

That is useful information indeed. Thanks for correcting me in this!

So for this case at hand I assume we only need to consider the possibilities to 
use the GPL3 licensed community edition of neo4j.

The question then is if at the ASF we may reference and explicitly use GPL3 
licensed APIs in our AL2.0 licensed code, in an optional module, which also 
requires these GPL3 libraries at runtime.
Even if we don't distribute those 3rd party GPL3 libraries ourselves.

>>
>> /peter
>>
>>
>> Cheers,
>>
>> /peter neubauer
>>
>> G:  neubauer.peter
>> S:  peter.neubauer
>> P:  +46 704 106975
>> L:   http://www.linkedin.com/in/neubauer
>> T:   @peterneubauer
>>
>> Graph database introduction book for the uninitiated -
>> http://graphdatabases.com
>> Neo4j questions? Please use SO - http://stackoverflow.com/search?q=neo4j
>>
>>
>> On Mon, Mar 11, 2013 at 9:22 AM, René Peinl <re...@hof-university.de>wrote:
>>
>>> Dear Apache legal advisors, dear Shindig developers,
>>> as you can see from the discussion below, we have a possible license
>>> conflict between AGPL and APL v2.
>>> We want to integrate code that uses neo4j, a graph database which is
>>> licensed under AGPL, into Shindig. From my perspective it is not necessary
>>> to include any neo4j binaries nor code, but I'm not sure how this affects
>>> compilability. Maybe we can only use the REST API then and don't offer to
>>> run neo4j in embedded mode.
>>> I'm not a lawyer nor a licensing specialist, so please advise on how to
>>> proceed. Maybe we can find a workaround that ensures we are conforming to
>>> the licensing terms and still get the new functionality into Shindig.
>>> One suggestion that seems a good one was to check how Apache Camel deals
>>> with this issue.
>>> Regards and many thanks for clarification in advance
>>> René
>>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: Ate Douma [mailto:ate@douma.nu]
>>> Gesendet: Montag, 11. März 2013 08:49
>>> An: dev@shindig.apache.org
>>> Cc: Peter Neubauer
>>> Betreff: Re: Review Request: Alternative database backend based on graph
>>> database neo4j
>>>
>>> On 03/10/2013 11:59 PM, Matt Franklin wrote:
>>>> On Sunday, March 10, 2013, wrote:
>>>>
>>>>> Thanks for the insight Ate.
>>>>>
>>>>> Rene, I think we should take Ate's suggestion and send an email to
>>>>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK
>>>>> than we continue the discussion about integrating the patch.
>>>>
>>>
>>> Although the answer from Peter Neubauer / neotechnology is accommodating on
>>> this matter and seems to indicate *they* might think this is not a problem,
>>> reading the AGPL [1] license tells me something differently.
>>> I definitely would like this contribution to be acceptable, but we must be
>>> very sure we're not opening a can of worms here.
>>>
>>>>
>>>> I agree that legal should be consulted if we intent to ship a war or
>>>> other archive with any neo4j (or other agpl) licensed binaries included.
>>> I don't think we can do that anyway. AGPL is a variant of GPL, and we're
>>> not
>>> allowed, by ASF policy, to distribute any GPL artifact.
>>>
>>>>
>>>> As a first mitigation step, why don't we make this a separate maven
>>>> module and only ship the source and non-inclusive jar?  It should not
>>>> be a problem to ship a jar and source that only references the neo4j
>>>> libs as runtime dependencies.
>>> That might be a possibility to investigate. As Chris noted in another
>>> email,
>>> it might be doable as Camel seemingly also has a neo4j component.
>>>
>>> But also note: it will also depend on the type of reference such an
>>> optional
>>> module uses. If it requires explicit Java imports and direct usage of the
>>> neo4j APIs, this might qualifies as what is called in the AGPL
>>> 'Corresponding Source'.
>>> Especially as neo4j and Shindig provide and expect 'Remote Network
>>> Interaction'
>>> for which the AGPL is especially created to enforce its license to
>>> downstream users. IMO this can lead to a conflict with the AS2.0 license,
>>> to
>>> possibly not even be allowed distribution under that license from within
>>> the
>>> ASF, or not even its sources be checked into svn...
>>>
>>> But IANAL so indeed this should be run through legal-discuss@ first.
>>>
>>> [1] http://www.gnu.org/licenses/agpl-3.0.html
>>>
>>>>
>>>>
>>>>
>>>>>
>>>>>
>>>>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>>>>> wrote:
>>>>>
>>>>>> Dear Ate,
>>>>>> thanks for your comments. I already thought about this and asked the
>>>>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>>>>
>>>>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to
>>>>>> GPL
>>>>> code. In runtime, the user will not be shielded from the GPL core,
>>>>> which means the runtime will have GPL characteristics when you plug in
>>> Neo4j.
>>>>> That is exactly the intent, and should be ok. The bindings-code is
>>>>> development-time Apache license, regarding contributions and
>>>>> copyright etc, so I think this should be ok.
>>>>>>
>>>>>> I'm not quite sure if that answers your question. I can further
>>>>> investigate if necessary.
>>>>>> Regards
>>>>>> René
>>>>>>
>>>>>> -----Ursprüngliche Nachricht-----
>>>>>> Von: Ate Douma [mailto:ate@douma.nu]
>>>>>> Gesendet: Freitag, 8. März 2013 14:18
>>>>>> An: dev@shindig.apache.org
>>>>>> Betreff: Re: Review Request: Alternative database backend based on
>>>>>> graph
>>>>> database neo4j
>>>>>>
>>>>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>>>>> Normally any database backend access which is abstracted away behind
>>>>> 'plain'
>>>>>> JDBC interfaces are allright to use, commercial versions or
>>>>>> otherwise
>>>>> licensed, because the end-user would have the option to choose
>>>>> whatever
>>>>> (compatible) database they want to use.
>>>>>>
>>>>>> However with neo4j this seems different. Even with only optional
>>>>>> support
>>>>> for neo4j, the neo4j integration might require explicit neo4j (Java)
>>>>> APIs and dependencies? I haven't reviewed the code for this, but if
>>>>> it imports neo4j APIs then their AGPL license can be too invasive and
>>>>> then possibly not acceptable for uses within our AL2.0 licensed
>>> codebase.
>>>>>> Or even if that could be allowed, I would make sure to check and ask
>>>>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>>>>
>>>>>> Regards, Ate
>>>>>>
>>>>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>>>>> This is good news.
>>>>>>>
>>>>>>> One immediate comment is about the package name.
>>>>>>> Would it be possible to put it under org.apache.shindig rather than
>>>>>>> the de.hofuniversity?
>>>>>>>
>>>>>>> This would make the contributions uniform like from other companies
>>>>>>> and organizations.
>>>>>>>
>>>>>>> - Henry
>>>>>>>
>>>>>>>
>>>>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>>>>
>>>>>>>>
>>>>>>>> -----------------------------------------------------------
>>>>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>>>>> https://reviews.apache.org/r/9773/
>>>>>>>> -----------------------------------------------------------
>>>>>>>>
>>>>>>>> Review request for shindig.
>>>>>>>>
>>>>>>>>
>>>>>>>> Description
>>>>>>>> -------
>>>>>>>>
>>>>>>>> Review for Shindig-1911
>>>>>>>> Alternative database backend based on graph database neo4j Any
>>>>>>>> comments welcome. We are committed to further improve this.
>>>>>>>>
>>>>>>>>
>>>>>>>> This addresses bug Shindig-1911.
>>>>>>>>       https://issues.apache.org/jira/browse/Shindig-1911
>>>>>>>>
>>>>>>>>
>>>>>>>> Diffs
>>>>>>>> -----
>>>>>>>>
>>>>>>>>     /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>>>>
>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>> phb
>>>>>>>> ackend/Constants.java
>>>>>>>> PRE-CREATION
>>>>>>>>
>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>> phb
>>>>>>>> ackend/GraphAPIModule.java
>>>>>>>> PRE-CREATION
>>>>>>>>
>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>> phb
>>>>>>>> ackend/GraphConfig.java
>>>>>>>> PRE-CREATION
>>>>>>>>
>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>> phb
>>>>>>>> ackend/GuiceModule.java
>>>>>>>> PRE-CREATION
>>>>>>>>
>>>>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>>>>> phb
>>>>>>>> acke
>>>>
>>>
>>>
>>>
>>>
>>
>
>



Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Peter Neubauer <pe...@neotechnology.com>.
Also,
keep in mind that only the enterprise components of Neo4j are AGPL, the
community edition, which I believe is the most interesting part here, is
GPL.

/peter


Cheers,

/peter neubauer

G:  neubauer.peter
S:  peter.neubauer
P:  +46 704 106975
L:   http://www.linkedin.com/in/neubauer
T:   @peterneubauer

Graph database introduction book for the uninitiated -
http://graphdatabases.com
Neo4j questions? Please use SO - http://stackoverflow.com/search?q=neo4j


On Mon, Mar 11, 2013 at 9:22 AM, René Peinl <re...@hof-university.de>wrote:

> Dear Apache legal advisors, dear Shindig developers,
> as you can see from the discussion below, we have a possible license
> conflict between AGPL and APL v2.
> We want to integrate code that uses neo4j, a graph database which is
> licensed under AGPL, into Shindig. From my perspective it is not necessary
> to include any neo4j binaries nor code, but I'm not sure how this affects
> compilability. Maybe we can only use the REST API then and don't offer to
> run neo4j in embedded mode.
> I'm not a lawyer nor a licensing specialist, so please advise on how to
> proceed. Maybe we can find a workaround that ensures we are conforming to
> the licensing terms and still get the new functionality into Shindig.
> One suggestion that seems a good one was to check how Apache Camel deals
> with this issue.
> Regards and many thanks for clarification in advance
> René
>
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu]
> Gesendet: Montag, 11. März 2013 08:49
> An: dev@shindig.apache.org
> Cc: Peter Neubauer
> Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
>
> On 03/10/2013 11:59 PM, Matt Franklin wrote:
> > On Sunday, March 10, 2013, wrote:
> >
> >> Thanks for the insight Ate.
> >>
> >> Rene, I think we should take Ate's suggestion and send an email to
> >> legal-discussion@ (please CC shindig-dev@).  If they say it is OK
> >> than we continue the discussion about integrating the patch.
> >
>
> Although the answer from Peter Neubauer / neotechnology is accommodating on
> this matter and seems to indicate *they* might think this is not a problem,
> reading the AGPL [1] license tells me something differently.
> I definitely would like this contribution to be acceptable, but we must be
> very sure we're not opening a can of worms here.
>
> >
> > I agree that legal should be consulted if we intent to ship a war or
> > other archive with any neo4j (or other agpl) licensed binaries included.
> I don't think we can do that anyway. AGPL is a variant of GPL, and we're
> not
> allowed, by ASF policy, to distribute any GPL artifact.
>
> >
> > As a first mitigation step, why don't we make this a separate maven
> > module and only ship the source and non-inclusive jar?  It should not
> > be a problem to ship a jar and source that only references the neo4j
> > libs as runtime dependencies.
> That might be a possibility to investigate. As Chris noted in another
> email,
> it might be doable as Camel seemingly also has a neo4j component.
>
> But also note: it will also depend on the type of reference such an
> optional
> module uses. If it requires explicit Java imports and direct usage of the
> neo4j APIs, this might qualifies as what is called in the AGPL
> 'Corresponding Source'.
> Especially as neo4j and Shindig provide and expect 'Remote Network
> Interaction'
> for which the AGPL is especially created to enforce its license to
> downstream users. IMO this can lead to a conflict with the AS2.0 license,
> to
> possibly not even be allowed distribution under that license from within
> the
> ASF, or not even its sources be checked into svn...
>
> But IANAL so indeed this should be run through legal-discuss@ first.
>
> [1] http://www.gnu.org/licenses/agpl-3.0.html
>
> >
> >
> >
> >>
> >>
> >> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
> >> wrote:
> >>
> >>> Dear Ate,
> >>> thanks for your comments. I already thought about this and asked the
> >> guys from neo technologies. Here is the answer from Peter Neubauer.
> >>>
> >>> in principle (IANAL) it is ok to have ALv2 licensed code binding to
> >>> GPL
> >> code. In runtime, the user will not be shielded from the GPL core,
> >> which means the runtime will have GPL characteristics when you plug in
> Neo4j.
> >> That is exactly the intent, and should be ok. The bindings-code is
> >> development-time Apache license, regarding contributions and
> >> copyright etc, so I think this should be ok.
> >>>
> >>> I'm not quite sure if that answers your question. I can further
> >> investigate if necessary.
> >>> Regards
> >>> René
> >>>
> >>> -----Ursprüngliche Nachricht-----
> >>> Von: Ate Douma [mailto:ate@douma.nu]
> >>> Gesendet: Freitag, 8. März 2013 14:18
> >>> An: dev@shindig.apache.org
> >>> Betreff: Re: Review Request: Alternative database backend based on
> >>> graph
> >> database neo4j
> >>>
> >>> Just from the peanut gallery, but neo4j is AGPL licensed.
> >>> Normally any database backend access which is abstracted away behind
> >> 'plain'
> >>> JDBC interfaces are allright to use, commercial versions or
> >>> otherwise
> >> licensed, because the end-user would have the option to choose
> >> whatever
> >> (compatible) database they want to use.
> >>>
> >>> However with neo4j this seems different. Even with only optional
> >>> support
> >> for neo4j, the neo4j integration might require explicit neo4j (Java)
> >> APIs and dependencies? I haven't reviewed the code for this, but if
> >> it imports neo4j APIs then their AGPL license can be too invasive and
> >> then possibly not acceptable for uses within our AL2.0 licensed
> codebase.
> >>> Or even if that could be allowed, I would make sure to check and ask
> >> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
> >>>
> >>> Regards, Ate
> >>>
> >>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
> >>>> This is good news.
> >>>>
> >>>> One immediate comment is about the package name.
> >>>> Would it be possible to put it under org.apache.shindig rather than
> >>>> the de.hofuniversity?
> >>>>
> >>>> This would make the contributions uniform like from other companies
> >>>> and organizations.
> >>>>
> >>>> - Henry
> >>>>
> >>>>
> >>>> 2013/3/6 René Peinl <re...@hof-university.de>
> >>>>
> >>>>>
> >>>>> -----------------------------------------------------------
> >>>>> This is an automatically generated e-mail. To reply, visit:
> >>>>> https://reviews.apache.org/r/9773/
> >>>>> -----------------------------------------------------------
> >>>>>
> >>>>> Review request for shindig.
> >>>>>
> >>>>>
> >>>>> Description
> >>>>> -------
> >>>>>
> >>>>> Review for Shindig-1911
> >>>>> Alternative database backend based on graph database neo4j Any
> >>>>> comments welcome. We are committed to further improve this.
> >>>>>
> >>>>>
> >>>>> This addresses bug Shindig-1911.
> >>>>>      https://issues.apache.org/jira/browse/Shindig-1911
> >>>>>
> >>>>>
> >>>>> Diffs
> >>>>> -----
> >>>>>
> >>>>>    /trunk/java/neo4j-backend/pom.xml PRE-CREATION
> >>>>>
> >>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
> >>>>> phb
> >>>>> ackend/Constants.java
> >>>>> PRE-CREATION
> >>>>>
> >>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
> >>>>> phb
> >>>>> ackend/GraphAPIModule.java
> >>>>> PRE-CREATION
> >>>>>
> >>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
> >>>>> phb
> >>>>> ackend/GraphConfig.java
> >>>>> PRE-CREATION
> >>>>>
> >>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
> >>>>> phb
> >>>>> ackend/GuiceModule.java
> >>>>> PRE-CREATION
> >>>>>
> >>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
> >>>>> phb
> >>>>> acke
> >
>
>
>
>

AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
Dear Apache legal advisors, dear Shindig developers,
as you can see from the discussion below, we have a possible license
conflict between AGPL and APL v2. 
We want to integrate code that uses neo4j, a graph database which is
licensed under AGPL, into Shindig. From my perspective it is not necessary
to include any neo4j binaries nor code, but I'm not sure how this affects
compilability. Maybe we can only use the REST API then and don't offer to
run neo4j in embedded mode.  
I'm not a lawyer nor a licensing specialist, so please advise on how to
proceed. Maybe we can find a workaround that ensures we are conforming to
the licensing terms and still get the new functionality into Shindig.
One suggestion that seems a good one was to check how Apache Camel deals
with this issue.
Regards and many thanks for clarification in advance
René

-----Ursprüngliche Nachricht-----
Von: Ate Douma [mailto:ate@douma.nu] 
Gesendet: Montag, 11. März 2013 08:49
An: dev@shindig.apache.org
Cc: Peter Neubauer
Betreff: Re: Review Request: Alternative database backend based on graph
database neo4j

On 03/10/2013 11:59 PM, Matt Franklin wrote:
> On Sunday, March 10, 2013, wrote:
>
>> Thanks for the insight Ate.
>>
>> Rene, I think we should take Ate's suggestion and send an email to 
>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK 
>> than we continue the discussion about integrating the patch.
>

Although the answer from Peter Neubauer / neotechnology is accommodating on
this matter and seems to indicate *they* might think this is not a problem,
reading the AGPL [1] license tells me something differently.
I definitely would like this contribution to be acceptable, but we must be
very sure we're not opening a can of worms here.

>
> I agree that legal should be consulted if we intent to ship a war or 
> other archive with any neo4j (or other agpl) licensed binaries included.
I don't think we can do that anyway. AGPL is a variant of GPL, and we're not
allowed, by ASF policy, to distribute any GPL artifact.

>
> As a first mitigation step, why don't we make this a separate maven 
> module and only ship the source and non-inclusive jar?  It should not 
> be a problem to ship a jar and source that only references the neo4j 
> libs as runtime dependencies.
That might be a possibility to investigate. As Chris noted in another email,
it might be doable as Camel seemingly also has a neo4j component.

But also note: it will also depend on the type of reference such an optional
module uses. If it requires explicit Java imports and direct usage of the
neo4j APIs, this might qualifies as what is called in the AGPL
'Corresponding Source'. 
Especially as neo4j and Shindig provide and expect 'Remote Network
Interaction' 
for which the AGPL is especially created to enforce its license to
downstream users. IMO this can lead to a conflict with the AS2.0 license, to
possibly not even be allowed distribution under that license from within the
ASF, or not even its sources be checked into svn...

But IANAL so indeed this should be run through legal-discuss@ first.

[1] http://www.gnu.org/licenses/agpl-3.0.html

>
>
>
>>
>>
>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>> wrote:
>>
>>> Dear Ate,
>>> thanks for your comments. I already thought about this and asked the
>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>
>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to 
>>> GPL
>> code. In runtime, the user will not be shielded from the GPL core, 
>> which means the runtime will have GPL characteristics when you plug in
Neo4j.
>> That is exactly the intent, and should be ok. The bindings-code is 
>> development-time Apache license, regarding contributions and 
>> copyright etc, so I think this should be ok.
>>>
>>> I'm not quite sure if that answers your question. I can further
>> investigate if necessary.
>>> Regards
>>> René
>>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: Ate Douma [mailto:ate@douma.nu]
>>> Gesendet: Freitag, 8. März 2013 14:18
>>> An: dev@shindig.apache.org
>>> Betreff: Re: Review Request: Alternative database backend based on 
>>> graph
>> database neo4j
>>>
>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>> Normally any database backend access which is abstracted away behind
>> 'plain'
>>> JDBC interfaces are allright to use, commercial versions or 
>>> otherwise
>> licensed, because the end-user would have the option to choose 
>> whatever
>> (compatible) database they want to use.
>>>
>>> However with neo4j this seems different. Even with only optional 
>>> support
>> for neo4j, the neo4j integration might require explicit neo4j (Java) 
>> APIs and dependencies? I haven't reviewed the code for this, but if 
>> it imports neo4j APIs then their AGPL license can be too invasive and 
>> then possibly not acceptable for uses within our AL2.0 licensed codebase.
>>> Or even if that could be allowed, I would make sure to check and ask
>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>
>>> Regards, Ate
>>>
>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>> This is good news.
>>>>
>>>> One immediate comment is about the package name.
>>>> Would it be possible to put it under org.apache.shindig rather than 
>>>> the de.hofuniversity?
>>>>
>>>> This would make the contributions uniform like from other companies 
>>>> and organizations.
>>>>
>>>> - Henry
>>>>
>>>>
>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>
>>>>>
>>>>> -----------------------------------------------------------
>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>> https://reviews.apache.org/r/9773/
>>>>> -----------------------------------------------------------
>>>>>
>>>>> Review request for shindig.
>>>>>
>>>>>
>>>>> Description
>>>>> -------
>>>>>
>>>>> Review for Shindig-1911
>>>>> Alternative database backend based on graph database neo4j Any 
>>>>> comments welcome. We are committed to further improve this.
>>>>>
>>>>>
>>>>> This addresses bug Shindig-1911.
>>>>>      https://issues.apache.org/jira/browse/Shindig-1911
>>>>>
>>>>>
>>>>> Diffs
>>>>> -----
>>>>>
>>>>>    /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>> phb
>>>>> ackend/Constants.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>> phb
>>>>> ackend/GraphAPIModule.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>> phb
>>>>> ackend/GraphConfig.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>> phb
>>>>> ackend/GuiceModule.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/gra
>>>>> phb
>>>>> acke
>




Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
On 03/10/2013 11:59 PM, Matt Franklin wrote:
> On Sunday, March 10, 2013, wrote:
>
>> Thanks for the insight Ate.
>>
>> Rene, I think we should take Ate's suggestion and send an email to
>> legal-discussion@ (please CC shindig-dev@).  If they say it is OK than we
>> continue the discussion about integrating the patch.
>

Although the answer from Peter Neubauer / neotechnology is accommodating on this 
matter and seems to indicate *they* might think this is not a problem, reading 
the AGPL [1] license tells me something differently.
I definitely would like this contribution to be acceptable, but we must be very 
sure we're not opening a can of worms here.

>
> I agree that legal should be consulted if we intent to ship a war or other
> archive with any neo4j (or other agpl) licensed binaries included.
I don't think we can do that anyway. AGPL is a variant of GPL, and we're not 
allowed, by ASF policy, to distribute any GPL artifact.

>
> As a first mitigation step, why don't we make this a separate maven module
> and only ship the source and non-inclusive jar?  It should not be a problem
> to ship a jar and source that only references the neo4j libs as runtime
> dependencies.
That might be a possibility to investigate. As Chris noted in another email, it 
might be doable as Camel seemingly also has a neo4j component.

But also note: it will also depend on the type of reference such an optional 
module uses. If it requires explicit Java imports and direct usage of the neo4j 
APIs, this might qualifies as what is called in the AGPL 'Corresponding Source'. 
Especially as neo4j and Shindig provide and expect 'Remote Network Interaction' 
for which the AGPL is especially created to enforce its license to downstream 
users. IMO this can lead to a conflict with the AS2.0 license, to possibly not 
even be allowed distribution under that license from within the ASF, or not even 
its sources be checked into svn...

But IANAL so indeed this should be run through legal-discuss@ first.

[1] http://www.gnu.org/licenses/agpl-3.0.html

>
>
>
>>
>>
>> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
>> wrote:
>>
>>> Dear Ate,
>>> thanks for your comments. I already thought about this and asked the
>> guys from neo technologies. Here is the answer from Peter Neubauer.
>>>
>>> in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL
>> code. In runtime, the user will not be shielded from the GPL core, which
>> means the runtime will have GPL characteristics when you plug in Neo4j.
>> That is exactly the intent, and should be ok. The bindings-code is
>> development-time Apache license, regarding contributions and copyright etc,
>> so I think this should be ok.
>>>
>>> I'm not quite sure if that answers your question. I can further
>> investigate if necessary.
>>> Regards
>>> René
>>>
>>> -----Ursprüngliche Nachricht-----
>>> Von: Ate Douma [mailto:ate@douma.nu]
>>> Gesendet: Freitag, 8. März 2013 14:18
>>> An: dev@shindig.apache.org
>>> Betreff: Re: Review Request: Alternative database backend based on graph
>> database neo4j
>>>
>>> Just from the peanut gallery, but neo4j is AGPL licensed.
>>> Normally any database backend access which is abstracted away behind
>> 'plain'
>>> JDBC interfaces are allright to use, commercial versions or otherwise
>> licensed, because the end-user would have the option to choose whatever
>> (compatible) database they want to use.
>>>
>>> However with neo4j this seems different. Even with only optional support
>> for neo4j, the neo4j integration might require explicit neo4j (Java) APIs
>> and dependencies? I haven't reviewed the code for this, but if it imports
>> neo4j APIs then their AGPL license can be too invasive and then possibly
>> not acceptable for uses within our AL2.0 licensed codebase.
>>> Or even if that could be allowed, I would make sure to check and ask
>> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
>>>
>>> Regards, Ate
>>>
>>> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>>>> This is good news.
>>>>
>>>> One immediate comment is about the package name.
>>>> Would it be possible to put it under org.apache.shindig rather than
>>>> the de.hofuniversity?
>>>>
>>>> This would make the contributions uniform like from other companies
>>>> and organizations.
>>>>
>>>> - Henry
>>>>
>>>>
>>>> 2013/3/6 René Peinl <re...@hof-university.de>
>>>>
>>>>>
>>>>> -----------------------------------------------------------
>>>>> This is an automatically generated e-mail. To reply, visit:
>>>>> https://reviews.apache.org/r/9773/
>>>>> -----------------------------------------------------------
>>>>>
>>>>> Review request for shindig.
>>>>>
>>>>>
>>>>> Description
>>>>> -------
>>>>>
>>>>> Review for Shindig-1911
>>>>> Alternative database backend based on graph database neo4j Any
>>>>> comments welcome. We are committed to further improve this.
>>>>>
>>>>>
>>>>> This addresses bug Shindig-1911.
>>>>>      https://issues.apache.org/jira/browse/Shindig-1911
>>>>>
>>>>>
>>>>> Diffs
>>>>> -----
>>>>>
>>>>>    /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>>>> ackend/Constants.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>>>> ackend/GraphAPIModule.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>>>> ackend/GraphConfig.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>>>> ackend/GuiceModule.java
>>>>> PRE-CREATION
>>>>>
>>>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>>>> acke
>



Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Chris Geer <ch...@cxtsoftware.com>.
One idea is check how Camel handles it. They have a neo4j component.

On Sunday, March 10, 2013, Matt Franklin wrote:

> On Sunday, March 10, 2013, wrote:
>
> > Thanks for the insight Ate.
> >
> > Rene, I think we should take Ate's suggestion and send an email to
> > legal-discussion@ (please CC shindig-dev@).  If they say it is OK than
> we
> > continue the discussion about integrating the patch.
>
>
> I agree that legal should be consulted if we intent to ship a war or other
> archive with any neo4j (or other agpl) licensed binaries included.
>
> As a first mitigation step, why don't we make this a separate maven module
> and only ship the source and non-inclusive jar?  It should not be a problem
> to ship a jar and source that only references the neo4j libs as runtime
> dependencies.
>
>
>
> >
> >
> > On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
> > wrote:
> >
> > > Dear Ate,
> > > thanks for your comments. I already thought about this and asked the
> > guys from neo technologies. Here is the answer from Peter Neubauer.
> > >
> > > in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL
> > code. In runtime, the user will not be shielded from the GPL core, which
> > means the runtime will have GPL characteristics when you plug in Neo4j.
> > That is exactly the intent, and should be ok. The bindings-code is
> > development-time Apache license, regarding contributions and copyright
> etc,
> > so I think this should be ok.
> > >
> > > I'm not quite sure if that answers your question. I can further
> > investigate if necessary.
> > > Regards
> > > René
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Ate Douma [mailto:ate@douma.nu]
> > > Gesendet: Freitag, 8. März 2013 14:18
> > > An: dev@shindig.apache.org
> > > Betreff: Re: Review Request: Alternative database backend based on
> graph
> > database neo4j
> > >
> > > Just from the peanut gallery, but neo4j is AGPL licensed.
> > > Normally any database backend access which is abstracted away behind
> > 'plain'
> > > JDBC interfaces are allright to use, commercial versions or otherwise
> > licensed, because the end-user would have the option to choose whatever
> > (compatible) database they want to use.
> > >
> > > However with neo4j this seems different. Even with only optional
> support
> > for neo4j, the neo4j integration might require explicit neo4j (Java) APIs
> > and dependencies? I haven't reviewed the code for this, but if it imports
> > neo4j APIs then their AGPL license can be too invasive and then possibly
> > not acceptable for uses within our AL2.0 licensed codebase.
> > > Or even if that could be allowed, I would make sure to check and ask
> > (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
> > >
> > > Regards, Ate
> > >
> > > On 03/07/2013 07:46 PM, Henry Saputra wrote:
> > >> This is good news.
> > >>
> > >> One immediate comment is about the package name.
> > >> Would it be possible to put it under org.apache.shindig rather than
> > >> the de.hofuniversity?
> > >>
> > >> This would make the contributions uniform like from other companies
> > >> and organizations.
> > >>
> > >> - Henry
> > >>
> > >>
> > >> 2013/3/6 René Peinl <re...@hof-university.de>
> > >>
> > >>>
> > >>> -----------------------------------------------------------
> > >>> This is an automatically generated e-mail. To reply, visit:
> > >>> https://reviews.apache.org/r/9773/
> > >>> -----------------------------------------------------------
> > >>>
> > >>> Review request for shindig.
> > >>>
> > >>>
> > >>> Description
> > >>> -------
> > >>>
> > >>> Review for Shindig-1911
> > >>> Alternative database backend based on graph database neo4j Any
> > >>> comments welcome. We are committed to further improve this.
> > >>>
> > >>>
> > >>> This addresses bug Shindig-1911.
> > >>>     https://issues.apache.org/jira/browse/Shindig-1911
> > >>>
> > >>>
> > >>> Diffs
> > >>> -----
> > >>>
> > >>>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION
> > >>>
> > >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> > >>> ackend/Constants.java
> > >>> PRE-CREATION
> > >>>
> > >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> > >>> ackend/GraphAPIMod

Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Matt Franklin <m....@gmail.com>.
On Sunday, March 10, 2013, wrote:

> Thanks for the insight Ate.
>
> Rene, I think we should take Ate's suggestion and send an email to
> legal-discussion@ (please CC shindig-dev@).  If they say it is OK than we
> continue the discussion about integrating the patch.


I agree that legal should be consulted if we intent to ship a war or other
archive with any neo4j (or other agpl) licensed binaries included.

As a first mitigation step, why don't we make this a separate maven module
and only ship the source and non-inclusive jar?  It should not be a problem
to ship a jar and source that only references the neo4j libs as runtime
dependencies.



>
>
> On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de>
> wrote:
>
> > Dear Ate,
> > thanks for your comments. I already thought about this and asked the
> guys from neo technologies. Here is the answer from Peter Neubauer.
> >
> > in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL
> code. In runtime, the user will not be shielded from the GPL core, which
> means the runtime will have GPL characteristics when you plug in Neo4j.
> That is exactly the intent, and should be ok. The bindings-code is
> development-time Apache license, regarding contributions and copyright etc,
> so I think this should be ok.
> >
> > I'm not quite sure if that answers your question. I can further
> investigate if necessary.
> > Regards
> > René
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Ate Douma [mailto:ate@douma.nu]
> > Gesendet: Freitag, 8. März 2013 14:18
> > An: dev@shindig.apache.org
> > Betreff: Re: Review Request: Alternative database backend based on graph
> database neo4j
> >
> > Just from the peanut gallery, but neo4j is AGPL licensed.
> > Normally any database backend access which is abstracted away behind
> 'plain'
> > JDBC interfaces are allright to use, commercial versions or otherwise
> licensed, because the end-user would have the option to choose whatever
> (compatible) database they want to use.
> >
> > However with neo4j this seems different. Even with only optional support
> for neo4j, the neo4j integration might require explicit neo4j (Java) APIs
> and dependencies? I haven't reviewed the code for this, but if it imports
> neo4j APIs then their AGPL license can be too invasive and then possibly
> not acceptable for uses within our AL2.0 licensed codebase.
> > Or even if that could be allowed, I would make sure to check and ask
> (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
> >
> > Regards, Ate
> >
> > On 03/07/2013 07:46 PM, Henry Saputra wrote:
> >> This is good news.
> >>
> >> One immediate comment is about the package name.
> >> Would it be possible to put it under org.apache.shindig rather than
> >> the de.hofuniversity?
> >>
> >> This would make the contributions uniform like from other companies
> >> and organizations.
> >>
> >> - Henry
> >>
> >>
> >> 2013/3/6 René Peinl <re...@hof-university.de>
> >>
> >>>
> >>> -----------------------------------------------------------
> >>> This is an automatically generated e-mail. To reply, visit:
> >>> https://reviews.apache.org/r/9773/
> >>> -----------------------------------------------------------
> >>>
> >>> Review request for shindig.
> >>>
> >>>
> >>> Description
> >>> -------
> >>>
> >>> Review for Shindig-1911
> >>> Alternative database backend based on graph database neo4j Any
> >>> comments welcome. We are committed to further improve this.
> >>>
> >>>
> >>> This addresses bug Shindig-1911.
> >>>     https://issues.apache.org/jira/browse/Shindig-1911
> >>>
> >>>
> >>> Diffs
> >>> -----
> >>>
> >>>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/Constants.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GraphAPIModule.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GraphConfig.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> ackend/GuiceModule.java
> >>> PRE-CREATION
> >>>
> >>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
> >>> acke

Re: Review Request: Alternative database backend based on graph database neo4j

Posted by rb...@gmail.com.
Thanks for the insight Ate.  

Rene, I think we should take Ate's suggestion and send an email to legal-discussion@ (please CC shindig-dev@).  If they say it is OK than we continue the discussion about integrating the patch.


On Mar 9, 2013, at 7:56 AM, René Peinl <re...@hof-university.de> wrote:

> Dear Ate,
> thanks for your comments. I already thought about this and asked the guys from neo technologies. Here is the answer from Peter Neubauer.
> 
> in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL code. In runtime, the user will not be shielded from the GPL core, which means the runtime will have GPL characteristics when you plug in Neo4j. That is exactly the intent, and should be ok. The bindings-code is development-time Apache license, regarding contributions and copyright etc, so I think this should be ok.
> 
> I'm not quite sure if that answers your question. I can further investigate if necessary.
> Regards
> René 
> 
> -----Ursprüngliche Nachricht-----
> Von: Ate Douma [mailto:ate@douma.nu] 
> Gesendet: Freitag, 8. März 2013 14:18
> An: dev@shindig.apache.org
> Betreff: Re: Review Request: Alternative database backend based on graph database neo4j
> 
> Just from the peanut gallery, but neo4j is AGPL licensed.
> Normally any database backend access which is abstracted away behind 'plain' 
> JDBC interfaces are allright to use, commercial versions or otherwise licensed, because the end-user would have the option to choose whatever (compatible) database they want to use.
> 
> However with neo4j this seems different. Even with only optional support for neo4j, the neo4j integration might require explicit neo4j (Java) APIs and dependencies? I haven't reviewed the code for this, but if it imports neo4j APIs then their AGPL license can be too invasive and then possibly not acceptable for uses within our AL2.0 licensed codebase.
> Or even if that could be allowed, I would make sure to check and ask (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.
> 
> Regards, Ate
> 
> On 03/07/2013 07:46 PM, Henry Saputra wrote:
>> This is good news.
>> 
>> One immediate comment is about the package name.
>> Would it be possible to put it under org.apache.shindig rather than 
>> the de.hofuniversity?
>> 
>> This would make the contributions uniform like from other companies 
>> and organizations.
>> 
>> - Henry
>> 
>> 
>> 2013/3/6 René Peinl <re...@hof-university.de>
>> 
>>> 
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/9773/
>>> -----------------------------------------------------------
>>> 
>>> Review request for shindig.
>>> 
>>> 
>>> Description
>>> -------
>>> 
>>> Review for Shindig-1911
>>> Alternative database backend based on graph database neo4j Any 
>>> comments welcome. We are committed to further improve this.
>>> 
>>> 
>>> This addresses bug Shindig-1911.
>>>     https://issues.apache.org/jira/browse/Shindig-1911
>>> 
>>> 
>>> Diffs
>>> -----
>>> 
>>>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/Constants.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/GraphAPIModule.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/GraphConfig.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/GuiceModule.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/db/neo4j/INeo4jConnector.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/db/neo4j/Neo4jConnector.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/db/neo4j/Neo4jHAConnector.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/db/neo4j/Neo4jRelTypes.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/db/neo4j/Neo4jRestConnector.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/ExtOrgPersonImpl.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/ExtOrganizationImpl.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/IExtOrgPerson.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/IExtOrganization.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherActivityEntry.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherActivityObject.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherAttributesMessage.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherListFieldList.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherMessage.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherMessageCollection.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/cypher/CypherPerson.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/ADataTransferObject.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/AccountDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/ActivityDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/ActivityEntryDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/ActivityObjectDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/AddressDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/DTOHelper.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/GroupDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/MediaItemDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/MediaLinkDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/MessageCollectionDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/MessageDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/OrganizationDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/dto/PersonDTO.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphAccount.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphActivity.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphActivityEntry.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphActivityObject.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphAddress.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphAppData.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphGroup.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphListFieldList.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMediaItem.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMediaLink.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMessage.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMessageCollection.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphOrganization.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphPerson.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/spring/SpringAccount.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/spring/SpringAddress.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/spring/SpringApplication.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/spring/SpringOrganization.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/model/spring/SpringPerson.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/service/ExtPersonHandler.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/service/UserHandler.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphActivitySPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphActivityStreamSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphAlbumSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphAppDataSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphFriendSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphGroupSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphMediaItemSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphMessageSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/IExtPersonService.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/IFriendService.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/IGraphService.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/CypherGraphSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/CypherGroupSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/CypherMessageSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/CypherPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/RestCypherGraphSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/RestCypherGroupSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/RestCypherMessageSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/RestCypherPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/gremlin/GremlinGraphSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/gremlin/GremlinMessageSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/gremlin/GremlinPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/spring/PersonRepository.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/spring/SpringPersonSPI.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/service/ActivityObjectService.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/service/ApplicationService.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/service/IDManager.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/testdata/BatchParser.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/testdata/DataGenerator.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/testdata/DataParser.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/util/NodeFilter.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/util/NodeSorter.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>>> ackend/util/PersonFilter.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphActivityEntryTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphAppDataTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphGroupTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMessageCollectionTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphMessageTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/model/graph/GraphPersonTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/service/UserHandlerTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphActivitySPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphActivityStreamSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphAppDataSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphFriendSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphGroupSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphMessageSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphPersonSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/opensocial/spi/GraphSPITest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/service/ActivityObjectServiceTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/service/ApplicationServiceTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/service/IDManagerTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/util/NodeFilterTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/util/NodeSorterTest.java
>>> PRE-CREATION
>>> 
>>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>>> ackend/util/PersonFilterTest.java
>>> PRE-CREATION
>>>   /trunk/pom.xml 1452786
>>> 
>>> Diff: https://reviews.apache.org/r/9773/diff/
>>> 
>>> 
>>> Testing
>>> -------
>>> 
>>> 
>>> Thanks,
>>> 
>>> René Peinl
>>> 
>>> 
>> 
> 
> 
> 


AW: Review Request: Alternative database backend based on graph database neo4j

Posted by René Peinl <re...@hof-university.de>.
Dear Ate,
thanks for your comments. I already thought about this and asked the guys from neo technologies. Here is the answer from Peter Neubauer.

in principle (IANAL) it is ok to have ALv2 licensed code binding to GPL code. In runtime, the user will not be shielded from the GPL core, which means the runtime will have GPL characteristics when you plug in Neo4j. That is exactly the intent, and should be ok. The bindings-code is development-time Apache license, regarding contributions and copyright etc, so I think this should be ok.

I'm not quite sure if that answers your question. I can further investigate if necessary.
Regards
René 

-----Ursprüngliche Nachricht-----
Von: Ate Douma [mailto:ate@douma.nu] 
Gesendet: Freitag, 8. März 2013 14:18
An: dev@shindig.apache.org
Betreff: Re: Review Request: Alternative database backend based on graph database neo4j

Just from the peanut gallery, but neo4j is AGPL licensed.
Normally any database backend access which is abstracted away behind 'plain' 
JDBC interfaces are allright to use, commercial versions or otherwise licensed, because the end-user would have the option to choose whatever (compatible) database they want to use.

However with neo4j this seems different. Even with only optional support for neo4j, the neo4j integration might require explicit neo4j (Java) APIs and dependencies? I haven't reviewed the code for this, but if it imports neo4j APIs then their AGPL license can be too invasive and then possibly not acceptable for uses within our AL2.0 licensed codebase.
Or even if that could be allowed, I would make sure to check and ask (legal-discuss@ etc.) if it would be acceptable from ASF policy POV.

Regards, Ate

On 03/07/2013 07:46 PM, Henry Saputra wrote:
> This is good news.
>
> One immediate comment is about the package name.
> Would it be possible to put it under org.apache.shindig rather than 
> the de.hofuniversity?
>
> This would make the contributions uniform like from other companies 
> and organizations.
>
> - Henry
>
>
> 2013/3/6 René Peinl <re...@hof-university.de>
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9773/
>> -----------------------------------------------------------
>>
>> Review request for shindig.
>>
>>
>> Description
>> -------
>>
>> Review for Shindig-1911
>> Alternative database backend based on graph database neo4j Any 
>> comments welcome. We are committed to further improve this.
>>
>>
>> This addresses bug Shindig-1911.
>>      https://issues.apache.org/jira/browse/Shindig-1911
>>
>>
>> Diffs
>> -----
>>
>>    /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/Constants.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/GraphAPIModule.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/GraphConfig.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/GuiceModule.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/db/neo4j/INeo4jConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/db/neo4j/Neo4jConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/db/neo4j/Neo4jHAConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/db/neo4j/Neo4jRelTypes.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/db/neo4j/Neo4jRestConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/ExtOrgPersonImpl.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/ExtOrganizationImpl.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/IExtOrgPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/IExtOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherActivityEntry.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherActivityObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherAttributesMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherListFieldList.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherMessageCollection.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/cypher/CypherPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/ADataTransferObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/AccountDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/ActivityDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/ActivityEntryDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/ActivityObjectDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/AddressDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/DTOHelper.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/GroupDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/MediaItemDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/MediaLinkDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/MessageCollectionDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/MessageDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/OrganizationDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/dto/PersonDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphAccount.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphActivity.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphActivityEntry.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphActivityObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphAddress.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphAppData.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphGroup.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphListFieldList.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMediaItem.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMediaLink.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMessageCollection.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/spring/SpringAccount.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/spring/SpringAddress.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/spring/SpringApplication.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/spring/SpringOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/model/spring/SpringPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/service/ExtPersonHandler.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/service/UserHandler.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphActivitySPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphAlbumSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphAppDataSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphFriendSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphMediaItemSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/IExtPersonService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/IFriendService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/IGraphService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/CypherGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/CypherGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/CypherMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/CypherPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/RestCypherGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/RestCypherGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/RestCypherMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/RestCypherPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/gremlin/GremlinGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/gremlin/GremlinMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/gremlin/GremlinPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/spring/PersonRepository.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/spring/SpringPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/service/ActivityObjectService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/service/ApplicationService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/service/IDManager.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/testdata/BatchParser.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/testdata/DataGenerator.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/testdata/DataParser.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/util/NodeFilter.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/util/NodeSorter.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphb
>> ackend/util/PersonFilter.java
>> PRE-CREATION
>>    
>> /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphActivityEntryTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphAppDataTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphGroupTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMessageCollectionTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphMessageTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/model/graph/GraphPersonTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/service/UserHandlerTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphActivitySPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphActivityStreamSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphAppDataSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphFriendSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphGroupSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphMessageSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphPersonSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/opensocial/spi/GraphSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/service/ActivityObjectServiceTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/service/ApplicationServiceTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/service/IDManagerTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/util/NodeFilterTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/util/NodeSorterTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphb
>> ackend/util/PersonFilterTest.java
>> PRE-CREATION
>>    /trunk/pom.xml 1452786
>>
>> Diff: https://reviews.apache.org/r/9773/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> René Peinl
>>
>>
>




Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Ate Douma <at...@douma.nu>.
Just from the peanut gallery, but neo4j is AGPL licensed.
Normally any database backend access which is abstracted away behind 'plain' 
JDBC interfaces are allright to use, commercial versions or otherwise licensed, 
because the end-user would have the option to choose whatever (compatible) 
database they want to use.

However with neo4j this seems different. Even with only optional support for 
neo4j, the neo4j integration might require explicit neo4j (Java) APIs and 
dependencies? I haven't reviewed the code for this, but if it imports neo4j APIs 
then their AGPL license can be too invasive and then possibly not acceptable for 
uses within our AL2.0 licensed codebase.
Or even if that could be allowed, I would make sure to check and ask 
(legal-discuss@ etc.) if it would be acceptable from ASF policy POV.

Regards, Ate

On 03/07/2013 07:46 PM, Henry Saputra wrote:
> This is good news.
>
> One immediate comment is about the package name.
> Would it be possible to put it under org.apache.shindig rather than the
> de.hofuniversity?
>
> This would make the contributions uniform like from other companies and
> organizations.
>
> - Henry
>
>
> 2013/3/6 René Peinl <re...@hof-university.de>
>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9773/
>> -----------------------------------------------------------
>>
>> Review request for shindig.
>>
>>
>> Description
>> -------
>>
>> Review for Shindig-1911
>> Alternative database backend based on graph database neo4j
>> Any comments welcome. We are committed to further improve this.
>>
>>
>> This addresses bug Shindig-1911.
>>      https://issues.apache.org/jira/browse/Shindig-1911
>>
>>
>> Diffs
>> -----
>>
>>    /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java
>> PRE-CREATION
>>    /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java
>> PRE-CREATION
>>
>> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java
>> PRE-CREATION
>>    /trunk/pom.xml 1452786
>>
>> Diff: https://reviews.apache.org/r/9773/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> René Peinl
>>
>>
>



Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Henry Saputra <he...@gmail.com>.
This is good news.

One immediate comment is about the package name.
Would it be possible to put it under org.apache.shindig rather than the
de.hofuniversity?

This would make the contributions uniform like from other companies and
organizations.

- Henry


2013/3/6 René Peinl <re...@hof-university.de>

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
>
> Review request for shindig.
>
>
> Description
> -------
>
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
>
>
> This addresses bug Shindig-1911.
>     https://issues.apache.org/jira/browse/Shindig-1911
>
>
> Diffs
> -----
>
>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java
> PRE-CREATION
>   /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java
> PRE-CREATION
>
> /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java
> PRE-CREATION
>   /trunk/pom.xml 1452786
>
> Diff: https://reviews.apache.org/r/9773/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> René Peinl
>
>

Re: Review Request: Alternative database backend based on graph database neo4j

Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9773/#review17497
-----------------------------------------------------------


First, thanks for the patch!  This looks tremendous!

I haven't had a chance to look at this from a functional perspective yet, but there are a few things I've noticed that will need to be changed before we can accept this patch.  Your entire package structure is "de.hofuniversity.iisys.graphbackend".  This really needs to be "org.apache.shindig.graphbackend" (or the like) if we want to include this in Shindig.  It might be best if we ignore this for now until we have a deeper functional review.

A lot of this source also does not comform to the Shindig coding conventions.  Checkstyle is built into the Shindig builds if you want to see the complaints.  Eclipse formatting and cleanup tools can likely take care of a lot of these.

RAT also found that you are missing Apache licenses on these files:
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java
  java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java

I'll start reviewing the rest of the code this week and will try to provide you more feedback.  Do you have a sample web.xml that is using the neo4j implementation?  I don't see that you've changed any existing guice modules, so I assume I need to point to a guice module you created in my web.xml.  Is that the case?

Thanks!

- Stanton Sievers


On March 6, 2013, 9:21 a.m., René Peinl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9773/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 9:21 a.m.)
> 
> 
> Review request for shindig.
> 
> 
> Description
> -------
> 
> Review for Shindig-1911
> Alternative database backend based on graph database neo4j
> Any comments welcome. We are committed to further improve this.
> 
> 
> This addresses bug Shindig-1911.
>     https://issues.apache.org/jira/browse/Shindig-1911
> 
> 
> Diffs
> -----
> 
>   /trunk/java/neo4j-backend/pom.xml PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java PRE-CREATION 
>   /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java PRE-CREATION 
>   /trunk/pom.xml 1452786 
> 
> Diff: https://reviews.apache.org/r/9773/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> René Peinl
> 
>