[GitHub] [opennlp] jzonthemtn commented on a diff in pull request #492: OPENNLP-1448 - Introduce SLF4J in OpenNLP

["jzonthemtn (via GitHub)" <gi...@apache.org>]

jzonthemtn commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1115982530


##########
opennlp-brat-annotator/src/main/java/opennlp/bratann/NameFinderAnnService.java:
##########
@@ -41,15 +43,16 @@
 
 public class NameFinderAnnService {
 
+  private static Logger logger = LoggerFactory.getLogger(NameFinderAnnService.class);
   public static SentenceDetector sentenceDetector = new NewlineSentenceDetector();
   public static Tokenizer tokenizer = WhitespaceTokenizer.INSTANCE;
   public static TokenNameFinder[] nameFinders;
 
   public static void main(String[] args) throws Exception {
 
     if (args.length == 0) {
-      System.out.println("Usage:");
-      System.out.println("[NameFinderAnnService -serverPort port] [-tokenizerModel file] "
+      logger.info("Usage:");

Review Comment:
   Do we have any feelings about how messages in a CLI tool should be displayed? Does changing these to `logger` from `System.out` have any impact? Is there any chance the message would be missed or somewhere other than standard out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org