You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/25 19:48:30 UTC
[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10194
to review the following change.
Change subject: java: fix error message when attempting to import Parquet TIMESTAMP
......................................................................
java: fix error message when attempting to import Parquet TIMESTAMP
The code was comparing a Parquet type object to a javax.sql Timestamp
type enum. This would never be true, so the code was dead. This fixes it
to do the appropriate comparison.
Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/10194/1
--
To view, visit http://gerrit.cloudera.org:8080/10194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
Gerrit-Change-Number: 10194
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10194 )
Change subject: java: fix error message when attempting to import Parquet TIMESTAMP
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
Gerrit-Change-Number: 10194
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 17:42:18 +0000
Gerrit-HasComments: No
[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10194 )
Change subject: java: fix error message when attempting to import Parquet TIMESTAMP
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
Gerrit-Change-Number: 10194
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 26 Apr 2018 14:27:26 +0000
Gerrit-HasComments: No
[kudu-CR] java: fix error message when attempting to import Parquet TIMESTAMP
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10194 )
Change subject: java: fix error message when attempting to import Parquet TIMESTAMP
......................................................................
java: fix error message when attempting to import Parquet TIMESTAMP
The code was comparing a Parquet type object to a javax.sql Timestamp
type enum. This would never be true, so the code was dead. This fixes it
to do the appropriate comparison.
Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
Reviewed-on: http://gerrit.cloudera.org:8080/10194
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/ImportParquet.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib961d5372c0d8afc436317dc7c63738860612700
Gerrit-Change-Number: 10194
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>