You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/10 00:41:31 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1659: FINERACT-1052 take 3 block loan over payment
francisguchie opened a new pull request #1659:
URL: https://github.com/apache/fineract/pull/1659
## Description
kindly follow details on https://github.com/apache/fineract/pull/1536 that originated from this jira ==> https://issues.apache.org/jira/browse/FINERACT-1052
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1659:
URL: https://github.com/apache/fineract/pull/1659#issuecomment-834647757
> @ptuomola If I understand this one correctly, this is "take III" of #1264, for [FINERACT-1052](https://issues.apache.org/jira/browse/FINERACT-1052).
>
> I'm not following the details here, and won't be able to help review this one.
@avikganguly01 Have you had time to review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1659:
URL: https://github.com/apache/fineract/pull/1659#issuecomment-798519070
@ptuomola If I understand this one correctly, this is "take III" of #1264, for FINERACT-1052.
I'm not following the details here, and won't be able to help review this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1659:
URL: https://github.com/apache/fineract/pull/1659#issuecomment-823682734
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1659:
URL: https://github.com/apache/fineract/pull/1659#issuecomment-795742086
@vorburger , @ptuomola , @avikganguly01
all changes requested have been addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1659:
URL: https://github.com/apache/fineract/pull/1659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1659:
URL: https://github.com/apache/fineract/pull/1659#issuecomment-856346144
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1659: FINERACT-1052 take 3 block loan over payment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1659:
URL: https://github.com/apache/fineract/pull/1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org