You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/09 17:53:48 UTC

[GitHub] [shardingsphere] fredster33 opened a new pull request #9620: Grammar fix for README

fredster33 opened a new pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620


   No issue applicable.
   
   Changes proposed in this pull request:
   -Minor grammar fix for README
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] fredster33 commented on pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
fredster33 commented on pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#issuecomment-800753313


   All right, I've made the changes. The checks are currently running. Sorry for being late!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] fredster33 commented on a change in pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
fredster33 commented on a change in pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#discussion_r590985069



##########
File path: README.md
##########
@@ -30,11 +30,11 @@ Therefore, we prefer to focus on its increment instead of a total overturn.
 
 Apache ShardingSphere begins to focus on pluggable architecture from version 5.x, features can be embedded into project flexibility.
 Currently, the features such as data sharding, replica query, data encrypt, shadow test, and SQL dialects / database protocols such as MySQL, PostgreSQL, SQLServer, Oracle supported are all weaved by plugins.
-Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and increasing continuously.
+Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and they are increasing continuously.
 
 ShardingSphere became an [Apache](https://apache.org/index.html#projects-list) Top Level Project on April 16, 2020.
 
-Welcome communicate with community via [mail list](mailto:dev@shardingsphere.apache.org).
+You can communicate with community via the [mailing list](mailto:dev@shardingsphere.apache.org).

Review comment:
       Hi there, could you please clarify?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] fredster33 commented on a change in pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
fredster33 commented on a change in pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#discussion_r590991841



##########
File path: README.md
##########
@@ -30,11 +30,11 @@ Therefore, we prefer to focus on its increment instead of a total overturn.
 
 Apache ShardingSphere begins to focus on pluggable architecture from version 5.x, features can be embedded into project flexibility.
 Currently, the features such as data sharding, replica query, data encrypt, shadow test, and SQL dialects / database protocols such as MySQL, PostgreSQL, SQLServer, Oracle supported are all weaved by plugins.
-Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and increasing continuously.
+Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and they are increasing continuously.
 
 ShardingSphere became an [Apache](https://apache.org/index.html#projects-list) Top Level Project on April 16, 2020.
 
-Welcome communicate with community via [mail list](mailto:dev@shardingsphere.apache.org).
+You can communicate with community via the [mailing list](mailto:dev@shardingsphere.apache.org).

Review comment:
       I think "You are welcome to communicate" would work
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#discussion_r590944754



##########
File path: README.md
##########
@@ -30,11 +30,11 @@ Therefore, we prefer to focus on its increment instead of a total overturn.
 
 Apache ShardingSphere begins to focus on pluggable architecture from version 5.x, features can be embedded into project flexibility.
 Currently, the features such as data sharding, replica query, data encrypt, shadow test, and SQL dialects / database protocols such as MySQL, PostgreSQL, SQLServer, Oracle supported are all weaved by plugins.
-Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and increasing continuously.
+Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and they are increasing continuously.
 
 ShardingSphere became an [Apache](https://apache.org/index.html#projects-list) Top Level Project on April 16, 2020.
 
-Welcome communicate with community via [mail list](mailto:dev@shardingsphere.apache.org).
+You can communicate with community via the [mailing list](mailto:dev@shardingsphere.apache.org).

Review comment:
       How about "Welcome to community"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#discussion_r592109582



##########
File path: README.md
##########
@@ -30,11 +30,11 @@ Therefore, we prefer to focus on its increment instead of a total overturn.
 
 Apache ShardingSphere begins to focus on pluggable architecture from version 5.x, features can be embedded into project flexibility.
 Currently, the features such as data sharding, replica query, data encrypt, shadow test, and SQL dialects / database protocols such as MySQL, PostgreSQL, SQLServer, Oracle supported are all weaved by plugins.
-Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and increasing continuously.
+Developers can customize their own ShardingSphere systems just like building lego blocks. There are lots of SPI extensions for Apache ShardingSphere now and they are increasing continuously.
 
 ShardingSphere became an [Apache](https://apache.org/index.html#projects-list) Top Level Project on April 16, 2020.
 
-Welcome communicate with community via [mail list](mailto:dev@shardingsphere.apache.org).
+You can communicate with community via the [mailing list](mailto:dev@shardingsphere.apache.org).

Review comment:
       Nice, go ahead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #9620: Grammar fix for README

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9620:
URL: https://github.com/apache/shardingsphere/pull/9620#issuecomment-799093359


   Hi @fredster33 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org