You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/03 03:54:29 UTC
[GitHub] [flink] camilesing opened a new pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
camilesing opened a new pull request #16683:
URL: https://github.com/apache/flink/pull/16683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
}, {
"hash" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"triggerType" : "PUSH"
}, {
"hash" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22422",
"triggerID" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e UNKNOWN
* a51a065dc64d6b495ff12761b4babb117529da2b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] camilesing commented on a change in pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
camilesing commented on a change in pull request #16683:
URL: https://github.com/apache/flink/pull/16683#discussion_r692714681
##########
File path: docs/layouts/shortcodes/generated/prometheus_push_gateway_reporter_configuration.html
##########
@@ -48,7 +48,7 @@
<td><h5>randomJobNameSuffix</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Specifies whether a random suffix should be appended to the job name.</td>
+ <td>Specifies whether a random suffix should be appended to the job name. Job at least have two container(JobManager and TaskManager), enabled it can diff each other.</td>
Review comment:
I see, thx. I'll close the merge request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
}, {
"hash" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354)
* 63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] infoverload commented on pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
infoverload commented on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-900264628
Thanks a lot for your contribution. Could you add a brief description of the change and use the template provided? Can you also link it to a JIRA ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] camilesing closed pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
camilesing closed pull request #16683:
URL: https://github.com/apache/flink/pull/16683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #16683:
URL: https://github.com/apache/flink/pull/16683#discussion_r692341721
##########
File path: docs/layouts/shortcodes/generated/prometheus_push_gateway_reporter_configuration.html
##########
@@ -48,7 +48,7 @@
<td><h5>randomJobNameSuffix</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Specifies whether a random suffix should be appended to the job name.</td>
+ <td>Specifies whether a random suffix should be appended to the job name. Job at least have two container(JobManager and TaskManager), enabled it can diff each other.</td>
Review comment:
It can even be that 1 task manager has multiple prometheus reporters ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] infoverload commented on a change in pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
infoverload commented on a change in pull request #16683:
URL: https://github.com/apache/flink/pull/16683#discussion_r691855011
##########
File path: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterOptions.java
##########
@@ -42,13 +42,13 @@
public static final ConfigOption<String> JOB_NAME =
ConfigOptions.key("jobName")
.defaultValue("")
- .withDescription("The job name under which metrics will be pushed");
+ .withDescription("The job name under which metrics will be pushed.");
public static final ConfigOption<Boolean> RANDOM_JOB_NAME_SUFFIX =
ConfigOptions.key("randomJobNameSuffix")
.defaultValue(true)
.withDescription(
- "Specifies whether a random suffix should be appended to the job name.");
+ "Specifies whether a random suffix should be appended to the job name. Job at least have two container(JobManager and TaskManager), enabled it can diff each other.");
Review comment:
Can you clarify what is meant with "enabled it can diff each other" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
}, {
"hash" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"triggerType" : "PUSH"
}, {
"hash" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22422",
"triggerID" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354)
* 63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e UNKNOWN
* a51a065dc64d6b495ff12761b4babb117529da2b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22422)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] camilesing commented on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
camilesing commented on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-900760531
@infoverload thx your comment, I've done what you said
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tsreaper commented on a change in pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
tsreaper commented on a change in pull request #16683:
URL: https://github.com/apache/flink/pull/16683#discussion_r692065256
##########
File path: docs/layouts/shortcodes/generated/prometheus_push_gateway_reporter_configuration.html
##########
@@ -48,7 +48,7 @@
<td><h5>randomJobNameSuffix</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Specifies whether a random suffix should be appended to the job name.</td>
+ <td>Specifies whether a random suffix should be appended to the job name. Job at least have two container(JobManager and TaskManager), enabled it can diff each other.</td>
Review comment:
This description is somewhat incorrect. This config adds different random suffix for different reporter instances, but it is not necessary that each task manager has its own metrics reporter (although for most of the time it is the case). For example a mini cluster only has one metrics reporter (see `MiniCluster#start`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
}, {
"hash" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e",
"triggerType" : "PUSH"
}, {
"hash" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a51a065dc64d6b495ff12761b4babb117529da2b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354)
* 63aa6e2f3c05fac9150399fe2a9c519cbe3e1d1e UNKNOWN
* a51a065dc64d6b495ff12761b4babb117529da2b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891501376
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3b3f16a9694732d6211a63d324d4bb579933fe87 (Tue Aug 03 03:57:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16683: [hotfix][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-891515480
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354",
"triggerID" : "3b3f16a9694732d6211a63d324d4bb579933fe87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b3f16a9694732d6211a63d324d4bb579933fe87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] camilesing commented on pull request #16683: [FLINK-23846][docs]improve PushGatewayReporter config description
Posted by GitBox <gi...@apache.org>.
camilesing commented on pull request #16683:
URL: https://github.com/apache/flink/pull/16683#issuecomment-900760531
@infoverload thx your comment, I've done what you said
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org