You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2026/09/27 07:39:55 UTC
[PR] [SPARK-59808][INFRA] Remove JIRA fix versions when merging reverts [spark]
szehon-ho opened a new pull request, #59082:
URL: https://github.com/apache/spark/pull/59082
### What changes were proposed in this pull request?
After merging or backporting a `Revert "..."` PR, offer to remove the corresponding unreleased JIRA fix versions. For example, accepting the suggested versions (`<Enter>` denotes a blank response):
```text
Revert merged into: master, branch-4.x
JIRA issue SPARK-12345 has fix version(s): ['5.0.0', '4.3.0', '3.5.2']
Available unreleased fix version(s) to remove: ['4.3.0', '5.0.0']
Enter comma-separated fix version(s) to remove [5.0.0,4.3.0], or 'skip': <Enter>
Remove fix version(s) ['5.0.0', '4.3.0'] from SPARK-12345? (y/N): y
Successfully removed fixVersions=['5.0.0', '4.3.0'] from SPARK-12345!
```
The committer can enter a different selection or type `skip`. Other fix versions and the ticket's status are preserved. Released and archived versions are excluded, and `--dry-run` logs the proposed removal.
### Why are the changes needed?
Spark release issue lists use JIRA fix versions. Reverted PRs currently leave those versions behind, so release notes can list changes absent from the release. Removing stale fix versions at merge time avoids inaccurate release notes and manual cleanup by release managers.
### Does this PR introduce _any_ user-facing change?
Yes, the committer prompts shown above.
### How was this patch tested?
All 183 doctest examples pass with Python 3.14, including new mocked JIRA tests for removal, skipping, version protection, and dry runs:
```sh
python3 -m doctest dev/merge_spark_pr.py
```
Ruff 0.14.8 lint and formatting checks and `git diff --check` also pass.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5901166355
@Yicong-Huang The `Revert "..."` check already exists in the merge script, introduced in #56026 ([code before this PR](https://github.com/apache/spark/blob/f5498a9dab976099d83f5230f7600b52960b63ce/dev/merge_spark_pr.py#L2256-L2266)). This PR reuses the existing `is_revert_pr` flag for JIRA cleanup and reopening, so it does make those operations depend on that convention too. We could add `[REVERT]` support separately while preserving support for the existing `Revert "..."` titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho closed pull request #59082: [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts
URL: https://github.com/apache/spark/pull/59082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5901248472
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/a026a0be4c88e7ace59d1da7c18ab73b0d81edde
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5901252425
Thanks all for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5897255621
+1, nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions when merging reverts [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5853902640
@Yicong-Huang @HyukjinKwon can you see if it makes sense? was preparing the release and found some JIRA's with PR's that were reverted, but would still be included in the release. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions when merging reverts [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5860541052
oh yeah I like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions when merging reverts [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5858491179
Oh that definitely makes sense and I was planning to do so. Thanks for taking care of it! In addition, shall we also unresolved the ticket so that it can be redone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59808][INFRA] Remove JIRA fix versions and reopen tickets when merging reverts [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #59082:
URL: https://github.com/apache/spark/pull/59082#issuecomment-5900258199
I wonder if "Revert xxx" format would be fragile? why don't we add a `[REVERT]` just similar to `[FOLLOWUP]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org