You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2014/11/06 02:07:50 UTC
[VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Hi all,
I have created a build for Apache Calcite 0.9.2-incubating, release candidate 1.
Thanks to everyone who has contributed to this release. It is a fairly
minor release, and last release before we rename all of the packages
and lots of classes, in what we expect to call 1.0. It will be a
useful stepping stone for people upgrading. However, there are a
number of bug fixes and improvements, including an SPI that makes it
easier to implement your own tables, pushing down projections and
filters. You can read the release notes here:
https://github.com/apache/incubator-calcite/blob/0404fd236ec78e7f83e047972b190cbc7d4fad6a/doc/HISTORY.md
The commit to be voted upon:
http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0404fd236ec78e7f83e047972b190cbc7d4fad6a
Its hash is 0404fd236ec78e7f83e047972b190cbc7d4fad6a.
The hashes of the artifacts are as follows:
src.tar.gz.md5 2c24981f92d86caa9ea258432342cf97
src.tar.gz.sha1 a97de92ff1be8603d9c5d8402009451a49c5e843
src.zip.md5 533ecc9be0de2fd917f08857ff76fb26
src.zip.sha1 ee0a6a5760ed205f6d7666544b4efe04306c7a68
The artifacts to be voted on are located here:
http://people.apache.org/~jhyde/apache-calcite-0.9.2-incubating-rc1/
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1001
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
Please vote on releasing this package as Apache Calcite 0.9.2-incubating.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PPMC votes are cast.
[ ] +1 Release this package as Apache Calcite 0.9.2-incubating
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Julian
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate
1)
Posted by Alan Gates <ga...@hortonworks.com>.
+1 checked the key signature and hashes, looked over the DISCLAIMER,
LICENSE, and NOTICE files, checked for any .class or .jar files, did mvn
install, ran rat. Rat did turn up a few files without licenses, but
they are all docs which I don't think will be an issue.
Alan.
> Julian Hyde <ma...@apache.org>
> November 5, 2014 at 17:07
> Hi all,
>
> I have created a build for Apache Calcite 0.9.2-incubating, release
> candidate 1.
>
> Thanks to everyone who has contributed to this release. It is a fairly
> minor release, and last release before we rename all of the packages
> and lots of classes, in what we expect to call 1.0. It will be a
> useful stepping stone for people upgrading. However, there are a
> number of bug fixes and improvements, including an SPI that makes it
> easier to implement your own tables, pushing down projections and
> filters. You can read the release notes here:
> https://github.com/apache/incubator-calcite/blob/0404fd236ec78e7f83e047972b190cbc7d4fad6a/doc/HISTORY.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0404fd236ec78e7f83e047972b190cbc7d4fad6a
>
> Its hash is 0404fd236ec78e7f83e047972b190cbc7d4fad6a.
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 2c24981f92d86caa9ea258432342cf97
> src.tar.gz.sha1 a97de92ff1be8603d9c5d8402009451a49c5e843
> src.zip.md5 533ecc9be0de2fd917f08857ff76fb26
> src.zip.sha1 ee0a6a5760ed205f6d7666544b4efe04306c7a68
>
> The artifacts to be voted on are located here:
> http://people.apache.org/~jhyde/apache-calcite-0.9.2-incubating-rc1/
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1001
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 0.9.2-incubating.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PPMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 0.9.2-incubating
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
--
Sent with Postbox <http://www.getpostbox.com>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by Jacques Nadeau <ja...@apache.org>.
lgtm +1
On Thu, Nov 6, 2014 at 5:30 PM, James Taylor <ja...@apache.org> wrote:
> +1
>
> On Wed, Nov 5, 2014 at 5:07 PM, Julian Hyde <jh...@apache.org> wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 0.9.2-incubating, release
> candidate 1.
> >
> > Thanks to everyone who has contributed to this release. It is a fairly
> > minor release, and last release before we rename all of the packages
> > and lots of classes, in what we expect to call 1.0. It will be a
> > useful stepping stone for people upgrading. However, there are a
> > number of bug fixes and improvements, including an SPI that makes it
> > easier to implement your own tables, pushing down projections and
> > filters. You can read the release notes here:
> >
> https://github.com/apache/incubator-calcite/blob/0404fd236ec78e7f83e047972b190cbc7d4fad6a/doc/HISTORY.md
> >
> > The commit to be voted upon:
> >
> http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0404fd236ec78e7f83e047972b190cbc7d4fad6a
> >
> > Its hash is 0404fd236ec78e7f83e047972b190cbc7d4fad6a.
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.md5 2c24981f92d86caa9ea258432342cf97
> > src.tar.gz.sha1 a97de92ff1be8603d9c5d8402009451a49c5e843
> > src.zip.md5 533ecc9be0de2fd917f08857ff76fb26
> > src.zip.sha1 ee0a6a5760ed205f6d7666544b4efe04306c7a68
> >
> > The artifacts to be voted on are located here:
> > http://people.apache.org/~jhyde/apache-calcite-0.9.2-incubating-rc1/
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1001
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jhyde.asc
> >
> > Please vote on releasing this package as Apache Calcite 0.9.2-incubating.
> >
> > The vote is open for the next 72 hours and passes if a majority of
> > at least three +1 PPMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 0.9.2-incubating
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Julian
>
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by James Taylor <ja...@apache.org>.
+1
On Wed, Nov 5, 2014 at 5:07 PM, Julian Hyde <jh...@apache.org> wrote:
> Hi all,
>
> I have created a build for Apache Calcite 0.9.2-incubating, release candidate 1.
>
> Thanks to everyone who has contributed to this release. It is a fairly
> minor release, and last release before we rename all of the packages
> and lots of classes, in what we expect to call 1.0. It will be a
> useful stepping stone for people upgrading. However, there are a
> number of bug fixes and improvements, including an SPI that makes it
> easier to implement your own tables, pushing down projections and
> filters. You can read the release notes here:
> https://github.com/apache/incubator-calcite/blob/0404fd236ec78e7f83e047972b190cbc7d4fad6a/doc/HISTORY.md
>
> The commit to be voted upon:
> http://git-wip-us.apache.org/repos/asf/incubator-calcite/commit/0404fd236ec78e7f83e047972b190cbc7d4fad6a
>
> Its hash is 0404fd236ec78e7f83e047972b190cbc7d4fad6a.
>
> The hashes of the artifacts are as follows:
> src.tar.gz.md5 2c24981f92d86caa9ea258432342cf97
> src.tar.gz.sha1 a97de92ff1be8603d9c5d8402009451a49c5e843
> src.zip.md5 533ecc9be0de2fd917f08857ff76fb26
> src.zip.sha1 ee0a6a5760ed205f6d7666544b4efe04306c7a68
>
> The artifacts to be voted on are located here:
> http://people.apache.org/~jhyde/apache-calcite-0.9.2-incubating-rc1/
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1001
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
>
> Please vote on releasing this package as Apache Calcite 0.9.2-incubating.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PPMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 0.9.2-incubating
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Julian
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by Steven Noels <st...@satisa.be>.
On Thu, Nov 6, 2014, at 08:20 PM, Julian Hyde wrote:
> This is not, in my opinion, a show-stopper for the release.
+1
Steven.
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by Julian Hyde <ju...@gmail.com>.
That file contains the version number of the JDBC driver.
The file has a long name so that it doesn’t get lost if the JDBC driver is bundled into an uber-jar.
Would OSGI be happier if the file was named, say, net/hydromatic/optiq/jdbc/DriverVersion.properties? (Of course this will be renamed to org/apache/calcite in due course.)
The file is generated by core/pom.xml’s resource plugin and variable substitution. version.major and version.minor are obsolete; we now get the major and minor versions of the driver (required for DatabaseMetaData.getDatabaseMajorVersion() etc.) by splitting out the first and second fields of the version string, 0.9.2-incubating-SNAPSHOT. I have logged https://issues.apache.org/jira/browse/CALCITE-456.
This is not, in my opinion, a show-stopper for the release.
Julian
On Nov 5, 2014, at 11:50 PM, Vladimir Sitnikov <si...@gmail.com> wrote:
> There is a file "net-hydromatic-optiq-jdbc.properties" in
> calcite-core-0.9.2-incubating.jar with some non-replaced properties:
> Why do we need that file?
>
> When I run calcite though maven-bundle-plugin (to make a OSGi bundle),
> it results in the following warning:
> [WARNING] Bundle
> com.github.vlsi.mat.calcite:dependencies:bundle:1.1.1-SNAPSHOT :
> Invalid package name: 'net-hydromatic-optiq-jdbc.properties'
>
> Here's the contents of the file in question:
> driver.name=Calcite JDBC Driver
> driver.version=0.9.2-incubating
> product.name=Calcite
> product.version=0.9.2-incubating
> jdbc.compliant=true
> driver.version.major=${version.major} <-- ???
> driver.version.minor=${version.minor}
> database.version.major=${version.major}
> database.version.minor=${version.minor}
> build.timestamp=20141105-1644
>
> Vladimir
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by Vladimir Sitnikov <si...@gmail.com>.
There is a file "net-hydromatic-optiq-jdbc.properties" in
calcite-core-0.9.2-incubating.jar with some non-replaced properties:
Why do we need that file?
When I run calcite though maven-bundle-plugin (to make a OSGi bundle),
it results in the following warning:
[WARNING] Bundle
com.github.vlsi.mat.calcite:dependencies:bundle:1.1.1-SNAPSHOT :
Invalid package name: 'net-hydromatic-optiq-jdbc.properties'
Here's the contents of the file in question:
driver.name=Calcite JDBC Driver
driver.version=0.9.2-incubating
product.name=Calcite
product.version=0.9.2-incubating
jdbc.compliant=true
driver.version.major=${version.major} <-- ???
driver.version.minor=${version.minor}
database.version.major=${version.major}
database.version.minor=${version.minor}
build.timestamp=20141105-1644
Vladimir
Re: [VOTE] Release apache-calcite-0.9.2-incubating (release candidate 1)
Posted by Steven Noels <st...@apache.org>.
On Thu, Nov 6, 2014, at 02:07 AM, Julian Hyde wrote:
> [X] +1 Release this package as Apache Calcite 0.9.2-incubating
+1
Steven.