You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/06/08 11:37:33 UTC

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
-----------------------------------------------------------

(Updated June 8, 2015, 9:37 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, and switched to 'mcypark'.


Changes
-------

Addressed remaining style comments.


Bugs: MESOS-2584
    https://issues.apache.org/jira/browse/MESOS-2584


Repository: mesos-incubating


Description
-------

Removing the process from the header is much cleaner and also fixes the linked clang 3.4.2 JIRA. Apart from that moving, no code is changed.


Diffs (updated)
-----

  src/Makefile.am ec7f41f 
  src/authentication/cram_md5/authenticatee.hpp 55fac68 
  src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32850/diff/


Testing
-------

make check


Thanks,

Till Toenshoff