[jira] Commented: (HARMONY-4423) [classlib][awt][jedit] Toolkit.getLockingKeyState() is not implemented

["Vasily Zakharov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517596 ] 

Vasily Zakharov commented on HARMONY-4423:
------------------------------------------

Wow, Ilya, this patch is great! It seems to work even better than RI does! Thank you!

Just a small note - when throwing UnsupportedOperationException (when Kana key is absent, for example), RI adds a detalization message, like this:

java.lang.UnsupportedOperationException: Keyboard doesn't have requested key

Probably we should do the same.


> [classlib][awt][jedit] Toolkit.getLockingKeyState() is not implemented
> ----------------------------------------------------------------------
>
>                 Key: HARMONY-4423
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4423
>             Project: Harmony
>          Issue Type: Bug
>          Components: App-Oriented Bug Reports, Classlib
>            Reporter: Vasily Zakharov
>            Assignee: Alexey Petrenko
>         Attachments: 4423_win.patch, 4423_win.patch, 4423_win.patch, 4423_win.patch, 4423_win_nosearch.patch, Harmony-4423-Workaround.patch
>
>
> Method java.awt.Toolkit.getLockingKeyState(int) is not implemented and throws RuntimeException when called. This prevents some applications like jEdit automated GUI test scenario from running normally, see HARMONY-3633, it had to provide a special workaround patch to address this issue.
> Implementing this method may be tough as it requires writing native code, however a simple workaround patch may be created to improve compatibility while the real implementation is absent. Here I provide this patch (actually extracted from HARMONY-3633) and my suggestion is to apply it immediately.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.