You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/02/03 22:07:26 UTC
[GitHub] [royale-asjs] chrisdutz opened a new pull request #707: -
Implemented a js-only distribution
chrisdutz opened a new pull request #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707
Refactored the assembies to allow js-only distributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] carlosrovira commented on issue #707: - Implemented a
js-only distribution
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-581810335
Hi Piotr, I already updated the main wiki page with actual info :). All is here:
https://github.com/apache/royale-asjs/wiki/Build-Apache-Royale-with-Maven
with this change you now can avoid "option-with-swf" profile for a JS-only build (no SWF). I'll update wiki page as soon as we fix the JS-only compilation with IDE.
Please, let me know if you see some issue in that page in order to update that page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] carlosrovira commented on issue #707: - Implemented a
js-only distribution
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-581827228
Just fixed the issue with IDEs. It was just a matter of copying frameworks/libs to distribution.
Thanks Chris again for all the work done to get this JS-only maven distribution SDK!! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] carlosrovira commented on issue #707: - Implemented a
js-only distribution
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-581790769
Hi Chris, I tested both with/without SWF and all works well except IDE SDK compiling with js-only version. option-with-swf continues to work in all cases. I'm going to merge since it the issue is just for the new js-only distribution when compiling from IDE. Thanks for doing it! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] piotrzarzycki21 commented on issue #707: -
Implemented a js-only distribution
Posted by GitBox <gi...@apache.org>.
piotrzarzycki21 commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-581795626
@carlosrovira Could you please drop on the list email with exact steps how to run both swf/js distribution build? I know there were some instructions in the other threads, but summary would be awesome. Thanks!
Thanks @chrisdutz !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] piotrzarzycki21 commented on issue #707: -
Implemented a js-only distribution
Posted by GitBox <gi...@apache.org>.
piotrzarzycki21 commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-581839703
> Just fixed the issue with IDEs. It was just a matter of copying frameworks/libs to distribution.
> Thanks Chris again for all the work done to get this JS-only maven distribution SDK!! :)
I still didn't check any of that with Moonshine, unless you did that by saying IDEs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] carlosrovira commented on issue #707: - Implemented a
js-only distribution
Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707#issuecomment-582007258
Hi Piotr,
no, just tested with VSCode. My point is that if VSCode recognize Maven distribution as SDK, and was able to compile TDJ with it successfully then Moonshine should do that too, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [royale-asjs] carlosrovira merged pull request #707: - Implemented
a js-only distribution
Posted by GitBox <gi...@apache.org>.
carlosrovira merged pull request #707: - Implemented a js-only distribution
URL: https://github.com/apache/royale-asjs/pull/707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services