[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #14466: [MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false

[GitBox <gi...@apache.org>]

TaoLv commented on a change in pull request #14466: [MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false
URL: https://github.com/apache/incubator-mxnet/pull/14466#discussion_r267159623
 
 

 ##########
 File path: src/operator/subgraph/mkldnn/mkldnn_fc.cc
 ##########
 @@ -307,9 +302,8 @@ static bool SgMKLDNNFCInferType(const nnvm::NodeAttrs &attrs,
   if (full_param.mkldnn_param.quantized) {
     size_t base_num_inputs = full_param.default_param.no_bias ? 2 : 3;
 
-    // TODO(ciyong): currently, only uint8 fully_connected is upported,
-    // int8 fully_connected will be supported after mkldnn v0.18
-    TYPE_ASSIGN_CHECK(*in_types, 0, mshadow::kUint8);
+    CHECK(in_types->at(0) == mshadow::kInt8 ||
+          in_types->at(0) == mshadow::kUint8);
 
 Review comment:
   Add descriptive error message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services