You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/03/30 06:36:07 UTC
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #783: [#782]refactor: restrict rss.rpc.server.type to an enum
codecov-commenter commented on PR #783:
URL: https://github.com/apache/incubator-uniffle/pull/783#issuecomment-1489771761
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#783](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c04ee31) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/ea5a3ba45b923b1afc8fda0fdb0546daf34274fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea5a3ba) will **increase** coverage by `2.09%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head c04ee31 differs from pull request most recent head 1184fac. Consider uploading reports for the commit 1184fac to get more accurate results
```diff
@@ Coverage Diff @@
## master #783 +/- ##
============================================
+ Coverage 57.86% 59.96% +2.09%
+ Complexity 2028 1895 -133
============================================
Files 298 272 -26
Lines 14520 11272 -3248
Branches 1185 1064 -121
============================================
- Hits 8402 6759 -1643
+ Misses 5643 4126 -1517
+ Partials 475 387 -88
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/uniffle/coordinator/CoordinatorFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JGYWN0b3J5LmphdmE=) | `81.81% <50.00%> (-2.80%)` | :arrow_down: |
| [...rg/apache/uniffle/server/ShuffleServerFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyRmFjdG9yeS5qYXZh) | `73.33% <50.00%> (-3.14%)` | :arrow_down: |
| [...e/shuffle/manager/ShuffleManagerServerFactory.java](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zaHVmZmxlL21hbmFnZXIvU2h1ZmZsZU1hbmFnZXJTZXJ2ZXJGYWN0b3J5LmphdmE=) | `92.85% <100.00%> (-0.90%)` | :arrow_down: |
| [.../org/apache/uniffle/common/config/RssBaseConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQmFzZUNvbmYuamF2YQ==) | `94.04% <100.00%> (ø)` | |
| [...a/org/apache/uniffle/common/rpc/RPCServerType.java](https://codecov.io/gh/apache/incubator-uniffle/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9ycGMvUlBDU2VydmVyVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | |
... and [30 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/783/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org