You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/07/20 19:40:00 UTC
[jira] [Commented] (ZOOKEEPER-3097) Use Runnable instead of Thread
for working items in WorkerService to improve the throughput of
CommitProcessor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551175#comment-16551175 ]
Hadoop QA commented on ZOOKEEPER-3097:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1982//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1982//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1982//console
This message is automatically generated.
> Use Runnable instead of Thread for working items in WorkerService to improve the throughput of CommitProcessor
> --------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3097
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3097
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.6.0
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Minor
> Labels: performance, pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CommitProcessor is using this to submit read/write tasks, each task is initialized as a thread, which is heavy, change it to a lighter Runnable object to avoid the overhead of initializing the thread, it shows promised improvement in the CommitProcessor.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)