You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/26 09:34:08 UTC
[GitHub] [spark] GuoPhilipse opened a new pull request #28932: [SPARK-32088] fix timezone issue
GuoPhilipse opened a new pull request #28932:
URL: https://github.com/apache/spark/pull/28932
### What changes were proposed in this pull request?
add time zone conf during test
### Why are the changes needed?
test will fail if no timezone selected
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28932: [SPARK-32088][PySpark] fix timezone issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650088791
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-651987052
Actually, the SQL config `spark.sql.session.timeZone` is not used in PySpark collect() at all. This PR fixes the problem of running the example in a time zone different from `America/Los_Angeles`: https://github.com/apache/spark/pull/28959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28932: [SPARK-32088][PySpark] fix timezone issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650089212
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28932: [SPARK-32088][PySpark] fix timezone issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650088791
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650091778
**[Test build #124543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124543/testReport)** for PR 28932 at commit [`233ac9c`](https://github.com/apache/spark/commit/233ac9cc305864db62ca78930a00d261b427f142).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650091778
**[Test build #124543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124543/testReport)** for PR 28932 at commit [`233ac9c`](https://github.com/apache/spark/commit/233ac9cc305864db62ca78930a00d261b427f142).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650092459
@GuoPhilipse, can you elaborate a bit more in the PR description about why it fails with which output?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650204062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28932: [SPARK-32088][PySpark] fix timezone issue
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650091239
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28932:
URL: https://github.com/apache/spark/pull/28932
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650092330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] GuoPhilipse commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
GuoPhilipse commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650093357
> @GuoPhilipse, can you elaborate a bit more in the PR description about why it fails with which output?
sure, will improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650092330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650204062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650089212
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28932: [SPARK-32088][PYTHON] Pin the timezone in timestamp_seconds doctest
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28932:
URL: https://github.com/apache/spark/pull/28932#issuecomment-650203014
**[Test build #124543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124543/testReport)** for PR 28932 at commit [`233ac9c`](https://github.com/apache/spark/commit/233ac9cc305864db62ca78930a00d261b427f142).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org