[GitHub] vrahane commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts

[gi...@git.apache.org]

vrahane commented on a change in pull request #318: MYNEWT-681 remove flash write protection in download scripts 
URL: https://github.com/apache/incubator-mynewt-core/pull/318#discussion_r120995342
 
 

 ##########
 File path: hw/bsp/rb-nano2/rb-nano2_download.sh
 ##########
 @@ -37,6 +37,15 @@ if [ "$MFG_IMAGE" ]; then
     FLASH_OFFSET=0
 fi
 
+# We write the config registers for BPROT so that NVMC write
+# protection gets disabled for all blocks of the flash
+# We also write the DISABLEINDEBUG register so that, write
+# protection gets disabled in debug register by default
+EXTRA_GDB_CMDS="set {unsigned long}0x40000600=0;set {unsigned long}0x40000604=0;\
 
 Review comment:
   Sorry, my bad. I assumed there was a EXTRA_GDB_CMDS in the openocd script. CFG_POST_INIT goes to the OCD_CMD_FILE which is more of ocd commands than gdb commands. I think what is missing in the openocd script is EXTRA_GDB_CMDS which goes to the GDB_CMD_FILE. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services