You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/05/25 20:27:09 UTC
Review Request 47850: GEODE-1454: Have "region" attribute,
in JSONAuthorization json file be an array
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47850/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
- Also converted to Jackson. Be gone org.json!!
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json fbbda8d0369bd7fdf400ba226c67d4c1861de62e
Diff: https://reviews.apache.org/r/47850/diff/
Testing
-------
Thanks,
Jens Deppe
Re: Review Request 47850: GEODE-1454: Have "region" attribute,
in JSONAuthorization json file be an array
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47850/#review135953
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On May 25, 2016, 8:27 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47850/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:27 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Also converted to Jackson. Be gone org.json!!
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json fbbda8d0369bd7fdf400ba226c67d4c1861de62e
>
> Diff: https://reviews.apache.org/r/47850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47850: GEODE-1454: Have "region" attribute,
in JSONAuthorization json file be an array
Posted by Jens Deppe <jd...@pivotal.io>.
> On May 25, 2016, 9:03 p.m., Jinmei Liao wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java, line 14
> > <https://reviews.apache.org/r/47850/diff/1/?file=1393924#file1393924line14>
> >
> > What about the ExampleJSONAuthorization? Do we need to change that also?
I'll do that as part of moving it into 'main'.
- Jens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47850/#review134835
-----------------------------------------------------------
On May 25, 2016, 8:27 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47850/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:27 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Also converted to Jackson. Be gone org.json!!
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json fbbda8d0369bd7fdf400ba226c67d4c1861de62e
>
> Diff: https://reviews.apache.org/r/47850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 47850: GEODE-1454: Have "region" attribute,
in JSONAuthorization json file be an array
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47850/#review134835
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java (line 14)
<https://reviews.apache.org/r/47850/#comment199766>
What about the ExampleJSONAuthorization? Do we need to change that also?
geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json (line 82)
<https://reviews.apache.org/r/47850/#comment199765>
we can get rid of the null now.
- Jinmei Liao
On May 25, 2016, 8:27 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47850/
> -----------------------------------------------------------
>
> (Updated May 25, 2016, 8:27 p.m.)
>
>
> Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Also converted to Jackson. Be gone org.json!!
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java e14d1def97a06e479cbeeffe56a05e8e8de16d65
> geode-core/src/test/resources/com/gemstone/gemfire/management/internal/security/cacheServer.json fbbda8d0369bd7fdf400ba226c67d4c1861de62e
>
> Diff: https://reviews.apache.org/r/47850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jens Deppe
>
>