You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/20 05:50:15 UTC

[GitHub] [incubator-superset] yamyamyuo opened a new issue #8073: druid connector multiple time shift bug

yamyamyuo opened a new issue #8073: druid connector multiple time shift bug
URL: https://github.com/apache/incubator-superset/issues/8073
 
 
   Superset version: 0.26.2
   superset druid connector  bug with `time series - line chart`. when we use more than one time shift like `1 day`, `1 week` time shift, the chart will show like this:
   <img width="656" alt="Screen Shot 2019-08-20 at 1 38 50 PM" src="https://user-images.githubusercontent.com/8351385/63320419-4b525e00-c350-11e9-9b73-25864b278f88.png">
   
   
   ### Expected results
   three lines separate.
   <img width="682" alt="Screen Shot 2019-08-20 at 1 38 59 PM" src="https://user-images.githubusercontent.com/8351385/63320456-6755ff80-c350-11e9-866d-283e72e1dd4e.png">
   
   what you expected to happen.
   the chart could render correctly like above image.
   
   #### How to reproduce the bug
   
   1. Go to 'Chart', new chart, select a datasource.
   2. make a chart with viz type: 'time series - line chart'. then in the `advanced analytics`, choose more than one time shift.
   3. press run
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `0.26.2`
   - python version: `2.7`
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ x] I have reproduced the issue with at least the latest released version of superset.
   - [x ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   We debug and find the root cause, the cache key will be conflict for those time shift. That means `1 week` time shift will use `1 day` time shift's data.
   
   Why the cache_key conflct? https://github.com/apache/incubator-superset/blob/0.26.2/superset/viz.py#L342 because the difference of `1 day` and `1 week` key was delete. 
   
   Does anyone have the same problem? should we change the logic of `cache_key`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org