You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/03/01 02:39:27 UTC
Review Request 57178: [ATLAS-1607] : Notify listeners on
classification addition/deletion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57178/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1607
https://issues.apache.org/jira/browse/ATLAS-1607
Repository: atlas
Description
-------
notify entity listeners on classification addition and deletion.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ec2a7c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java af1066d
Diff: https://reviews.apache.org/r/57178/diff/
Testing
-------
EntityNotificationIT suceeded which tests testAddTrait() and testDeleteTrait()
Thanks,
Sarath Subramanian
Re: Review Request 57178: [ATLAS-1607] : Notify listeners on
classification addition/deletion
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57178/#review167211
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 1, 2017, 6:33 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57178/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 6:33 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1607
> https://issues.apache.org/jira/browse/ATLAS-1607
>
>
> Repository: atlas
>
>
> Description
> -------
>
> notify entity listeners on classification addition and deletion.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 01c077a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ec2a7c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java af1066d
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 993cf61
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96c2ce5
> server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e9a7d1a
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 8a1991c
>
>
> Diff: https://reviews.apache.org/r/57178/diff/3/
>
>
> Testing
> -------
>
> EntityNotificationIT suceeded which tests testAddTrait() and testDeleteTrait()
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 57178: [ATLAS-1607] : Notify listeners on
classification addition/deletion
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57178/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 10:33 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1607
https://issues.apache.org/jira/browse/ATLAS-1607
Repository: atlas
Description
-------
notify entity listeners on classification addition and deletion.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 01c077a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ec2a7c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java af1066d
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 993cf61
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96c2ce5
server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e9a7d1a
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 8a1991c
Diff: https://reviews.apache.org/r/57178/diff/3/
Changes: https://reviews.apache.org/r/57178/diff/2-3/
Testing
-------
EntityNotificationIT suceeded which tests testAddTrait() and testDeleteTrait()
Thanks,
Sarath Subramanian
Re: Review Request 57178: [ATLAS-1607] : Notify listeners on
classification addition/deletion
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57178/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 10:28 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Changes
-------
updated patch to send all added/deleted tags in a single call to listeners
Bugs: ATLAS-1607
https://issues.apache.org/jira/browse/ATLAS-1607
Repository: atlas
Description
-------
notify entity listeners on classification addition and deletion.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java 01c077a
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java 4ec2a7c
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java af1066d
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 993cf61
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96c2ce5
server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e9a7d1a
webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java 8a1991c
Diff: https://reviews.apache.org/r/57178/diff/2/
Changes: https://reviews.apache.org/r/57178/diff/1-2/
Testing
-------
EntityNotificationIT suceeded which tests testAddTrait() and testDeleteTrait()
Thanks,
Sarath Subramanian